From patchwork Mon Dec 23 13:24:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 182406 Delivered-To: patch@linaro.org Received: by 2002:a92:a146:0:0:0:0:0 with SMTP id v67csp425311ili; Mon, 23 Dec 2019 05:25:14 -0800 (PST) X-Google-Smtp-Source: APXvYqyjz6aMH74J49dP+smmRw7Iiwovr4k/RwmcfE0miw5JGp0bDhfwyXGnpaPhKELcMdih3I3m X-Received: by 2002:a9d:6d06:: with SMTP id o6mr33157705otp.239.1577107513857; Mon, 23 Dec 2019 05:25:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577107513; cv=none; d=google.com; s=arc-20160816; b=rE0T7v3SCypqY/TM4J+tSwHyQ77/pP4nNqLb5VLEEWr+q3ODlOliv8krEvFHccZmpI v6v+14qSkcDCcuUZBy25VES3O4bXMu1MWiBKAWQIZXAi9yQ1ouwf3cuaH55eM2AFOjDd +AKYBMJD5pjOxAQSOnRn3WII1nSCJV+RAn5PmlilcSliEGDXcnm7kkFHSg+7I5InUBWw l4S1uquxQ2ur/DGhtNg2OOg98dyoB8SYgbL24DQvPoq5RoHD+CN27c2dmESKNk8ZmS2r qItFi5wbivVQRg1Ehsl4yC2XLquyQIpiuhUVpO6wXP5bnD+Eh0LP3NSKOOPFK6pILsqW bE3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MzYlapizAmpPv7mHUy2o5JN+J0eago0Jfjc2U2jppA4=; b=VnfGpqtrv5hdfM393ptexk6fXBynmvE2xs5lbKijjXoujeMHRGaCYUy0fRTwIFGQGQ s+yvWqaKe3b8Xj2QPj655+HP6ODL1v+pTJgRoud6hAfYBGOAEtc4D1Fnb7le0uKR4gj3 abxrJNxLy/z217tV1Q7hNvR+nVZuMz1yGHOC1CgqLiBOmxzN++Ph4ziTBQPUiUu4n8Xn qbBoScX64pBQ4n38b4i92efyZNC3m7H7qI/xuoP+W1D3g2gy4/hyQAsK8eg2s2jjwxcY Kw0KL1TcgrWiclZgHAP/O21ofQFZxkJIZjugyBAy9M4KyH0sYi4nkUcf7JrPET37Z4HS kyBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=wLe3r14O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u12si5994004oiv.13.2019.12.23.05.25.12; Mon, 23 Dec 2019 05:25:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=wLe3r14O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726834AbfLWNZL (ORCPT + 27 others); Mon, 23 Dec 2019 08:25:11 -0500 Received: from frisell.zx2c4.com ([192.95.5.64]:34193 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726676AbfLWNZL (ORCPT ); Mon, 23 Dec 2019 08:25:11 -0500 Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 33177afe; Mon, 23 Dec 2019 12:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=from:to:cc :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=mail; bh=PR2EZO8ufGYRsxJoOzfwo7jvX u4=; b=wLe3r14OcAm7t4tv5liciSiyFaX8aDUzz9GpVXEbPSL9j6jGPHGZh0bu2 RSusyyCf6irJqgVfNCT161fHlrfUPVPUkk6ya66R+lXfVDk1mn5Th8l3sfjGpVCu SGKBKyDmVP7N7rYjjWc5xyzr+DLtjD6FFAUj2Xt1erL7eMIoDnJukTXCrS4Q9WUn 8utRd7vFMeHbeHlhgTXn0GvXarfKZc4dXml1JZk4QH9GW3S0hxS+xDg79/cAxFbj GgHGoIeZWFa2Ah7ndgNcna6f5fiuXTJKaytsrD3rQMgAqitAbKOtw6Ji4uCE0cG4 ZUJfAX1OHKxR8Q46a7vQDUdJ1FCuw== Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 05becb2e (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 23 Dec 2019 12:27:56 +0000 (UTC) From: "Jason A. Donenfeld" To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net Cc: "Jason A. Donenfeld" , Antoine Tenart Subject: [PATCH net] of: mdio: mark stub of_mdiobus_child_is_phy as inline Date: Mon, 23 Dec 2019 14:24:43 +0100 Message-Id: <20191223132443.115540-1-Jason@zx2c4.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The of_mdiobus_child_is_phy function was recently exported, with a stub fallback added to simply return false as a static function. The inline specifier was left out, leading to build time errors: In file included from linux/include/linux/fs_enet_pd.h:21, from linux/arch/powerpc/sysdev/fsl_soc.c:26: linux/include/linux/of_mdio.h:58:13: error: ‘of_mdiobus_child_is_phy’ defined but not used [-Werror=unused-function] 58 | static bool of_mdiobus_child_is_phy(struct device_node *child) | ^~~~~~~~~~ This commit simply adds the missing inline keyboard. Fixes: 0aa4d016c043 ("of: mdio: export of_mdiobus_child_is_phy") Cc: Antoine Tenart Signed-off-by: Jason A. Donenfeld --- include/linux/of_mdio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.24.1 diff --git a/include/linux/of_mdio.h b/include/linux/of_mdio.h index 79bc82e30c02..491a2b7e77c1 100644 --- a/include/linux/of_mdio.h +++ b/include/linux/of_mdio.h @@ -55,7 +55,7 @@ static inline int of_mdio_parse_addr(struct device *dev, } #else /* CONFIG_OF_MDIO */ -static bool of_mdiobus_child_is_phy(struct device_node *child) +static inline bool of_mdiobus_child_is_phy(struct device_node *child) { return false; }