From patchwork Mon Dec 16 17:48:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 181760 Delivered-To: patch@linaro.org Received: by 2002:ac9:44c4:0:0:0:0:0 with SMTP id t4csp4620538och; Mon, 16 Dec 2019 09:56:57 -0800 (PST) X-Google-Smtp-Source: APXvYqz9X5Pdj6ifLbvDL2gnxXKammfY6x4Xv7stX380/I4pDcFqOcfo7CRTtHiW4enVFUtAPIGT X-Received: by 2002:a05:6830:611:: with SMTP id w17mr33364639oti.191.1576519017074; Mon, 16 Dec 2019 09:56:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576519017; cv=none; d=google.com; s=arc-20160816; b=zmcgmhKHKQhaq0Eef5ejo5gxEGy7ABws4GLYD47V9af+XrVpx4RdN/he9hCC0AruEe vGaE6bv+k4qWp56HiVfF+sdWVGJFamZT6SmRwFjLwatoepFdaRDsxZdJpXssNV8ZP2lx H8CPWg1RU9WqHM6PSpIti1yUPtCsBL5G0SIFsuF8ypj7VC8AYTT/jXHou3HjwdleDbJs +1dvlnwniQScMWzfDh9y+DNcVlxJmh9ol8aD3QXpKeRKKZpcqmFuLdUdyu0Ir4I1G5XV vUXUT1h+2og+tIBk+EH9zx6MCY+ZvzYF8imClMW6IvgQLTzx/3Eh95eiZCvh9sIs72lR BsKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=E5z9zzXebUYr8dVlUFJA84xoYjSsQU3d8yGESmJwYd0=; b=qunKowfYOvFaA1/M7QH2rfxhHBvaV0kIkxNAUSe5E5SU21PTQksNeuoA+XcOfUuOO1 IpzBXW4DOnUUc8gZcRf4nGDbKnvdR6xsFjzwpviHqdvPgx1kIPoN0qn9EZlmtsgmvXMq uFG0YflCEjPho/a9nwl2NmtTmUTBCSwMyHhA2c6fGIv11l2lzJXrxkcO04c3+hicCtyF Om+PLsaUzT747sUF9YCJKhopF9Em+JYuwkpKEEGNWV5hn2YhCG18a1GEFv2EFgNDBhWl IOrTjfBAGT4saIoC2XUesBolXxhRVZsiya8tqD6pGtE99ILewq43foqhjbga20ECVmxF Zseg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="D5vQIQ8/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l8si11419785otq.75.2019.12.16.09.56.56; Mon, 16 Dec 2019 09:56:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="D5vQIQ8/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727462AbfLPR4z (ORCPT + 27 others); Mon, 16 Dec 2019 12:56:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:55324 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727873AbfLPR4x (ORCPT ); Mon, 16 Dec 2019 12:56:53 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B09C20733; Mon, 16 Dec 2019 17:56:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519012; bh=2qsDb3uYXabTjglgCrsX28LgWcVWJRMwmsnRQjxE+5I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D5vQIQ8/w/QIyNrS3PPwTOwYg6J6oLRbS/P3p/p1T6s8Q2HF5fy7gaE3j1GppwgFt Yy9jdJQX7Nv1tuHDSAhCnKCQO0aJl0kIvWe7bg8T8ZRCLt+oGR4HdtOkZk4YaCQEoM 07yBcHTzM4AwZi89Tr++X+oB6mcG3PEevn21/Vc8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Stanimir Varbanov , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 4.14 160/267] media: venus: remove invalid compat_ioctl32 handler Date: Mon, 16 Dec 2019 18:48:06 +0100 Message-Id: <20191216174911.271324041@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174848.701533383@linuxfoundation.org> References: <20191216174848.701533383@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann commit 4adc0423de92cf850d1ef5c0e7cb28fd7a38219e upstream. v4l2_compat_ioctl32() is the function that calls into v4l2_file_operations->compat_ioctl32(), so setting that back to the same function leads to a trivial endless loop, followed by a kernel stack overrun. Remove the incorrect assignment. Cc: stable@vger.kernel.org Fixes: 7472c1c69138 ("[media] media: venus: vdec: add video decoder files") Fixes: aaaa93eda64b ("[media] media: venus: venc: add video encoder files") Signed-off-by: Arnd Bergmann Acked-by: Stanimir Varbanov Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/qcom/venus/vdec.c | 3 --- drivers/media/platform/qcom/venus/venc.c | 3 --- 2 files changed, 6 deletions(-) --- a/drivers/media/platform/qcom/venus/vdec.c +++ b/drivers/media/platform/qcom/venus/vdec.c @@ -1060,9 +1060,6 @@ static const struct v4l2_file_operations .unlocked_ioctl = video_ioctl2, .poll = v4l2_m2m_fop_poll, .mmap = v4l2_m2m_fop_mmap, -#ifdef CONFIG_COMPAT - .compat_ioctl32 = v4l2_compat_ioctl32, -#endif }; static int vdec_probe(struct platform_device *pdev) --- a/drivers/media/platform/qcom/venus/venc.c +++ b/drivers/media/platform/qcom/venus/venc.c @@ -1166,9 +1166,6 @@ static const struct v4l2_file_operations .unlocked_ioctl = video_ioctl2, .poll = v4l2_m2m_fop_poll, .mmap = v4l2_m2m_fop_mmap, -#ifdef CONFIG_COMPAT - .compat_ioctl32 = v4l2_compat_ioctl32, -#endif }; static int venc_probe(struct platform_device *pdev)