From patchwork Sat Nov 23 13:27:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 180092 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp736111ilf; Sat, 23 Nov 2019 05:28:31 -0800 (PST) X-Google-Smtp-Source: APXvYqxOUR1HQXyesEMd8EMFvwcBkNIXSodheJnmDTOZo48BJlgMF9xkqzNF0O/fRcEPBIK9+raP X-Received: by 2002:a17:906:c41:: with SMTP id t1mr26991496ejf.282.1574515711551; Sat, 23 Nov 2019 05:28:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574515711; cv=none; d=google.com; s=arc-20160816; b=glharDcbIfbNlrLvxsPX8TC86RG6K7xBmPM5Vp0XpRpdan/UH3JXlc+3qaCVXjj96l E+oKE/iRMmV177t4DSnXQRwsYY45lPkiKwaX9a8RU2rPg9hGZhtOc34wv91UTIO8OeJF /0YTw6LYxQ9LIRmTyqeXrHsfk6wmFs/7Eq3VKKqCcnNrHsL2AYKzFG0jOBO4nf/OQ321 IPHAaPn0g4Ab6axtqpPuJTfbZ7nX2oMLEYKVz20pfGY+o+WLVlXBf5IR5XXVEc9rKfkW B8IHMpGhBILGp/7BnzXECw9FiaR2t9R7DVSUo7humC/ci/s89+8u1kt8IYjwG/M5woyt BkpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=7GX2WjlpLbqGoaEHNabrSpwDglBUHJ7U4pgd8VDnbJY=; b=Q2mP6kObIluM2x1UY6+nH+zipIvp5daD2QV9BkuBox1oyXQPoa2yvuvavtOuyaYkQe iMphqmmTH9UTbeP91AvJscG/96XgrdLWVIkkybl8ee8o4AsjZr5aABIFrQj6fn3syUrY j9s2MZHLf6GB2BEW438tqDF/s9f29+Os+aK6i4JxCfYAmZaNqZHyw3MM/J18FaFAQ7xH 1NRA7epI3/BIaQZJ6lATbK56Fpv0W878+z8enLfZzUBKFJSqs0YkO6dd5FbwvLciD5bl c4dRiZ69yMpO706BGe8FY0uPh+nQgq4uBuzvIpAGtGrKGzv4UPCnbyhhvdm2OJOT6w46 oseA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=N85SUdQu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y24si796861edm.333.2019.11.23.05.28.31; Sat, 23 Nov 2019 05:28:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=N85SUdQu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727125AbfKWN21 (ORCPT + 26 others); Sat, 23 Nov 2019 08:28:27 -0500 Received: from conuserg-10.nifty.com ([210.131.2.77]:39544 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726775AbfKWN2B (ORCPT ); Sat, 23 Nov 2019 08:28:01 -0500 Received: from grover.flets-west.jp (softbank126093102113.bbtec.net [126.93.102.113]) (authenticated) by conuserg-10.nifty.com with ESMTP id xANDRbkc000733; Sat, 23 Nov 2019 22:27:39 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com xANDRbkc000733 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1574515660; bh=7GX2WjlpLbqGoaEHNabrSpwDglBUHJ7U4pgd8VDnbJY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N85SUdQujbubtocMqLhU8ab+LMgOFbjmqCW2+pDR5QuUdFSlVXl1WfcDuc2YIl1DP LhpXB5v9kq586eMLSiXzINnuMSKD3TMchRKDq00iMWpQRPT+fLJ/w+CHXpbnHe7qML 5UYc8LlRI667jDTiqQlL0p61zE8KsnB8WCaE67lQ1DAExl+p39H5Vwzx+G7eN/HT6d ZvnfSjD4jUR4g49QEpc9mlDT9PDNXbNnUt5mfa7EbZlhefjvU8XAAp286O5Um5J5aN 9h4SN8UWq06tlNo0qLHiZoxpWxe0Z8YT6avbsYoYuuAJz0RbFVGmc/2Z4PKFr+6HN1 C4kV72XZoqNNg== X-Nifty-SrcIP: [126.93.102.113] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 03/16] scripts/kallsyms: set relative_base more effectively Date: Sat, 23 Nov 2019 22:27:14 +0900 Message-Id: <20191123132727.30151-4-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191123132727.30151-1-yamada.masahiro@socionext.com> References: <20191123132727.30151-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, record_relative_base() iterates over the entire table to find the minimum address, but it is not efficient because we sort the table anyway. After sort_symbol(), the table is sorted by address. (kallsyms parses the 'nm -n' output, so the data is already sorted by address, but this commit does not rely on it.) Move record_relative_base() after sort_symbols(), and take the first non-absolute symbol value. Signed-off-by: Masahiro Yamada --- scripts/kallsyms.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) -- 2.17.1 diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c index 79641874d860..0959e1de381c 100644 --- a/scripts/kallsyms.c +++ b/scripts/kallsyms.c @@ -731,11 +731,15 @@ static void record_relative_base(void) { unsigned int i; - relative_base = -1ULL; for (i = 0; i < table_cnt; i++) - if (!symbol_absolute(&table[i]) && - table[i].addr < relative_base) + if (!symbol_absolute(&table[i])) { + /* + * The table is sorted by address. + * Take the first non-absolute symbol value. + */ relative_base = table[i].addr; + return; + } } int main(int argc, char **argv) @@ -758,9 +762,9 @@ int main(int argc, char **argv) read_map(stdin); if (absolute_percpu) make_percpus_absolute(); + sort_symbols(); if (base_relative) record_relative_base(); - sort_symbols(); optimize_token_table(); write_src();