From patchwork Fri Nov 15 22:33:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 179525 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp13126210ilf; Fri, 15 Nov 2019 14:34:00 -0800 (PST) X-Google-Smtp-Source: APXvYqwIZ5Eyalq9NtOseyD8If0O9nKs4Xqi2Na9iyiuWJUsc79c0PlrDJ19OrqE25L/KgG7MNrB X-Received: by 2002:a17:906:1395:: with SMTP id f21mr4305540ejc.152.1573857240468; Fri, 15 Nov 2019 14:34:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573857240; cv=none; d=google.com; s=arc-20160816; b=vlTWVQx6jFCV3anEtxYwnKEtik/NGywPC85FGjHt3OTmqZXqxEpduXyMD3OD4fD1+0 TT+CRJHMPeQyprLvcwIHt00y9AaAQPIOwSo30z85yVQ3nZU+Rz9ZKXpTTnuZAbbtTKPt Vtc1sYieJPgFAnrhPB7e9qVGNYFmaCZyopYZYkYg7Xzow4MNe58EsWjT5yIuidMovrLC NEocUZOgp8A55m9Pu07ZaOKwvZ5yOGMIPInpNa7nPQZYyY3x6NDjud0ZmSjST594R58R dHEpRENcc2bHfgbDdYWAaF1202DfUVCvZcRDnAdR99JERNJfAYLNjlo7a1CSO18PP1Ul uOIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=Tc+IEmTbMBJCj4EiVIkUr9PV2atSgJthk3up+qVhyOE=; b=RA1S5Z1qY/MoQ8ABO7uXD21JVvvIrexDo7iP/+NbzwJb0sZhEKuyb8aHozNUbYXLKF nzjYiaQUH9hyUVy+ZiOe8WFlQO+zkU81n2lwRljGvEa9NB827vYbVNm3iY5qSBRBuk+E q9mJMYeuwDNIUrUsacY43FhMiZcDU1GXlgPs8syICWVpRQM2QqLjIAsMMzae2Ix20yhw qBS85G6nYB+xuAG66o2/+VI9jucykEs62Q3bJDOG5lrPeAVcvAXs174ajpvVHsitDauK +DWIQkzzczke+sJAROMtE2zVVyAHsbFg3ryc0C4CU8GJ6+mo90hWIxISYvxCxkS3iLcW sCxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BoaaaX8R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id be24si4552697edb.156.2019.11.15.14.34.00; Fri, 15 Nov 2019 14:34:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BoaaaX8R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727020AbfKOWd7 (ORCPT + 26 others); Fri, 15 Nov 2019 17:33:59 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:47086 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726865AbfKOWd6 (ORCPT ); Fri, 15 Nov 2019 17:33:58 -0500 Received: by mail-pg1-f195.google.com with SMTP id r18so6596813pgu.13 for ; Fri, 15 Nov 2019 14:33:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Tc+IEmTbMBJCj4EiVIkUr9PV2atSgJthk3up+qVhyOE=; b=BoaaaX8RsyTJpotwcaZaTD6Tyhn833MOIIDHMWr3NTNPT5Mmx71uuoUUG3DF6Dup9s lAeMeISC4gG/92nA7AyPgTb37ys0iuHbAxbDO3MU0OERSfxWYFUPDT113kahRoqHbacV 1t2mCpDH0ZffJLXrG8zehsSd086kaA621p1+yYiMxgHdxcG5EAUKq3YCqy6MmqrI/Es/ jcnzhcv9t4AopOYTO8EQg53V68MNnuwplarZG6y/N4NId2Rw73Yj2+YdKFtJGEvW7J+1 VuZbzXMxe1W0aqKbfqGyJgz/TEKm+UhMbJtGGZ6czxRqmh5bNfZmhSfjIiVFZ/z7ZgGU 1VrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Tc+IEmTbMBJCj4EiVIkUr9PV2atSgJthk3up+qVhyOE=; b=WBjur65KQrBOnTsvZv2cAo2f6lLIpdu/6OUelGIWeW0GKbRDfVL7iB1iezZC97SXvt epTq4mDbFcx2Z9v2lEZJgXvCpCctZTAJkqALkKcVA1fp10MUpemfnMRdo3pTfU5edohI 4V1bcel9rTakCBKXMdrOKfMO9EHFiie7ofs7Z8S3sJVo6Op3YPUmfFW5AaUpSwahi56m WhRi76hPxOlewcE1CKLfa2Ei4pLcDxxfQ6AlqETTlYZaZMtWyf0yj39+z0JdmpsVtdFk VfcIKdTUZoBgATyXH2J82CpuzYfpxanoWhtrLltkBpr/ECWzBxRCVEYM6yexdd214fRw 6VRg== X-Gm-Message-State: APjAAAWUi9wFgxmh7pagXSRq+YA3+Hf5DE57jSb04n9CzDHL4jaeBi3s q+2YzRmll2pzRzUVjt1qipPWbt4dBLQ= X-Received: by 2002:aa7:870c:: with SMTP id b12mr20357084pfo.30.1573857238096; Fri, 15 Nov 2019 14:33:58 -0800 (PST) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id m15sm11699724pfh.19.2019.11.15.14.33.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2019 14:33:57 -0800 (PST) From: Mathieu Poirier To: stable@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [stable 4.19+][PATCH 01/20] i2c: stm32f7: fix first byte to send in slave mode Date: Fri, 15 Nov 2019 15:33:37 -0700 Message-Id: <20191115223356.27675-1-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fabrice Gasnier commit 915da2b794ce4fc98b1acf64d64354f22a5e4931 upstream The slave-interface documentation [1] states "the bus driver should transmit the first byte" upon I2C_SLAVE_READ_REQUESTED slave event: - 'val': backend returns first byte to be sent The driver currently ignores the 1st byte to send on this event. [1] https://www.kernel.org/doc/Documentation/i2c/slave-interface Fixes: 60d609f30de2 ("i2c: i2c-stm32f7: Add slave support") Signed-off-by: Fabrice Gasnier Reviewed-by: Pierre-Yves MORDRET Signed-off-by: Wolfram Sang Cc: stable # 4.19+ Signed-off-by: Mathieu Poirier --- drivers/i2c/busses/i2c-stm32f7.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.17.1 diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c index ac9c9486b834..48521bc8a4d2 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -1177,6 +1177,8 @@ static void stm32f7_i2c_slave_start(struct stm32f7_i2c_dev *i2c_dev) STM32F7_I2C_CR1_TXIE; stm32f7_i2c_set_bits(base + STM32F7_I2C_CR1, mask); + /* Write 1st data byte */ + writel_relaxed(value, base + STM32F7_I2C_TXDR); } else { /* Notify i2c slave that new write transfer is starting */ i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);