From patchwork Thu Nov 7 20:16:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 178830 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp1581687ilf; Thu, 7 Nov 2019 12:17:38 -0800 (PST) X-Google-Smtp-Source: APXvYqwDOWjBcAh9Uqd9otJ4t9MYJPojG4qWo9m1btmMJmNUvx3uM5XWlqHvVcx3xR4q36Q9SP4k X-Received: by 2002:a17:907:2078:: with SMTP id qp24mr5016212ejb.157.1573157858565; Thu, 07 Nov 2019 12:17:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573157858; cv=none; d=google.com; s=arc-20160816; b=0BfhwcfiugBIlDCgZmi6UyYi9fPmm2nw1pGZx7gN3iRlHmnsOnHcQZkSVSzHVKJ4xN 2WJWQqv6rM6zXb2hhhuXWieRbbVgwIUKCARqMZgavnxSWYtI5PsubJ2OdVDmAgVPSLel H2K0ix3OjpinCo51u4FTsawXUDcc5pSUWB47FA+RlAiD7m2L7trC9UHxjsxU7ERyTFtt A9+UI8N2yyXWk2AgnA4uHk+4QeCfyGx2mpbtwzXoH57/icTgrrHamqjcDqrDbpTT4eLW bQ8phvNafw7ymh7/9H3D3dYPvJ6CStbVBuyaOwKeFM0Qb8UlH7837T7io60eE9Y4TRQH 4kuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qbI1BAgAkPaImSA31avjQBXyIdfFKUwTp+KLI6AEZH0=; b=Q/98EW5UR3+hjko0NjISfUUIa1FDpKFBuc9aWtuV8YXAlezbDyTmzhIaLY49DMbFCe aRGypxLEKE3mMyTCbKdv6OE4c+AU4Gm5XImcTfBymNQfPp0Nbwv231hFsVY3ktyhRc72 uuecAHOmCLmbfcdSY02tgcxmnp501PrEPHQVKzYnNOJZWxrmul1JxZezmC3GsmFG+apA LN5RbH8swbiHojyj3wRRcmGHVePa6dlwGA6FhcXrl1wWAvfyMKoXTOGKol2EawVUm6A6 O+EXnlPBFpjNZTJE45ysRMQm8t/fU/6ECGKqqKmHis1zCzDkWa3r5qWYKuxDZ5AyShNH bvLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="EC/SX8oo"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f3si2137345ejb.49.2019.11.07.12.17.38; Thu, 07 Nov 2019 12:17:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="EC/SX8oo"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726612AbfKGURL (ORCPT + 26 others); Thu, 7 Nov 2019 15:17:11 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:37832 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725792AbfKGURJ (ORCPT ); Thu, 7 Nov 2019 15:17:09 -0500 Received: by mail-wr1-f66.google.com with SMTP id t1so4572306wrv.4 for ; Thu, 07 Nov 2019 12:17:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qbI1BAgAkPaImSA31avjQBXyIdfFKUwTp+KLI6AEZH0=; b=EC/SX8ooYqTxr5pQUlGH6g2yvyeF1kpJrkFWbvWtgr9gM5Iyl2llrDdEp7D0xc/ckc ylpxAJXxfPTRewHYEUFf27rRf6OgKgwfod65R20q3y8PspodxrnnoNVES54RwWuDDEpq SsHlynYxsuBNvn0l2/BMHVk1L0kCIEaI31sdizplPtimHczDVHahZ8j/MIxu3T9GpPTn M5jVzoulmUi+TraL/W6sI7/MBMMzPtNWYjvL46ILMEWPqXx2zbH0RJBFrbBv+JFvYPqr k+PMcl6B7+yLQprGnJqMAS3oiTZ6vHClRRoA7MElF5y2dMfk5TLqZOALfA0c6ZwIhoj/ jyVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qbI1BAgAkPaImSA31avjQBXyIdfFKUwTp+KLI6AEZH0=; b=B3D+k4uwioAG57dLmHH+69lSjGNV65HYfY/8NOR94YxewCRgsCzPW6ooAp6Wiqmgod lYRDYNrn3zAjj/9v5Her1ninK2v9OmPIwBmMaXoe5AsA2hAfekI5KKLVWLlgECIiE8mi gz39nN56T3hmr7KFwLs3WwFohZ7BNXHp+4yCmzjFZ0ZiuG6/BA1dWHPKmp3HhLyH9Hku uDVXkBUd05dLXKXPn1caEyFXT4onqmTtFk1HVzKekHDyLXPwp3tLMBNgG0an8gcKash5 UKw+IFHNnGJW/Lt4m9DRPXn0SaOg0WgvAJkVyCQ3OT6AHnM/XMJEtTPXaoD//6my38DZ 3llA== X-Gm-Message-State: APjAAAXQG0xa70V0ymS24nXfGYkVN3iS8jqKTdZ5RKJsel69+2bLrwyw BdgYaNjtlBHG8vJtb73ECPuoFSsDqpA= X-Received: by 2002:adf:8481:: with SMTP id 1mr5190613wrg.189.1573157827384; Thu, 07 Nov 2019 12:17:07 -0800 (PST) Received: from localhost.localdomain ([95.147.198.88]) by smtp.gmail.com with ESMTPSA id d11sm3215162wrn.28.2019.11.07.12.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2019 12:17:06 -0800 (PST) From: Lee Jones To: gregkh@google.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Alexandre Belloni , Sylvain Lemieux , James Grant , Felipe Balbi , Sasha Levin , Lee Jones Subject: [PATCH 02/10] usb: gadget: udc: lpc32xx: allocate descriptor with GFP_ATOMIC Date: Thu, 7 Nov 2019 20:16:54 +0000 Message-Id: <20191107201702.27023-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191107201702.27023-1-lee.jones@linaro.org> References: <20191107201702.27023-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexandre Belloni [ Upstream commit fbc318afadd6e7ae2252d6158cf7d0c5a2132f7d ] Gadget drivers may queue request in interrupt context. This would lead to a descriptor allocation in that context. In that case we would hit BUG_ON(in_interrupt()) in __get_vm_area_node. Also remove the unnecessary cast. Acked-by: Sylvain Lemieux Tested-by: James Grant Signed-off-by: Alexandre Belloni Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin Signed-off-by: Lee Jones Change-Id: Iac6fdb2f664de82dde243dfa15b81e4add2198bf --- drivers/usb/gadget/udc/lpc32xx_udc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.24.0 diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c index 23d0475a9136..928e0dd2f2d3 100644 --- a/drivers/usb/gadget/udc/lpc32xx_udc.c +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c @@ -966,8 +966,7 @@ static struct lpc32xx_usbd_dd_gad *udc_dd_alloc(struct lpc32xx_udc *udc) dma_addr_t dma; struct lpc32xx_usbd_dd_gad *dd; - dd = (struct lpc32xx_usbd_dd_gad *) dma_pool_alloc( - udc->dd_cache, (GFP_KERNEL | GFP_DMA), &dma); + dd = dma_pool_alloc(udc->dd_cache, GFP_ATOMIC | GFP_DMA, &dma); if (dd) dd->this_dma = dma;