From patchwork Thu Oct 24 15:13:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 177534 Delivered-To: patch@linaro.org Received: by 2002:a92:409a:0:0:0:0:0 with SMTP id d26csp2331047ill; Thu, 24 Oct 2019 08:15:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqx7WnVZaR3U7b+l9dCY5uHR+ZyMmpQKnjwXz2W0o7/D9f5YT6wLawf1bLUSEHSYrnn7HU5d X-Received: by 2002:a17:906:f2d4:: with SMTP id gz20mr4269424ejb.215.1571930144427; Thu, 24 Oct 2019 08:15:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571930144; cv=none; d=google.com; s=arc-20160816; b=l0nLwhjmyeSnSKMMtCqJbpYCHGssUHw2gtL4kFfGwI537bor6iNGG92LAZzt7Fb631 btLsYNN/et9vIm7ZANZl56zCiHhzKsEZTu/nFWztVS3aX3aVVtTyGJf90Rn31gbGLABW GkPcoEhvelkxtAgn6EYX4xKN9NvM9fpjiWMM/Xfc2CfRBC+g74GLmhcIoprGr2mklNbj uShEKZUeQwQ4o+PfN5zmrvBR98n4/f9TOSbHAVS3II0IhmucNXG5uGQRxSg0P3dXx/Aw giehBZwUR4zPOVMWcT2EkpRJJWgKmgGUJMe2FISjVL+sM2WSNGndHOjGNkN+x3kEwQEM 5ksQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=+iIRtubR+3wcJynWU+Kes2QJp/E/y+xxgrhDiusBOkw=; b=StH9LrXFpaE3x5xzB+ijMP+Vq3JcaF7Eh1VyE3aqlpEh2kJQYi1xpuax+K0hON8Zks 3GjzGFcAcsvJVaYDdsfRhc6yekJdLRWdmVJgitTImrHLYcDruIhvVnmwbHmJFh2IvWrQ pg3hAGX9WopDlJ1fc7oaGbuZ53kkLhdzVKGe7lAQpCPEg0sE1wrlMpEWcWwUdJG2lS7r k0D2ec5zFjAp9kPdssTpXcznv5ni0WX1VbooSwnWR2mw63Jc5eksziiTZuXE3e3DcYZF DhjLH5Odq07j71NrHjLKg/Xdhwxe7RvCSqa+Jcv8IPI7v72LpL/I5mJW6ihPF1S7pGBq QvxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KhtIu0dC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gz25si7153350ejb.81.2019.10.24.08.15.44; Thu, 24 Oct 2019 08:15:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KhtIu0dC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2409679AbfJXPPj (ORCPT + 26 others); Thu, 24 Oct 2019 11:15:39 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:45796 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2409599AbfJXPPj (ORCPT ); Thu, 24 Oct 2019 11:15:39 -0400 Received: by mail-qk1-f195.google.com with SMTP id q70so16190183qke.12 for ; Thu, 24 Oct 2019 08:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+iIRtubR+3wcJynWU+Kes2QJp/E/y+xxgrhDiusBOkw=; b=KhtIu0dCBCIld0cRA5SUcUS0KOYjEc4cfXPg8KYjHxlBNZegNKIW0LE1dFWTzdCJXh XUQXG5Zc6ePCGNVe7v+Y7NRdYoXFxV8EinQmz7Z4e3MQPPmeDGTHMpOLD8gDxqYKn22I 8hMZF9W4N4Dz6VQ48+unWncjtlnk+ljhv817Cs5eAP/8XOa7uUc3iPIyKfQ6XIfcnK/g HbBn+S0oxLTyyEsLnnmGIkyOom6kq3bS9L/dzVAZ3LvkNtMAa4fJzxcyKT+LZzu5o33I c6w4nBBsi08CAsqiaATFlWr5WDDf7fTODch3cCyRefSwjhMB6Onh+6g9Q1mDeqQVl+mK vbCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+iIRtubR+3wcJynWU+Kes2QJp/E/y+xxgrhDiusBOkw=; b=WqFK9nxnAVN+KN65L9fgr05mj1cpr9iManB3Y1eFGNP1xaUX4rF9tVQ71ycfbLbLr0 XaTLCp8xAo4q0vzrA2z4B4JM1L5WJcOF367J9LhKS4Gnk9vvrryhMBo3JuisPdFwNAnf sl5QqCSTay6nj/BNuKrtOLDYwN2kUV6RYwxBWQfsMZaLXbgPFwIw49zBzhtNeZKfTIF3 tT8FveeF2o2KebZCWGb7Sie2SFCMv/OIF4UMFMk9WCO5AoNcHsEPUTGT7QBTg9+o9f4P OcwoaAVD2juTAEGei+b0KvXVW2x1ddQS9+tC4Y67J5V6nko3zfR1sU2yb/NhplElsp76 Q08w== X-Gm-Message-State: APjAAAU1gMB+NRQj7O3AMuLZhzWLiD/Ja09u6iVmJ2Icu7RBKQwVsuXf altoFCl7Bdb7/x/cq0RUxrb4Tw== X-Received: by 2002:a37:e50f:: with SMTP id e15mr14378854qkg.192.1571930138163; Thu, 24 Oct 2019 08:15:38 -0700 (PDT) Received: from localhost.localdomain (li937-157.members.linode.com. [45.56.119.157]) by smtp.gmail.com with ESMTPSA id l5sm4346073qtj.52.2019.10.24.08.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2019 08:15:37 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Mathieu Poirier , Suzuki K Poulose , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Coresight ML , Robert Walker Cc: Leo Yan Subject: [PATCH v1 4/4] perf cs-etm: Fix unsigned variable comparison to zero Date: Thu, 24 Oct 2019 23:13:25 +0800 Message-Id: <20191024151325.28623-5-leo.yan@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191024151325.28623-1-leo.yan@linaro.org> References: <20191024151325.28623-1-leo.yan@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The variable 'offset' in function cs_etm__sample() is u64 type, it's not appropriate to check it with 'while (offset > 0)'; this patch changes to 'while (offset)'. Signed-off-by: Leo Yan --- tools/perf/util/cs-etm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index d9a857abaca8..52fe7d6d4f29 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -945,7 +945,7 @@ static inline u64 cs_etm__instr_addr(struct cs_etm_queue *etmq, if (packet->isa == CS_ETM_ISA_T32) { u64 addr = packet->start_addr; - while (offset > 0) { + while (offset) { addr += cs_etm__t32_instr_size(etmq, trace_chan_id, addr); offset--;