From patchwork Wed Oct 16 15:59:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 176501 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp7571932ill; Wed, 16 Oct 2019 09:00:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqwd6ml6awGfJkfyrQyBAtRhUzZ97++yWAFb8afLF9fNtJSTPmkm0a1NgWBa/6QmZr0NuCW+ X-Received: by 2002:a50:9fe7:: with SMTP id c94mr39870864edf.249.1571241646074; Wed, 16 Oct 2019 09:00:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571241646; cv=none; d=google.com; s=arc-20160816; b=GDGS8p9QtOGioGrWuIm3ydHhGDtzrjPwg2FeSxWFZNHrPoeGhIZR2gMthZk4IEtq1x xHZ9MWiJngiyNLMCsFZv4TTQ+XPBjDA0+YSM1FBW5OrJ0Ykvksl3EPvN0src0vgqCuOS LhD365rTyjTxDxEtQ/q9aFCs7X33/OtUWrVTqjuWMyUupTpaQkRZb1MecHIETUN6TdLv Hu6Q4Cf2k23Q2FpMg7izo3jqxjIJWOvToClu2wGBlWCatnpEaC2uUmlMacNFY+xu16GJ YSUqxv3HhlYSziSVqbgUl6xIABeNWtfyq17w8ACPF7fIiJ0rNT0uHaqPyVv2iN/YNtt1 l6+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wHXGHHJ25tMpF7O5x06wBMDKLgua8GjQCGp5U2Al03w=; b=OjhJ89XDJSX3yX+s3F9Kh5rBa1zw4eitrjfnOMLFp1Kd37BvkdOkVyGR7OQ+97MUXz 8EKZgywiJBVy6vLYMN/9G4M+FlC0C7dpIMNeKLLGXIbx5BiKtO2qmpa+neRQUkZMuAd3 glugX7p1biqykdxENCDp8Lg6DI9OMcymD8g7NBTd/oGmcQDxGjdcAD3joOb67omiB/+Y NYPeIm0U+gWkJx4Juoy/9Zt9ywhmu2E/pmsa4czfille3Wp3AS15NCDTmOVLOSrMINd0 xUh6DYNUVC7pLyiIL2OMSYtwcuQuUuvZfbr4ymHGgVHB6CZFEt0pNA5ArV+fkahWS32G hLxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="JmZJEe4/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r3si15697757ejs.439.2019.10.16.09.00.45; Wed, 16 Oct 2019 09:00:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="JmZJEe4/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405998AbfJPQAp (ORCPT + 26 others); Wed, 16 Oct 2019 12:00:45 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:55620 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393164AbfJPQAf (ORCPT ); Wed, 16 Oct 2019 12:00:35 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x9GG0WK5039227; Wed, 16 Oct 2019 11:00:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1571241632; bh=wHXGHHJ25tMpF7O5x06wBMDKLgua8GjQCGp5U2Al03w=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=JmZJEe4/hrIY/T0KnTOrs5IwyOuETdJ+tn/Bf6bABuwgUIxlzxXItdhNs6r7BzHOa ml0ktD33ekrqxuf6ypREfW9oM1wu6Wo/u77lQQ9KeFaoEWLw3BFRFPxbusz+I7vFNZ kg+ZvVnTArp5QfqhLRmIBtv3bmWT2xqcsWwLCVNA= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x9GG0Whw094856 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 16 Oct 2019 11:00:32 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 16 Oct 2019 11:00:32 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 16 Oct 2019 11:00:32 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x9GG0VJJ043152; Wed, 16 Oct 2019 11:00:32 -0500 From: Dan Murphy To: , CC: , , Dan Murphy Subject: [PATCH v13 16/18] leds: lp55xx: Fix checkpatch file permissions issues Date: Wed, 16 Oct 2019 10:59:52 -0500 Message-ID: <20191016155954.29044-17-dmurphy@ti.com> X-Mailer: git-send-email 2.22.0.214.g8dca754b1e In-Reply-To: <20191016155954.29044-1-dmurphy@ti.com> References: <20191016155954.29044-1-dmurphy@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the checkpatch warnings for the use of the file permission macros. In converting the file permissions to the DEVICE_ATTR_XX macros the call back function names needed to be updated within the code. This means that the lp55xx_ needed to be dropped in the name to keep in harmony with the ABI documentation. Signed-off-by: Dan Murphy --- drivers/leds/leds-lp55xx-common.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) -- 2.22.0.214.g8dca754b1e diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c index 026ebc2f8e18..a1d930d4f461 100644 --- a/drivers/leds/leds-lp55xx-common.c +++ b/drivers/leds/leds-lp55xx-common.c @@ -78,7 +78,7 @@ static int lp55xx_post_init_device(struct lp55xx_chip *chip) return cfg->post_init_device(chip); } -static ssize_t lp55xx_show_current(struct device *dev, +static ssize_t led_current_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -87,7 +87,7 @@ static ssize_t lp55xx_show_current(struct device *dev, return scnprintf(buf, PAGE_SIZE, "%d\n", led->led_current); } -static ssize_t lp55xx_store_current(struct device *dev, +static ssize_t led_current_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) { @@ -111,7 +111,7 @@ static ssize_t lp55xx_store_current(struct device *dev, return len; } -static ssize_t lp55xx_show_max_current(struct device *dev, +static ssize_t max_current_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -120,9 +120,8 @@ static ssize_t lp55xx_show_max_current(struct device *dev, return scnprintf(buf, PAGE_SIZE, "%d\n", led->max_current); } -static DEVICE_ATTR(led_current, S_IRUGO | S_IWUSR, lp55xx_show_current, - lp55xx_store_current); -static DEVICE_ATTR(max_current, S_IRUGO , lp55xx_show_max_current, NULL); +static DEVICE_ATTR_RW(led_current); +static DEVICE_ATTR_RO(max_current); static struct attribute *lp55xx_led_attrs[] = { &dev_attr_led_current.attr, @@ -282,7 +281,7 @@ static int lp55xx_request_firmware(struct lp55xx_chip *chip) GFP_KERNEL, chip, lp55xx_firmware_loaded); } -static ssize_t lp55xx_show_engine_select(struct device *dev, +static ssize_t select_engine_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -292,7 +291,7 @@ static ssize_t lp55xx_show_engine_select(struct device *dev, return sprintf(buf, "%d\n", chip->engine_idx); } -static ssize_t lp55xx_store_engine_select(struct device *dev, +static ssize_t select_engine_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) { @@ -334,7 +333,7 @@ static inline void lp55xx_run_engine(struct lp55xx_chip *chip, bool start) chip->cfg->run_engine(chip, start); } -static ssize_t lp55xx_store_engine_run(struct device *dev, +static ssize_t run_engine_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) { @@ -359,9 +358,8 @@ static ssize_t lp55xx_store_engine_run(struct device *dev, return len; } -static DEVICE_ATTR(select_engine, S_IRUGO | S_IWUSR, - lp55xx_show_engine_select, lp55xx_store_engine_select); -static DEVICE_ATTR(run_engine, S_IWUSR, NULL, lp55xx_store_engine_run); +static DEVICE_ATTR_RW(select_engine); +static DEVICE_ATTR_WO(run_engine); static struct attribute *lp55xx_engine_attributes[] = { &dev_attr_select_engine.attr,