From patchwork Thu Oct 10 08:35:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 175713 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp1975985ill; Thu, 10 Oct 2019 01:40:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqwTDv243JnonJW1b8T/PGqTFQYvjY4oFF1M5O+SkUa0bVLLZTD/DzhiVwoyLrcqYucfxg3/ X-Received: by 2002:a05:6402:64f:: with SMTP id u15mr6817908edx.231.1570696830716; Thu, 10 Oct 2019 01:40:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570696830; cv=none; d=google.com; s=arc-20160816; b=By1guxeA88/D1vL8C6KdkZ8SVpSQUDa6VQM19/y8T/S8Jy8P8Z1oX4Gei2/EOWKAj5 c/ReTIPfPzFdtHenXYYYi5T4LbBKsHByS8c/YOcjb1/2bNsJgzN/EbqfqgM2czMkCd4B T9rJF50PXM63aMSDCvh7mYF5eWC/S9WwIX2Kdm5BsVZn0sZ4tqeX3u9bMlNCuScKD8Do AZ9O2SzSfFVyf2AtAayDyaOGWs2Uf0SiIVI2alWXHG0HDj/MG2R8OGkKyhoFgcXBbrvL pMHUGRdpDVWkfybaoUyAGoTR6t5QvNF9Ai1K34pYg1Bj/MQOcZQwMGu9Nz07Kb7z9YQR l8vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Z1Uo4cB9yOSynznXlmaxJHonESqz8I5Vaw6TZHLVr5I=; b=wV9O+xHXPx/EVgAS+kty3qx38f+W9mm0YQrzfzzEIuoURduewHa3XXyCJSfqTXJoxK 1NrLIo1xD1mqGvGrm1yiVnukA1nWSztuW7qie7NiS6wAvJGThfXXsrySyGwfe6E9X4BS tKrmNZld7THp1EA0hY2UuX/uqIDsh8akJSOdNEqmT1yPdecnYnAkz55P0Z/MB2kG8TcF tMYD22oeKiNv571GotNT5xJUUTRZuQ/DHG0X3rKoGaYZvIZoCJ1ceyESC+JkGJA+z8kc W+M3rWg9jnmv7UoP7wIu5udaLPjVaSvd+AGgQR8CFWvsihEhX54MdN+OBr3YTGWZn+gR t4Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=J1ELj8v9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n19si2809317edo.172.2019.10.10.01.40.30; Thu, 10 Oct 2019 01:40:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=J1ELj8v9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388119AbfJJIk3 (ORCPT + 26 others); Thu, 10 Oct 2019 04:40:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:44560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387493AbfJJIk1 (ORCPT ); Thu, 10 Oct 2019 04:40:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF46720B7C; Thu, 10 Oct 2019 08:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570696827; bh=IzsSl5RJoQIY9CfSt/mZ/FS85qR1vAUixNJ0vwRnrxQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J1ELj8v9FSHeC3uVqe0Wu8D4u5Z5vB7GL9gS6mlOzNBdwQj6J69EIvmDfP3viMp03 BrgJw9UVh/4GDddPVjAhj5JdEpiMfUjR0s0lhdsCpJN8puej99Alm5VSURjkCbhO3t Li/D972vwPPPbM2K6Qg0YwR1GwY7hd7quUXFORiI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomi Valkeinen , Adam Ford , Jyri Sarha Subject: [PATCH 5.3 066/148] drm/omap: fix max fclk divider for omap36xx Date: Thu, 10 Oct 2019 10:35:27 +0200 Message-Id: <20191010083615.450362990@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191010083609.660878383@linuxfoundation.org> References: <20191010083609.660878383@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tomi Valkeinen commit e2c4ed148cf3ec8669a1d90dc66966028e5fad70 upstream. The OMAP36xx and AM/DM37x TRMs say that the maximum divider for DSS fclk (in CM_CLKSEL_DSS) is 32. Experimentation shows that this is not correct, and using divider of 32 breaks DSS with a flood or underflows and sync losts. Dividers up to 31 seem to work fine. There is another patch to the DT files to limit the divider correctly, but as the DSS driver also needs to know the maximum divider to be able to iteratively find good rates, we also need to do the fix in the DSS driver. Signed-off-by: Tomi Valkeinen Cc: Adam Ford Cc: stable@vger.kernel.org Link: https://patchwork.freedesktop.org/patch/msgid/20191002122542.8449-1-tomi.valkeinen@ti.com Tested-by: Adam Ford Reviewed-by: Jyri Sarha Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/omapdrm/dss/dss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/omapdrm/dss/dss.c +++ b/drivers/gpu/drm/omapdrm/dss/dss.c @@ -1090,7 +1090,7 @@ static const struct dss_features omap34x static const struct dss_features omap3630_dss_feats = { .model = DSS_MODEL_OMAP3, - .fck_div_max = 32, + .fck_div_max = 31, .fck_freq_max = 173000000, .dss_fck_multiplier = 1, .parent_clk_name = "dpll4_ck",