From patchwork Thu Oct 10 08:35:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 175717 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp1981366ill; Thu, 10 Oct 2019 01:46:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxFSkXk1UZTvlRwKfja7OIkiuZyEAhwVFCRbXvCZXEm4cE8xSiMF1IVZ+Alnp8Sz+8xdEMT X-Received: by 2002:a50:b966:: with SMTP id m93mr6968334ede.228.1570697175751; Thu, 10 Oct 2019 01:46:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570697175; cv=none; d=google.com; s=arc-20160816; b=DzRNsEhwb/0nwfJKAhf7ffQnAf44p+chKUq1/qtszWGuC5m+f5dcJSXTimPZZSdBaZ nJVVR5nJwe/+xZeTR1BqL6tGN6hFVXLjFnOXr6k7+PBo54/yEn/a/5YWaXvnkWAtwkx/ ErMEAZQR5xDd59s41/kJVtSpUGK/++TxM9sJXvg/c9RC9GD91MhQpIYy5gE6f1vaqgxX I7TT9RBpeyunyJsfRaZZN596ICh0Tl64W2i16xL4DZjqWLuPypexSlM3Ow8q2wZ/CrfR IdGnplk3uFuElp61lIMOVURw9f2S8wJkTvMKB0SBsB1A0SF2bgjWP0WhOVHUODa17QAg zF7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=luBUIeew/WB9kyCOdRGlIl0vk6kCemCKhZEPfFyusrU=; b=1CIkrB5hxkl0G5IxXo2nNG654mvKuZ1kM7Kb4R5sJ+rfxaceQE/t1NV9DHRxL5odO8 4UB9DhiRjGtu1oXqdSLdFciNSNBMjL9q7kWaJSSZI1eYC4CzoVwVfY/UvJQKTdDpXqLm GI8TYuQ/68zpr6QnVnuY1iDAruGhurLkfGq9tjxwhsT0aBk6hlyuYavMDT7/NKJUs2i8 g28oJWCnV7eE5qv7KLY8+IHbj2fWYbKDpHPSpSJGmMMg7ey/5OECd/2AT4CzjwY+gsE2 xfIsYgrfbgIje89CqJjjZ0IB5IWfyV2sGAxnzmWw8lyePJnSX3/S8BcdxYVJ4ieZQ80I hnaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=B+72YhTu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c14si3536951eda.8.2019.10.10.01.46.15; Thu, 10 Oct 2019 01:46:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=B+72YhTu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389295AbfJJIqP (ORCPT + 26 others); Thu, 10 Oct 2019 04:46:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:51980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389269AbfJJIqM (ORCPT ); Thu, 10 Oct 2019 04:46:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C0384208C3; Thu, 10 Oct 2019 08:46:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570697171; bh=ULwYx4Q1NCG16srlI3fJS7zmEXdK3GkZILdEY+2LNlY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B+72YhTuXkOp0DgnemKSAuUU3HRntgcmL0y9by+U3Nd5505MZXOXsiWrBzbOV4VV8 Ayr/K2JZTqb9I5U0sv5xmoCUgRb4+6BPkK5DaqUgcG7VJ9eF3q9br6eFJjLnyoT88S kxWOey4vGY8x61OV1gM+dmBR/pa8ctuKDHduOwgs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomi Valkeinen , Adam Ford , Jyri Sarha Subject: [PATCH 4.19 037/114] drm/omap: fix max fclk divider for omap36xx Date: Thu, 10 Oct 2019 10:35:44 +0200 Message-Id: <20191010083603.611123885@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191010083544.711104709@linuxfoundation.org> References: <20191010083544.711104709@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tomi Valkeinen commit e2c4ed148cf3ec8669a1d90dc66966028e5fad70 upstream. The OMAP36xx and AM/DM37x TRMs say that the maximum divider for DSS fclk (in CM_CLKSEL_DSS) is 32. Experimentation shows that this is not correct, and using divider of 32 breaks DSS with a flood or underflows and sync losts. Dividers up to 31 seem to work fine. There is another patch to the DT files to limit the divider correctly, but as the DSS driver also needs to know the maximum divider to be able to iteratively find good rates, we also need to do the fix in the DSS driver. Signed-off-by: Tomi Valkeinen Cc: Adam Ford Cc: stable@vger.kernel.org Link: https://patchwork.freedesktop.org/patch/msgid/20191002122542.8449-1-tomi.valkeinen@ti.com Tested-by: Adam Ford Reviewed-by: Jyri Sarha Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/omapdrm/dss/dss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/omapdrm/dss/dss.c +++ b/drivers/gpu/drm/omapdrm/dss/dss.c @@ -1110,7 +1110,7 @@ static const struct dss_features omap34x static const struct dss_features omap3630_dss_feats = { .model = DSS_MODEL_OMAP3, - .fck_div_max = 32, + .fck_div_max = 31, .fck_freq_max = 173000000, .dss_fck_multiplier = 1, .parent_clk_name = "dpll4_ck",