From patchwork Thu Oct 3 10:29:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 175070 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp108862ill; Thu, 3 Oct 2019 03:30:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqxdkw1eR82FM/sZzbGdhR0pE2Eu37ChlYPL+XzxndJKg85EB5kTCK/EwvHh9KAb7H3yD8ux X-Received: by 2002:a50:8a9a:: with SMTP id j26mr8694454edj.251.1570098605549; Thu, 03 Oct 2019 03:30:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570098605; cv=none; d=google.com; s=arc-20160816; b=XBfzK+42l1GN6SD9B9irps0xqKfS6szO9cCYu4gmoR86NQVwDNHP11cSbPrhWMA8pS S+2YZJnw/0JTcGxFy4vgRGAP6g7k8mNE99rzMmY7Iv5uN8Uyog9VV/vlZIUEKXqiQzS5 bPXINNRuTtgoPxOToNJShGkRO7P5lvf36HIi6ITik3fPwkz5aZItFdhgJbvO9o7D1a7d kOOZu45o8kF0sbxZCHwFvV2hwNVASkexkQepYl2i77hCTHNI1Bg8NsmRPiDY0OmSU+8o U79IZ1rvHCiUQuE++uixQjV0JBx7t7f0Ood5pE+liMq4Y5X92MTnsSp0xZUezHUWGkRp np1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=97NLJz+Obv3dJt7wwiAspNiro8fFokgiiEuk+kW1mrM=; b=har9BhZQiv8lCkTr8WXAhmCVsh6NHGx01QHDio3Smf8OSbkcat0DvC8hxXYBdetLrr LS03O8VBKDseNBaiu4dIl0eA/aemZarWtLZDLsLLGZgoQHWN5zefW0nnPLud+xVqngbd nrsAONbjtxy8354/zb2gUQaEwWaV6VJ7TmXpG9kyv6gxJLALasbLeiBlu8gSsjrFRVlG 43X3gVj8NqY9AozLhH9c5ZpDly+ql97K6cg0tC3STtzQ8ic1CXOH2fc7W3ZKpO1Cfj+F 77vxacvptic4QLmDDmt5Px7ZqEffDNIILil2GKmKR28aXJw6/zA+f1sUM+/F2Wuy2/BS DLaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=dxL2Hgd7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o17si956261ejm.261.2019.10.03.03.30.05; Thu, 03 Oct 2019 03:30:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=dxL2Hgd7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728608AbfJCKaB (ORCPT + 27 others); Thu, 3 Oct 2019 06:30:01 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:49077 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727368AbfJCKaB (ORCPT ); Thu, 3 Oct 2019 06:30:01 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-10.nifty.com with ESMTP id x93ATIYx014338; Thu, 3 Oct 2019 19:29:21 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com x93ATIYx014338 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1570098561; bh=97NLJz+Obv3dJt7wwiAspNiro8fFokgiiEuk+kW1mrM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dxL2Hgd7ThRlxe/hAyXRFVAIYJ7pIzTmj07XGOoFExkh7GsWFYfB1wqczggmwEWwy qnn4C8CgaUrtwnFspwyaj9jvMlZkfB2ocMhSQPdctSHENydAQ/R3q8uCmoECR4eRcP CIhcDNel3A8N6ngxz9pa/z4HLLm/uVUKE10iL5V4FWdU3HnVCSYAhhFoQzXbR7UZTa FXTvrKcekNT98MvNve0hrlBnSqCQ2PPbjQGuPIXkChdzLhjDQ4VzsZBoYdOWPtZyPM vcqYKF+eQyzuj6L2G8DhVQXev7LI2D2mOCH0Zglx8cdU/g9n2Js1gqz74zWV8KL5qS YrZv51rQxHpag== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Sam Ravnborg , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH 4/4] modpost: do not set ->preloaded for symbols from Module.symvers Date: Thu, 3 Oct 2019 19:29:15 +0900 Message-Id: <20191003102915.28301-4-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191003102915.28301-1-yamada.masahiro@socionext.com> References: <20191003102915.28301-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that there is no overwrap between symbols from ELF files and ones from Module.symvers. So, the 'exported twice' warning should be reported irrespective of where the symbol in question came from. Only the exceptional case is when __crc_ symbol appears before __ksymtab_. This typically occurs for EXPORT_SYMBOL in .S files. Signed-off-by: Masahiro Yamada --- scripts/mod/modpost.c | 1 - 1 file changed, 1 deletion(-) -- 2.17.1 diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 5234555cf550..6ca38d10efc5 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -2457,7 +2457,6 @@ static void read_dump(const char *fname, unsigned int kernel) s = sym_add_exported(symname, namespace, mod, export_no(export)); s->kernel = kernel; - s->preloaded = 1; s->is_static = 0; sym_update_crc(symname, mod, crc, export_no(export)); }