From patchwork Wed Oct 2 18:22:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 175039 Delivered-To: patches@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp1116978ill; Wed, 2 Oct 2019 11:23:05 -0700 (PDT) X-Received: by 2002:a17:902:bcc7:: with SMTP id o7mr5273181pls.171.1570040585739; Wed, 02 Oct 2019 11:23:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570040585; cv=none; d=google.com; s=arc-20160816; b=GUgVpvaiZaIGVTBZY0fXBUmTEkAExERoyZX7yH6L3JDwwkwimkLbIFb247lek8QYKb eDh8vEWDKNE0JJKew1r03aM+gBaWePAA0gt+OL1H3cOHHfHkNDzBPEABht52MOJKWlEZ 66NikeVWNj3cZEmxPb3TLPInEvL7haZQQF2jfopNC/pgA6DslX9VhIVRyHb3VVTyP6bD LE+sgz7WihULXrjaynm9kJdxFiM3NHUGtkeQByFGPBUTyWQpvhGXr44Ep+uFEGfiwf8P BzIGX3QyvLgxsxMrh0SJYoLGbu8Gsz6BiNQexmS+oCMw6s72n7057MQRTSQDZuN1Qmsm 4wOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=L5R3biPdyAP9SaGtuBYtfAqnPopkM7CqJ0+mZu09PC0=; b=FURXMNSKKdHGMqmm3nGUIiowxda5Ea9SeykqpvtkR8KBjf10QXhw6G0UbLFd1+JGQU 5RbViVAnS3Hw8wpN4Fgcz5lxOM1abvvQPKM/APP+IGNe3NCyUE3x7u/tQJBdv41dsXD/ N2rTjBs6OgOePpq2TShs7Z/TSNvk7+2o1iBdw1DclyZxJOivzLvAFrwQg4VEWL9iZ6sa UE7QBNv95hY+6CRN/SYqKCvWNTfa65kjqUicXTzt3BVzzJDBe4Y8okBbJnxH/wuhY4mJ Z7MqO98Kruvu0NxxlNoyU15yji1onQkChXN6nKjyAlxQCAYOYesLshV012tV1y9AQe84 Y8lA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="IaE/zUdH"; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id c11sor18694968pgh.81.2019.10.02.11.23.05 for (Google Transport Security); Wed, 02 Oct 2019 11:23:05 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="IaE/zUdH"; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=L5R3biPdyAP9SaGtuBYtfAqnPopkM7CqJ0+mZu09PC0=; b=IaE/zUdHdIo/924br8atdSxhzarM7+mjalAs5oZqMyqz03hjNh0mnSr48HWArFP8tA +7IkFWM1JhpGW117d5O+PXCznqskC1VKGkUYv4xMaXhohdcylUudtMtuTRfcY1wvRtlH gYSdsqjH+y4TSiWIG4HAxCinYlHLbvhovQPRgcieqP6zBahQ5ppBdO2e8swJaOuehBzu Vc9QKw1VsNleH3/LC9tVoRlyZzJraYJ5/U0ybeAmjOeLLnnINqFegAzqKtj8p2YVa3fr LUf214wTk0ZDDuAJax1f8FWJ02U+bP624NNymkgY5m7CK0clECm8J+z9rvZCAR6ggQLl NoyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=L5R3biPdyAP9SaGtuBYtfAqnPopkM7CqJ0+mZu09PC0=; b=KGgDWLWOel776lJGiC2x/TBahyK5UsVCIxG9xEl2iTuRhOvJ/g6mSu7Os1tHyP6MFI UlxdO18+YX+BsOIwOTOBEP+znKbHcw1Bj9b3ONkDSemD69vp/H2+MEj63OJbqqs29xAT 0y9MWabNPbUE865l5tAcYg0mqVIsR9L+OJc0/EGzghVeAsDvjJaJeURsNJ5kJJMuQ/f9 twVZMXyLBZvZqeX32a9SJbsX+kTWLeuEdpNpm3C4ATeaoodhUT/115DEQCXvij5C8zcc TANVYqmj/+rvLFk0WIEKrwtrB/QA9IYcdKmVcqi9gVaEgttzZnMo93Trg8cz7uEh6XmC 4XSg== X-Gm-Message-State: APjAAAXFgds8fwQFA6gbhJ0mFMibyKND7sxZgbZM9/dy0cXc1DG9dWR4 ow+ySDxfx7FVfVpdYukcJNOHvQA2 X-Google-Smtp-Source: APXvYqyzoiTFTlt7K4Iw04Kaayl0fclEtP0a0rcYP27H7eynY9gU3mbkmfn+fDUi/ex3RSxAf0K5wA== X-Received: by 2002:a63:6d46:: with SMTP id i67mr5086282pgc.285.1570040585176; Wed, 02 Oct 2019 11:23:05 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id q132sm171102pfq.16.2019.10.02.11.23.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2019 11:23:04 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Laura Abbott , Benjamin Gaignard , Sumit Semwal , Liam Mark , Pratik Patel , Brian Starkey , Vincent Donnefort , Sudipto Paul , "Andrew F . Davis" , Christoph Hellwig , Chenbo Feng , Alistair Strachan , Hridya Valsaraju , Hillf Danton , dri-devel@lists.freedesktop.org Subject: [PATCH v9 3/5] dma-buf: heaps: Add system heap to dmabuf heaps Date: Wed, 2 Oct 2019 18:22:53 +0000 Message-Id: <20191002182255.21808-4-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191002182255.21808-1-john.stultz@linaro.org> References: <20191002182255.21808-1-john.stultz@linaro.org> This patch adds system heap to the dma-buf heaps framework. This allows applications to get a page-allocator backed dma-buf for non-contiguous memory. This code is an evolution of the Android ION implementation, so thanks to its original authors and maintainters: Rebecca Schultz Zavin, Colin Cross, Laura Abbott, and others! Cc: Laura Abbott Cc: Benjamin Gaignard Cc: Sumit Semwal Cc: Liam Mark Cc: Pratik Patel Cc: Brian Starkey Cc: Vincent Donnefort Cc: Sudipto Paul Cc: Andrew F. Davis Cc: Christoph Hellwig Cc: Chenbo Feng Cc: Alistair Strachan Cc: Hridya Valsaraju Cc: Hillf Danton Cc: dri-devel@lists.freedesktop.org Reviewed-by: Benjamin Gaignard Reviewed-by: Brian Starkey Acked-by: Laura Abbott Tested-by: Ayan Kumar Halder Signed-off-by: John Stultz --- v2: * Switch allocate to return dmabuf fd * Simplify init code * Checkpatch fixups * Droped dead system-contig code v3: * Whitespace fixups from Benjamin * Make sure we're zeroing the allocated pages (from Liam) * Use PAGE_ALIGN() consistently (suggested by Brian) * Fold in new registration style from Andrew * Avoid needless dynamic allocation of sys_heap (suggested by Christoph) * Minor cleanups * Folded in changes from Andrew to use simplified page list from the heap helpers v4: * Optimization to allocate pages in chunks, similar to old pagepool code * Use fd_flags when creating dmabuf fd (Suggested by Benjamin) v5: * Back out large order page allocations (was leaking memory, as the page array didn't properly track order size) v6: * Minor whitespace change suggested by Brian * Remove unused variable v7: * Use newly lower-cased init_heap_helper_buffer helper * Add system heap DOS avoidance suggested by Laura from ION code * Use new dmabuf export helper v8: * Make struct dma_heap_ops consts (suggested by Christoph) * Get rid of needless struct system_heap (suggested by Christoph) * Condense dma_heap_buffer and heap_helper_buffer (suggested by Christoph) * Add forgotten include file to fix build issue on x86 --- drivers/dma-buf/Kconfig | 2 + drivers/dma-buf/heaps/Kconfig | 6 ++ drivers/dma-buf/heaps/Makefile | 1 + drivers/dma-buf/heaps/system_heap.c | 122 ++++++++++++++++++++++++++++ 4 files changed, 131 insertions(+) create mode 100644 drivers/dma-buf/heaps/Kconfig create mode 100644 drivers/dma-buf/heaps/system_heap.c -- 2.17.1 diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig index 6e9c7c4d7447..245b3b4ff69e 100644 --- a/drivers/dma-buf/Kconfig +++ b/drivers/dma-buf/Kconfig @@ -53,4 +53,6 @@ menuconfig DMABUF_HEAPS allows userspace to use to allocate dma-bufs that can be shared between drivers. +source "drivers/dma-buf/heaps/Kconfig" + endmenu diff --git a/drivers/dma-buf/heaps/Kconfig b/drivers/dma-buf/heaps/Kconfig new file mode 100644 index 000000000000..205052744169 --- /dev/null +++ b/drivers/dma-buf/heaps/Kconfig @@ -0,0 +1,6 @@ +config DMABUF_HEAPS_SYSTEM + bool "DMA-BUF System Heap" + depends on DMABUF_HEAPS + help + Choose this option to enable the system dmabuf heap. The system heap + is backed by pages from the buddy allocator. If in doubt, say Y. diff --git a/drivers/dma-buf/heaps/Makefile b/drivers/dma-buf/heaps/Makefile index de49898112db..d1808eca2581 100644 --- a/drivers/dma-buf/heaps/Makefile +++ b/drivers/dma-buf/heaps/Makefile @@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0 obj-y += heap-helpers.o +obj-$(CONFIG_DMABUF_HEAPS_SYSTEM) += system_heap.o diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c new file mode 100644 index 000000000000..5db4ef9b4afc --- /dev/null +++ b/drivers/dma-buf/heaps/system_heap.c @@ -0,0 +1,122 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * DMABUF System heap exporter + * + * Copyright (C) 2011 Google, Inc. + * Copyright (C) 2019 Linaro Ltd. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "heap-helpers.h" + +struct dma_heap *sys_heap; + +static void system_heap_free(struct heap_helper_buffer *buffer) +{ + pgoff_t pg; + + for (pg = 0; pg < buffer->pagecount; pg++) + __free_page(buffer->pages[pg]); + kfree(buffer->pages); + kfree(buffer); +} + +static int system_heap_allocate(struct dma_heap *heap, + unsigned long len, + unsigned long fd_flags, + unsigned long heap_flags) +{ + struct heap_helper_buffer *helper_buffer; + struct dma_buf *dmabuf; + int ret = -ENOMEM; + pgoff_t pg; + + helper_buffer = kzalloc(sizeof(*helper_buffer), GFP_KERNEL); + if (!helper_buffer) + return -ENOMEM; + + init_heap_helper_buffer(helper_buffer, system_heap_free); + helper_buffer->flags = heap_flags; + helper_buffer->heap = heap; + helper_buffer->size = len; + + helper_buffer->pagecount = len / PAGE_SIZE; + helper_buffer->pages = kmalloc_array(helper_buffer->pagecount, + sizeof(*helper_buffer->pages), + GFP_KERNEL); + if (!helper_buffer->pages) { + ret = -ENOMEM; + goto err0; + } + + for (pg = 0; pg < helper_buffer->pagecount; pg++) { + /* + * Avoid trying to allocate memory if the process + * has been killed by by SIGKILL + */ + if (fatal_signal_pending(current)) + goto err1; + + helper_buffer->pages[pg] = alloc_page(GFP_KERNEL | __GFP_ZERO); + if (!helper_buffer->pages[pg]) + goto err1; + } + + /* create the dmabuf */ + dmabuf = heap_helper_export_dmabuf(helper_buffer, fd_flags); + if (IS_ERR(dmabuf)) { + ret = PTR_ERR(dmabuf); + goto err1; + } + + helper_buffer->dmabuf = dmabuf; + + ret = dma_buf_fd(dmabuf, fd_flags); + if (ret < 0) { + dma_buf_put(dmabuf); + /* just return, as put will call release and that will free */ + return ret; + } + + return ret; + +err1: + while (pg > 0) + __free_page(helper_buffer->pages[--pg]); + kfree(helper_buffer->pages); +err0: + kfree(helper_buffer); + + return -ENOMEM; +} + +static const struct dma_heap_ops system_heap_ops = { + .allocate = system_heap_allocate, +}; + +static int system_heap_create(void) +{ + struct dma_heap_export_info exp_info; + int ret = 0; + + exp_info.name = "system_heap"; + exp_info.ops = &system_heap_ops; + exp_info.priv = NULL; + + sys_heap = dma_heap_add(&exp_info); + if (IS_ERR(sys_heap)) + ret = PTR_ERR(sys_heap); + + return ret; +} +device_initcall(system_heap_create);