From patchwork Wed Oct 2 12:40:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 174996 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp707407ill; Wed, 2 Oct 2019 05:42:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwZuM1Nu8ccZwl+GA/tf8ZGZ2Mhxx54HRHLWRWQZ7TfLUFxXaHzDXw+pUTKPEMO0iOHapwC X-Received: by 2002:a17:906:839a:: with SMTP id p26mr2803817ejx.94.1570020028461; Wed, 02 Oct 2019 05:40:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570020028; cv=none; d=google.com; s=arc-20160816; b=VVIYGyGQQvWV8bsIznhTiZO/pRR9LLsWxe6Je5mUhqZvqKCY+M7h5/vdscc2/6TrPG g/pWFwZR79lznaGilG7rxsg+ohId2vMHI3Emua+FlOK46SsL0sgppTHkm5kmmpG2Dz38 KlilG0Pz4EIhPUEbes7QDlLlC9jvxdZhL4oKAMLXBx8+sIVrZ0Np+X7s2l/eIYlXUT4K zGBcq3l9swHEcryr+HtAs03wvxSMC6YN05K0ma6UK7mPPZvU6umetQ+J+XUZyCf+1Hrf FdVIbUwEcaA8pPDEd0eWTLpf4qdS4CuMLgkxpzQ2tuoUrzm0c865qxlzUclAQD/J10ge b1QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=GGDOyQL+13uGomQIzn17lPQZjfrmmobRzDF35QsnYtE=; b=qSGQOVYQ2vDdQIKj5mbKMgfhjUUU/E0uFif4aiFtA3m/UGC9IXeDye0+iwerZW3w/o ODxpBXFaCkg3qpogAhjWkwI8bkAuic/zD3HDVztlS3FWBJTpiccpdShIYQjQp4I8Za26 rBnkpc92lIagSoAlisXYN1oalSpYQcpgtC64WT+jesJIPnyi6Lumk7NYzVpePy3hOoX7 ghMRHSMTtAwavulEpiLC4WPyfoYqfVXudxVueuxwca/HDRLMMRsEI+lWCkYi8FJEdzHL 13jZVUm3wAquUr+nLG9zLPT+y0EwSjg7pVw/xw9X1vrri0YNoHgX9d0HYenIQaKn3XY3 gztg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=zPiMketr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u18si10483893ejk.105.2019.10.02.05.40.28; Wed, 02 Oct 2019 05:40:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=zPiMketr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727499AbfJBMkX (ORCPT + 27 others); Wed, 2 Oct 2019 08:40:23 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:54008 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbfJBMkI (ORCPT ); Wed, 2 Oct 2019 08:40:08 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x92Ce43E014737; Wed, 2 Oct 2019 07:40:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1570020004; bh=GGDOyQL+13uGomQIzn17lPQZjfrmmobRzDF35QsnYtE=; h=From:To:CC:Subject:Date; b=zPiMketrYRsyTn91wIRfRfVw1RXCFpSapJbumE7qE0Fn08Id7HLjO6RSOa2LQn3au eTjzCCjjdav4+d8awZJTmXL//OtdZqh+hYTDCyWHa8utXcTG/IjsccF1BwSwSvssUj e7T3fgS5E50VgyJV/V+iRPbCV98h24nkD4qpMzME= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x92Ce3hK009143 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 2 Oct 2019 07:40:04 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 2 Oct 2019 07:39:53 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 2 Oct 2019 07:40:03 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x92Ce3rm055816; Wed, 2 Oct 2019 07:40:03 -0500 From: Dan Murphy To: , CC: , , Dan Murphy Subject: [PATCH v2 1/6] leds: flash: Remove extern from the header file Date: Wed, 2 Oct 2019 07:40:37 -0500 Message-ID: <20191002124042.25593-1-dmurphy@ti.com> X-Mailer: git-send-email 2.22.0.214.g8dca754b1e MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org extern is implied and is not needed in the header file. Remove the extern keyword and re-align the code. Signed-off-by: Dan Murphy --- include/linux/led-class-flash.h | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) -- 2.22.0.214.g8dca754b1e diff --git a/include/linux/led-class-flash.h b/include/linux/led-class-flash.h index 7ff287a9e2a2..1bd83159fa4c 100644 --- a/include/linux/led-class-flash.h +++ b/include/linux/led-class-flash.h @@ -94,12 +94,12 @@ static inline struct led_classdev_flash *lcdev_to_flcdev( * * Returns: 0 on success or negative error value on failure */ -extern int led_classdev_flash_register_ext(struct device *parent, - struct led_classdev_flash *fled_cdev, - struct led_init_data *init_data); +int led_classdev_flash_register_ext(struct device *parent, + struct led_classdev_flash *fled_cdev, + struct led_init_data *init_data); static inline int led_classdev_flash_register(struct device *parent, - struct led_classdev_flash *fled_cdev) + struct led_classdev_flash *fled_cdev) { return led_classdev_flash_register_ext(parent, fled_cdev, NULL); } @@ -111,7 +111,7 @@ static inline int led_classdev_flash_register(struct device *parent, * * Unregister a previously registered via led_classdev_flash_register object */ -extern void led_classdev_flash_unregister(struct led_classdev_flash *fled_cdev); +void led_classdev_flash_unregister(struct led_classdev_flash *fled_cdev); /** * led_set_flash_strobe - setup flash strobe @@ -159,8 +159,8 @@ static inline int led_get_flash_strobe(struct led_classdev_flash *fled_cdev, * * Returns: 0 on success or negative error value on failure */ -extern int led_set_flash_brightness(struct led_classdev_flash *fled_cdev, - u32 brightness); +int led_set_flash_brightness(struct led_classdev_flash *fled_cdev, + u32 brightness); /** * led_update_flash_brightness - update flash LED brightness @@ -171,7 +171,7 @@ extern int led_set_flash_brightness(struct led_classdev_flash *fled_cdev, * * Returns: 0 on success or negative error value on failure */ -extern int led_update_flash_brightness(struct led_classdev_flash *fled_cdev); +int led_update_flash_brightness(struct led_classdev_flash *fled_cdev); /** * led_set_flash_timeout - set flash LED timeout @@ -182,8 +182,7 @@ extern int led_update_flash_brightness(struct led_classdev_flash *fled_cdev); * * Returns: 0 on success or negative error value on failure */ -extern int led_set_flash_timeout(struct led_classdev_flash *fled_cdev, - u32 timeout); +int led_set_flash_timeout(struct led_classdev_flash *fled_cdev, u32 timeout); /** * led_get_flash_fault - get the flash LED fault @@ -194,7 +193,6 @@ extern int led_set_flash_timeout(struct led_classdev_flash *fled_cdev, * * Returns: 0 on success or negative error value on failure */ -extern int led_get_flash_fault(struct led_classdev_flash *fled_cdev, - u32 *fault); +int led_get_flash_fault(struct led_classdev_flash *fled_cdev, u32 *fault); #endif /* __LINUX_FLASH_LEDS_H_INCLUDED */