From patchwork Tue Oct 1 14:56:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 174882 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp8664203ill; Tue, 1 Oct 2019 07:56:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+sEmvFcomeAyDwXQWrV7z8eY+yOUbUXM8a0P0F0PntBs8IfgUKJbyxaTLIKaCgN8A7JL1 X-Received: by 2002:a17:906:d0d2:: with SMTP id bq18mr24709395ejb.233.1569941803340; Tue, 01 Oct 2019 07:56:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569941803; cv=none; d=google.com; s=arc-20160816; b=GUeFAOKyFCoKfjDm/3k4IB3o27h3kktoS+CA1DZKXR38SncxfKLyFbd4qVQ9JEeKFE lBMDRVFZ74uH8pPuaJTNWcFzX0fK50lTDj9GC+Ird3ep/4QjV9HQAj4u/4jZ2aUBwn10 1ughF5SgoMAP0Z9syqaQQkj8FfDKZoWavbTXs7NGQfnSnjY80ISZ/1SId2ndnb3C9FKy JO4H8ITJ4BTmGVRUTQfrvLlGhcXNcOxNP4t1cG66wE/jubpJrhH076pNsRkRRWML6F2k UEmp4icNFgZeYRIpbvFVLvMixcbEkkzNvfRDkKalijwBk0MOWaHEMu6loLzAnbV9nX9E q1uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lKl5jQ7mh6/gE8rehrlJj/IcqIN46YAPUSSDUhqA3so=; b=i/iCYrxhQDisG6BC1t374K4Negrz9GONsrfg3fGtXhSki4pLn02o99NbyYwTsZSsQH f0YtX5OIM0h6OMnKaThUp63k5IVnH9Zq51OF5z8sb/OYezYAda6v3hXdJ1h6nxrVjxky FjF2CqobOkn3n3EVgp7svZr44zPiVhHCDBe3Op/9Byt2AUEfx9jjD5GvuBtI4uL4xGS6 W90i8wslR/XVuyDXZK3QAbK885swroOetHQByj96jB3uy2UtNR0Rv9kb85dDUAsXqI7Q bg0EGCYoimMA1X5Ja1gUlgPDCVSNEHdtg1HRqbVZgazNR60sVUBaiqxiw69MqFMUJz7V lRNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Opmzs9BP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h48si9456711ede.31.2019.10.01.07.56.43; Tue, 01 Oct 2019 07:56:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Opmzs9BP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389478AbfJAO4l (ORCPT + 27 others); Tue, 1 Oct 2019 10:56:41 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:33308 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389364AbfJAO4L (ORCPT ); Tue, 1 Oct 2019 10:56:11 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x91Eu8vq056695; Tue, 1 Oct 2019 09:56:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1569941768; bh=lKl5jQ7mh6/gE8rehrlJj/IcqIN46YAPUSSDUhqA3so=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=Opmzs9BP0USY6cCsUBSaxJovLrYAlG4Jw8rz+fBZi/5zYyAuhPquNrIfErcgb4WH9 axjdduEZD0PzTu2WG0FVnfSU+yk/ciT5m4CNCYdy/Z3dDAyvZqtfJNQoZv/SwpzEGy x2Dpn0Zr0ZhpcFI18SRK7i/5Qqmzq8bW65a/T0QA= Received: from DLEE111.ent.ti.com (dlee111.ent.ti.com [157.170.170.22]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x91Eu83v052937 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 1 Oct 2019 09:56:08 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 1 Oct 2019 09:55:57 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 1 Oct 2019 09:55:57 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id x91Eu7D4014792; Tue, 1 Oct 2019 09:56:07 -0500 From: Dan Murphy To: , CC: , , Dan Murphy Subject: [PATCH v10 16/16] leds: lp5523: Fix checkpatch issues in the code Date: Tue, 1 Oct 2019 09:56:20 -0500 Message-ID: <20191001145620.11123-17-dmurphy@ti.com> X-Mailer: git-send-email 2.22.0.214.g8dca754b1e In-Reply-To: <20191001145620.11123-1-dmurphy@ti.com> References: <20191001145620.11123-1-dmurphy@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix checkpatch errors and warnings for the LP5523.c device driver. Signed-off-by: Dan Murphy --- drivers/leds/leds-lp5523.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) -- 2.22.0.214.g8dca754b1e diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c index 07484fc2f715..039db7e676ab 100644 --- a/drivers/leds/leds-lp5523.c +++ b/drivers/leds/leds-lp5523.c @@ -23,13 +23,13 @@ #define LP5523_PROGRAM_LENGTH 32 /* bytes */ /* Memory is used like this: - 0x00 engine 1 program - 0x10 engine 2 program - 0x20 engine 3 program - 0x30 engine 1 muxing info - 0x40 engine 2 muxing info - 0x50 engine 3 muxing info -*/ + * 0x00 engine 1 program + * 0x10 engine 2 program + * 0x20 engine 3 program + * 0x30 engine 1 muxing info + * 0x40 engine 2 muxing info + * 0x50 engine 3 muxing info + */ #define LP5523_MAX_LEDS 9 /* Registers */ @@ -326,7 +326,7 @@ static int lp5523_update_program_memory(struct lp55xx_chip *chip, const u8 *data, size_t size) { u8 pattern[LP5523_PROGRAM_LENGTH] = {0}; - unsigned cmd; + unsigned int cmd; char c[3]; int nrchars; int ret; @@ -468,6 +468,7 @@ static int lp5523_mux_parse(const char *buf, u16 *mux, size_t len) static void lp5523_mux_to_array(u16 led_mux, char *array) { int i, pos = 0; + for (i = 0; i < LP5523_MAX_LEDS; i++) pos += sprintf(array + pos, "%x", LED_ACTIVE(led_mux, i)); @@ -506,7 +507,7 @@ static int lp5523_load_mux(struct lp55xx_chip *chip, u16 mux, int nr) if (ret) return ret; - ret = lp55xx_write(chip, LP5523_REG_PROG_MEM , (u8)(mux >> 8)); + ret = lp55xx_write(chip, LP5523_REG_PROG_MEM, (u8)(mux >> 8)); if (ret) return ret;