From patchwork Thu Sep 12 08:29:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanimir Varbanov X-Patchwork-Id: 173683 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ce:0:0:0:0 with SMTP id r14csp1819571ilq; Thu, 12 Sep 2019 01:30:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqxiSM90dEOGGaUbJDECa1w8DpuUVi5rPGku6Asm9GRUCSiwDNNSeVtf/cUV6FdUkEnQQBoM X-Received: by 2002:a17:906:d7a3:: with SMTP id pk3mr33315677ejb.97.1568277018922; Thu, 12 Sep 2019 01:30:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568277018; cv=none; d=google.com; s=arc-20160816; b=xxCoV34nWYMG5hEslZH9+5OPi9fqbhMafmFqPlCmsXPD7ec5f39xNbbO4CZchkYd8d S0k5l+NW5D7gsYQFW31r/RfKddoNvDVJe/QT7nHip0RfFj9cMQL0nxS/hAqFKIObhjSs i9wcQyexsL4hDXfd5TXXo6GRpIuw+ZCY3sDKQLCQhgCD2AzGlFrbJznVN9RjPKLWg7QS p+V/oq6fHGolAsRsR5zhyc/ecGjDapJIA+dLiMu+F3XD4vXt0ueVGjsjQgxFlJlF1TAm K/xXYFCKATkPavIuRgTPFLlt1AzhmmQLiGh2fPdc6xIOaN/tXDAEjpde7l2VmK2IsC7H GSbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=UAWcRjdi1DIqgNYxD8IztK60e8Q6M5OSwZreQ9pReRc=; b=0UuUOX39XuTdHz6/ZqeCrqu/Ad36DABxAlaVAtxuaBEFu9tyI/X09xA9WToNC4N69O kTLD0WVYDdb2dNgWBTuduSgUdi1pFKZ3IB+jjEhsSagpZ1wlFMrfZ1yjIuAaO4OC4LUT B78QesXh8CsUw0WwYsiwVtaYpKVHd/3J7hSxUCRUrvIQtHa61R+Ef2fGcUGLsX62qPjA 9hwVUubfD+EWUrySgQnfug2HgDEB710Av/7s5hcWxmUhh060jOwFZZa1duf8nySlkqLk V8ZWqJQ9Q9TZuD3sdZDgrc+KXSk1LiCYge2Zsooqw3NLbuJiiioWB9d4QR2oGHuIIdeZ CjTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=keeBvy4Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gt10si12197119ejb.282.2019.09.12.01.30.18; Thu, 12 Sep 2019 01:30:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=keeBvy4Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730394AbfILIaQ (ORCPT + 27 others); Thu, 12 Sep 2019 04:30:16 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46019 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730131AbfILIaN (ORCPT ); Thu, 12 Sep 2019 04:30:13 -0400 Received: by mail-wr1-f67.google.com with SMTP id l16so27354351wrv.12 for ; Thu, 12 Sep 2019 01:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UAWcRjdi1DIqgNYxD8IztK60e8Q6M5OSwZreQ9pReRc=; b=keeBvy4YkRPJMInXu5kXGUL9Vm3yIF0nc7/Ig2KllCmw2RSre18+kzUExkZAQorL84 5xuAQUupiHNXELzSLZgg69r0tzQXnacGFifv8HYSq4Je7kOOAC5sHilhEKNoLgmkC+yr pyvJClwSc8Fb6kDN1mLWIaQ/xqJY902CVni+k6KIoOBALPo2gjz39NsjTXN5+AXkOd/b a9z+RhGHe2FnNiicXFunN+ayoO/VDoU8f553q4eT5UjhEWG+5KwhiG/0aU+88QtYt2GR sB/kzwPw3Lh9AHN1mWajnkySISVWFc3MFwvuVQzr9SyTHeux2U2ylwRz8J2WKwPmoJOR KGgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UAWcRjdi1DIqgNYxD8IztK60e8Q6M5OSwZreQ9pReRc=; b=CLKxdKMuCvAdIyUQSMAl123cQnmPE1oFWmC8WQYE6iVWt+f7dbS5ZPbPEuA+D4dL+P 4rvE30w4+OiqSQzmow3+Hj42tYIR/G+Nxk2J1PQG4erpMCvpLEkKiPG7utC+vKmvSvAb y5azjWmETjg44iqcQ6QcEFDC1eHmQwZ0q/UcsGL0rh4f8aCvgx7DLNi7ShCW8+ROVd+z QCtOe8LGi3JEITOm8KixkJozVIJMNfVkH3Y2t3HCJFgaZIeiKO21P6sU2gC5xel473va oLYmZf3jcd0rZCBJJ0eW8xAa2HNODKTInhIAjpOXKFUexuaer3Xdm2obSne7E0NvJfE4 W42g== X-Gm-Message-State: APjAAAWeItxesEvLgdirO9ulxDCFIgR5HDdPCpEYhXo3AzlmtrF6Pppu 4q7SVLewwXWafQBdzTLhD+MVOA== X-Received: by 2002:a5d:5689:: with SMTP id f9mr2063228wrv.224.1568277009046; Thu, 12 Sep 2019 01:30:09 -0700 (PDT) Received: from mms-0440.qualcomm.mm-sol.com ([37.157.136.206]) by smtp.gmail.com with ESMTPSA id 189sm7100877wmz.19.2019.09.12.01.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2019 01:30:08 -0700 (PDT) From: Stanimir Varbanov To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: Vikash Garodia , Andy Gross , Georgi Djakov , Stanimir Varbanov Subject: [PATCH v2 1/2] venus: use on-chip interconnect API Date: Thu, 12 Sep 2019 11:29:47 +0300 Message-Id: <20190912082948.22836-2-stanimir.varbanov@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190912082948.22836-1-stanimir.varbanov@linaro.org> References: <20190912082948.22836-1-stanimir.varbanov@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This aims to add a requests for bandwidth scaling depending on the resolution and framerate (macroblocks per second). The exact value of the requested bandwidth is get from a pre-calculated tables for encoder and decoder. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/Kconfig | 1 + drivers/media/platform/qcom/venus/core.c | 34 +++++++++++ drivers/media/platform/qcom/venus/core.h | 14 +++++ drivers/media/platform/qcom/venus/helpers.c | 67 ++++++++++++++++++++- 4 files changed, 115 insertions(+), 1 deletion(-) -- 2.17.1 Acked-by: Georgi Djakov diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index 83a785010753..97332dcb944c 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -483,6 +483,7 @@ config VIDEO_QCOM_VENUS tristate "Qualcomm Venus V4L2 encoder/decoder driver" depends on VIDEO_DEV && VIDEO_V4L2 depends on (ARCH_QCOM && IOMMU_DMA) || COMPILE_TEST + depends on INTERCONNECT || !INTERCONNECT select QCOM_MDT_LOADER if ARCH_QCOM select QCOM_SCM if ARCH_QCOM select VIDEOBUF2_DMA_SG diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c index e6eff512a8a1..71aab25700e8 100644 --- a/drivers/media/platform/qcom/venus/core.c +++ b/drivers/media/platform/qcom/venus/core.c @@ -5,6 +5,7 @@ */ #include #include +#include #include #include #include @@ -239,6 +240,14 @@ static int venus_probe(struct platform_device *pdev) if (IS_ERR(core->base)) return PTR_ERR(core->base); + core->video_path = of_icc_get(dev, "video-mem"); + if (IS_ERR(core->video_path)) + return PTR_ERR(core->video_path); + + core->cpucfg_path = of_icc_get(dev, "cpu-cfg"); + if (IS_ERR(core->cpucfg_path)) + return PTR_ERR(core->cpucfg_path); + core->irq = platform_get_irq(pdev, 0); if (core->irq < 0) return core->irq; @@ -273,6 +282,10 @@ static int venus_probe(struct platform_device *pdev) if (ret) return ret; + ret = icc_set_bw(core->cpucfg_path, 0, kbps_to_icc(1000)); + if (ret) + return ret; + ret = hfi_create(core, &venus_core_ops); if (ret) return ret; @@ -355,6 +368,9 @@ static int venus_remove(struct platform_device *pdev) pm_runtime_put_sync(dev); pm_runtime_disable(dev); + icc_put(core->video_path); + icc_put(core->cpucfg_path); + v4l2_device_unregister(&core->v4l2_dev); return ret; @@ -464,9 +480,27 @@ static const struct freq_tbl sdm845_freq_table[] = { { 244800, 100000000 }, /* 1920x1080@30 */ }; +static const struct bw_tbl sdm845_bw_table_enc[] = { + { 1944000, 1612000, 0, 2416000, 0 }, /* 3840x2160@60 */ + { 972000, 951000, 0, 1434000, 0 }, /* 3840x2160@30 */ + { 489600, 723000, 0, 973000, 0 }, /* 1920x1080@60 */ + { 244800, 370000, 0, 495000, 0 }, /* 1920x1080@30 */ +}; + +static const struct bw_tbl sdm845_bw_table_dec[] = { + { 2073600, 3929000, 0, 5551000, 0 }, /* 4096x2160@60 */ + { 1036800, 1987000, 0, 2797000, 0 }, /* 4096x2160@30 */ + { 489600, 1040000, 0, 1298000, 0 }, /* 1920x1080@60 */ + { 244800, 530000, 0, 659000, 0 }, /* 1920x1080@30 */ +}; + static const struct venus_resources sdm845_res = { .freq_tbl = sdm845_freq_table, .freq_tbl_size = ARRAY_SIZE(sdm845_freq_table), + .bw_tbl_enc = sdm845_bw_table_enc, + .bw_tbl_enc_size = ARRAY_SIZE(sdm845_bw_table_enc), + .bw_tbl_dec = sdm845_bw_table_dec, + .bw_tbl_dec_size = ARRAY_SIZE(sdm845_bw_table_dec), .clks = {"core", "iface", "bus" }, .clks_num = 3, .max_load = 3110400, /* 4096x2160@90 */ diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h index 922cb7e64bfa..661eaa7b81ec 100644 --- a/drivers/media/platform/qcom/venus/core.h +++ b/drivers/media/platform/qcom/venus/core.h @@ -26,10 +26,22 @@ struct reg_val { u32 value; }; +struct bw_tbl { + u32 mbs_per_sec; + u32 avg; + u32 peak; + u32 avg_10bit; + u32 peak_10bit; +}; + struct venus_resources { u64 dma_mask; const struct freq_tbl *freq_tbl; unsigned int freq_tbl_size; + const struct bw_tbl *bw_tbl_enc; + unsigned int bw_tbl_enc_size; + const struct bw_tbl *bw_tbl_dec; + unsigned int bw_tbl_dec_size; const struct reg_val *reg_tbl; unsigned int reg_tbl_size; const char * const clks[VIDC_CLKS_NUM_MAX]; @@ -115,6 +127,8 @@ struct venus_core { struct clk *core1_clk; struct clk *core0_bus_clk; struct clk *core1_bus_clk; + struct icc_path *video_path; + struct icc_path *cpucfg_path; struct video_device *vdev_dec; struct video_device *vdev_enc; struct v4l2_device v4l2_dev; diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c index 1ad96c25ab09..f18458921f5d 100644 --- a/drivers/media/platform/qcom/venus/helpers.c +++ b/drivers/media/platform/qcom/venus/helpers.c @@ -5,6 +5,7 @@ */ #include #include +#include #include #include #include @@ -388,6 +389,65 @@ static u32 load_per_type(struct venus_core *core, u32 session_type) return mbs_per_sec; } +static void mbs_to_bw(struct venus_inst *inst, u32 mbs, u32 *avg, u32 *peak) +{ + const struct venus_resources *res = inst->core->res; + const struct bw_tbl *bw_tbl; + unsigned int num_rows, i; + + *avg = 0; + *peak = 0; + + if (mbs == 0) + return; + + if (inst->session_type == VIDC_SESSION_TYPE_ENC) { + num_rows = res->bw_tbl_enc_size; + bw_tbl = res->bw_tbl_enc; + } else if (inst->session_type == VIDC_SESSION_TYPE_DEC) { + num_rows = res->bw_tbl_dec_size; + bw_tbl = res->bw_tbl_dec; + } else { + return; + } + + if (!bw_tbl || num_rows == 0) + return; + + for (i = 0; i < num_rows; i++) { + if (mbs > bw_tbl[i].mbs_per_sec) + break; + + if (inst->dpb_fmt & HFI_COLOR_FORMAT_10_BIT_BASE) { + *avg = bw_tbl[i].avg_10bit; + *peak = bw_tbl[i].peak_10bit; + } else { + *avg = bw_tbl[i].avg; + *peak = bw_tbl[i].peak; + } + } +} + +static int load_scale_bw(struct venus_core *core) +{ + struct venus_inst *inst = NULL; + u32 mbs_per_sec, avg, peak, total_avg = 0, total_peak = 0; + + mutex_lock(&core->lock); + list_for_each_entry(inst, &core->instances, list) { + mbs_per_sec = load_per_instance(inst); + mbs_to_bw(inst, mbs_per_sec, &avg, &peak); + total_avg += avg; + total_peak += peak; + } + mutex_unlock(&core->lock); + + dev_dbg(core->dev, "total: avg_bw: %u, peak_bw: %u\n", + total_avg, total_peak); + + return icc_set_bw(core->video_path, total_avg, total_peak); +} + int venus_helper_load_scale_clocks(struct venus_core *core) { const struct freq_tbl *table = core->res->freq_tbl; @@ -431,10 +491,15 @@ int venus_helper_load_scale_clocks(struct venus_core *core) if (ret) goto err; + ret = load_scale_bw(core); + if (ret) + goto err; + return 0; err: - dev_err(dev, "failed to set clock rate %lu (%d)\n", freq, ret); + dev_err(dev, "failed to set clock rate %lu or bandwidth (%d)\n", + freq, ret); return ret; } EXPORT_SYMBOL_GPL(venus_helper_load_scale_clocks);