From patchwork Thu Aug 22 15:20:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Valente X-Patchwork-Id: 172030 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1036618ily; Thu, 22 Aug 2019 08:21:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqwSoQpIbvBVKItL9Foyg/BJFfLdm9t/DMsnRftFbK7QHQnbBKqi9GZPKeW8Is/oURbikQIe X-Received: by 2002:a17:902:1e3:: with SMTP id b90mr39842352plb.82.1566487270206; Thu, 22 Aug 2019 08:21:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566487270; cv=none; d=google.com; s=arc-20160816; b=vs8xkGxxV2juwveyqDCSFU3o/5AWcShSwCUzdElnlCaTfMN06886C6Z9hKrfkpTVUU GZe4jBj1qHJUl7p96JZfu9rGOhKm/20Cnveqtxh2snuuSZvtFseh7DVyrqtjEA9WF3GJ gWsKULATPrEw2Kj0kCTRsH73Iegx+zTN28IDGNEqKPi1L/UKhxnVJUbLolOazV4ePw8O iXJxtwegqWHWStnnJ5cjt+qN9mG4Aogqxj6c3u38/vBStDdhailY7W9lubw5eqVM0QZT hdmLeTdO7Rg6K+Y7hlqgl7p8xFtfMJs8J6BbjkSbLr8Fl3otL1S2mK0N0abmhsmAAgF9 uA0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=V/3hIve56TY3nPZuccDF0XScvmoR85KKgvEdDQPL/bY=; b=jf0I3O6BOZWE4aMhhfJZ5xos+rzOnCpmgw/7tU0R6Ifj1bH014iUEjFo9GOFtMal5U hVUKJ9M/2oGFkmE5LKxE9oEZQ1MfF2ThDRndOz5Scnvwa0ICcVQYbDfNf7EeHCAJARqc Te+L5AeJe3SJix/qmkg8fu+5EpevnV/tUwcZGRnPVvCaQZtz53YC1XmAaaL/ueJlyF75 jdiRrzxjPBd4tbKKXQTXuGdzVs/NnmmrWxQuLmC/T3Ou+UnGhDUejGKHBX3CVIhJakP8 /Cdd8Tcl+UgBekC9pzqQHWlqQm7re4BRmM22PyAwHpblxgFDW4Y4TfykzKrf2H+he4+X Qk2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x15ajMuF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 19si18169189pfc.239.2019.08.22.08.21.09; Thu, 22 Aug 2019 08:21:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x15ajMuF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389566AbfHVPVG (ORCPT + 28 others); Thu, 22 Aug 2019 11:21:06 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:38731 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389553AbfHVPVE (ORCPT ); Thu, 22 Aug 2019 11:21:04 -0400 Received: by mail-wm1-f67.google.com with SMTP id m125so6184183wmm.3 for ; Thu, 22 Aug 2019 08:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V/3hIve56TY3nPZuccDF0XScvmoR85KKgvEdDQPL/bY=; b=x15ajMuFW8CBP6Ko+tieGCodba9xi+nKg0uU130qGB/0AsMLTk7urKVBk2TvKyQbsP 8eYi066CDFpPZTv92qUgfwveDdWeg5ZvMmndvKnt3/rBYG00Ki7965Gwv/B7/KeGOUfZ hROJzc6XjdBGMTZY9oNeNCJdTbgDo4/5+4MNYMA+sHeLlwPL8HeFE7Zyaen/f/Y+x2Ap pA82W5AU+LX5cxhZwUXARXQfBIeJbnptBQVGCgcqGBaegBNZ4iXnatQuMDI5yYtN/pWU 3beqY7Bt2PEjSNKWfieDFMdLYw+tSNxj7+9txR1qynN4PcOa2ZXJtlhlBWUwhWjry+04 tfWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V/3hIve56TY3nPZuccDF0XScvmoR85KKgvEdDQPL/bY=; b=phjJK1Q4z+UV7qtKytWZkvAuWGPPxXkUg00XsEM7R3eqPt893Nv9bdVn1n5znzwzjx F2R+jQ/em0ecu4toFTfQdE1UgurDCyJTV1Z0kULnpKi+TuL8zzClWvucFcjjRv620oF/ mgp+YdtjBjkIBicEUTCl/7m+lNELiJhQ1A9/zYPLJQL/jAuRNM0FwgzlC0nQNiLZSOTW omLxQrKUrhykBwX1t+Vh0vmUteTj+TvE4wgwu2Kxw7SRpE9W9wWVcFejIJz+jfwhbdxb Pulqqlw4Nlb2iEGC9BB9IZmHdhp/BClydauRyGZOZTXMH+Ex6m50COEujcpqUqvj7A2p rLQA== X-Gm-Message-State: APjAAAXdflWBlcq+kGAxkXjQpkeOoc1FhqLhRrf5WBwH8GHUcpbKQtLW Rbq8DpHm498Sthb/vuhlOojZgg== X-Received: by 2002:a05:600c:204:: with SMTP id 4mr7433884wmi.167.1566487262553; Thu, 22 Aug 2019 08:21:02 -0700 (PDT) Received: from localhost.localdomain (146-241-115-105.dyn.eolo.it. [146.241.115.105]) by smtp.gmail.com with ESMTPSA id a19sm79833974wra.2.2019.08.22.08.21.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Aug 2019 08:21:02 -0700 (PDT) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name, Paolo Valente Subject: [PATCH 3/4] block, bfq: increase update frequency of inject limit Date: Thu, 22 Aug 2019 17:20:36 +0200 Message-Id: <20190822152037.15413-4-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190822152037.15413-1-paolo.valente@linaro.org> References: <20190822152037.15413-1-paolo.valente@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The update period of the injection limit has been tentatively set to 100 ms, to reduce fluctuations. This value however proved to cause, occasionally, the limit to be decremented for some bfq_queue only after the queue underwent excessive injection for a lot of time. This commit reduces the period to 10 ms. Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index e114282204f6..ddac93e910fa 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -2016,7 +2016,7 @@ static void bfq_add_request(struct request *rq) (bfqq->last_serv_time_ns > 0 && bfqd->rqs_injected && bfqd->rq_in_driver > 0)) && time_is_before_eq_jiffies(bfqq->decrease_time_jif + - msecs_to_jiffies(100))) { + msecs_to_jiffies(10))) { bfqd->last_empty_occupied_ns = ktime_get_ns(); /* * Start the state machine for measuring the