From patchwork Thu Aug 22 04:46:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 171998 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp361986ily; Wed, 21 Aug 2019 21:46:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpcEe8yvKuJcRFfQduLf3Wzd4MjoAjfXDEMC/LwL2J4DpMqjbrGBzaYKEix1EBIbCiSaAN X-Received: by 2002:a63:e84a:: with SMTP id a10mr33391608pgk.274.1566449209217; Wed, 21 Aug 2019 21:46:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566449209; cv=none; d=google.com; s=arc-20160816; b=Roq2dIuW0RbYhDxMLnF3dsTjrN8L7Iz1urcMRuBOUv4OFVyZocu3DvRFeeDc+qmlrL XSjwrwJyxuxEQ9tLGL7GuROQktT6jfvdS2QTlUE71wVkJaYVW8GqNBCLlnEH+C+OtiOM assTSJCDP3VfxqXC8TQp/kDjTingHgPoYWCq2qzAe8ydqKIRIQ3hekJWYv3SL4RAfUsS K9EAPucHo96tXT1xRt6dQmFc2B4xahMeQ28n5P+G5vBXfTNdzsqBvHenSzDzmbAEZoyx nJT4W61EWqKvRRjdnzkfCGLnwwzpQmFzNnM+rrrdwFjmQZc5kjdOI4HhKc4lS0ZWwwi+ DuAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=hD5x6lRKUb0/bNsPEdTjxNKGIJMjG0FfIIS/kLrvgeQ=; b=yBD+2ifGXV6DqFHPjq5OIjBzwH0kU9s6pf0KQ9sG4A4xz2qmrS6MkUm51l5MHXd8Gm Fy1YsDW725x8cNLFzXe0208V+VnuvH78nARG3i5TerjTYAFoC/rQKKApbo89VRHsvKHa zw1A5T31ocwPU+tLqVeWjEvXBDKQA+8ZFPYTw4LgYOSbLFqoAeCScvNI1n/T2pDwXBLu ySSIMtMGmJgg7D2OUkOOO4lt6aR+zMnbzy4mei229wXafc/T2oAynAtF+8mQZDzx01Ll yWCn+IVC9yTRad6zJHApObJ95JvEqLViDkV4tcUxQcfjgo8Tu5E9fXuh/tH7nzCrt6+K 6yKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=f++9zhyS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j1si17235900pfa.91.2019.08.21.21.46.48; Wed, 21 Aug 2019 21:46:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=f++9zhyS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731072AbfHVEqr (ORCPT + 28 others); Thu, 22 Aug 2019 00:46:47 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:29724 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730896AbfHVEq3 (ORCPT ); Thu, 22 Aug 2019 00:46:29 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x7M4kEYh001492; Thu, 22 Aug 2019 13:46:16 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x7M4kEYh001492 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1566449176; bh=hD5x6lRKUb0/bNsPEdTjxNKGIJMjG0FfIIS/kLrvgeQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f++9zhySIjkHbDQkl57baoVaRVeJp+Yd9LX6Vx+VUn/vQK/DTqCnrVAsBxCqnsqz8 wtMD0gsjdD/vyp44n/CHj71HgbsOozl/0M872DhTvwrpZmiwIUG2TCZAFyhtiGRkkg J2AZXIgM8egOXJEfevgHfONc2KzkW/JSUr3p3qXJgqioa4HZo59qRnuVW4kbchavqq iXWFkVDPWeKkpKp2Eip1S4Ts0eiNWdQWscyCZbCeC45N7zmY/dk5Nc/7S9KBq3GUon rnq4vdbOODNiWn6xaTYrHEqW/KUCvi/e7OEfnwlzzisu9F9a400HJwFsWat9st6iVt F6WPMtgX9uPww== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Geert Uytterhoeven , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH 3/6] kbuild: clarify where to run make mrproper when out-of-tree fails Date: Thu, 22 Aug 2019 13:46:10 +0900 Message-Id: <20190822044613.5349-3-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190822044613.5349-1-yamada.masahiro@socionext.com> References: <20190822044613.5349-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If you try out-of-tree build with an unclean source tree, Kbuild suggests to run make mrproper. The path to the source tree may be shown with a relative path, for example, "make O=foo" emits the following: .. is not clean, please run 'make mrproper' in the '..' directory. This is somewhat confusing if you ran "make O=foo" in the source tree. Using the absolute path will be clearer. This commit changes the error message like follows: *** *** The source tree is not clean, please run 'make mrproper' *** in /absolute/path/to/linux *** Signed-off-by: Masahiro Yamada --- Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/Makefile b/Makefile index d9cbbc27d4ba..901fcb8fffbe 100644 --- a/Makefile +++ b/Makefile @@ -1121,8 +1121,10 @@ ifdef building_out_of_srctree $(Q)if [ -f $(srctree)/.config -o \ -d $(srctree)/include/config -o \ -d $(srctree)/arch/$(SRCARCH)/include/generated ]; then \ - echo >&2 " $(srctree) is not clean, please run 'make$(if $(findstring command line, $(origin ARCH)), ARCH=$(ARCH)) mrproper'"; \ - echo >&2 " in the '$(srctree)' directory.";\ + echo >&2 "***"; \ + echo >&2 "*** The source tree is not clean, please run 'make$(if $(findstring command line, $(origin ARCH)), ARCH=$(ARCH)) mrproper'"; \ + echo >&2 "*** in $(abs_srctree)";\ + echo >&2 "***"; \ /bin/false; \ fi; endif