From patchwork Thu Aug 22 04:46:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 171996 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp361844ily; Wed, 21 Aug 2019 21:46:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqwzIAcFxMiyjp+HACkxYHZW9qjnE335LC6Rm/m5lzxkD+tdo7+FEVM5xFcmJVNBJdVDadRi X-Received: by 2002:a63:714a:: with SMTP id b10mr33130425pgn.25.1566449196223; Wed, 21 Aug 2019 21:46:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566449196; cv=none; d=google.com; s=arc-20160816; b=IRdTUlLjAR6fxVdK9/tDRZFtHVSpZDQ5YUFEqvT0JGznDfyvPVefREgYJATUz80Jqs p0Jz9I63pVd/Goov3MVbyb0f/861d+LQY9DxLUWCAWbh0uB8LqNs0kRVIdlOADEb7GVt eW2ihurhSB1L2UxgkHBQh9EWwwUO0ZdsECx/m7dTxCOuV35PraziFnjzxb9p4cwVzWGx p+tKqrRjSvIuy/W24LkNR5whidaM1DMbrg8XRrLe5oB06w5GAr/3AhsVK7IhKsXjnV31 NnSt8tvnPMfUXAaP5b1GHLHeSr1OLg/x4Av203t2gvta0c78tMf/q/OHN+Dsez8gq63Q RbCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=6AT+dnC1KRtHZkgR5NDUwVJPbnoa90i0FGA/GZb8vBc=; b=Aya55ApJNU24cZ21NHroPsoKgE5YctdzVDOYP/nWPNO+pPR0IewGvSxNdT+r2wq/w7 6L9SyL1j7zRv8WOHClJX580sIJ2cUvqLm4EFx2gOAnB3ADdwRFqcomMtHGHAm7tyVbSS sauBcoYJ80oQDRlHqCkA2biApymBW7CeXFoYcAn7tT6du/sWj2qNtb4dM/q+iVx5QFqL o36bZdxWM1w/ozqTMYfSDTjwweKdnxBQcIAMTDHayenWB7RmXkd4XoLpg0uYwqJxhByZ 1oML0I5CNmQcNHPR9OGDLjC8VidGVKXwZnQ2P6LgX5zQ0akCuTpPz/eNBzrgXkuhbDcy QiVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=EqviCUvK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z11si1529909pju.108.2019.08.21.21.46.35; Wed, 21 Aug 2019 21:46:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=EqviCUvK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731019AbfHVEqa (ORCPT + 28 others); Thu, 22 Aug 2019 00:46:30 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:29725 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728870AbfHVEq3 (ORCPT ); Thu, 22 Aug 2019 00:46:29 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x7M4kEYg001492; Thu, 22 Aug 2019 13:46:15 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x7M4kEYg001492 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1566449176; bh=6AT+dnC1KRtHZkgR5NDUwVJPbnoa90i0FGA/GZb8vBc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EqviCUvKXVV1ky5vWgW0oSU1yC+wfqhkaix6aM5c8DmuChMg7PZ1EVAJJWUXk59pG N49BYLafCevpEnduIyJ1LCfEH6GsRWksHJ4UCPMaIc9eZ5HdSMxJbPC9+wf6lIhE76 DVLnqAiaI0CFFI9R9mW3MFU4qaZYMq6Ja/V/8lhV3RSlcx9r1LwAnTBBU6Msou7cq9 tshRgYYUfwTqXDjdUcWjpBL3inkCdyejGo13U83nsHXPUkmoKcZ18Bk2j6z2jJgBdU KtfyC45YE3R0RjB1zGY65yrtZ/6RfgXfTRMCYt9Ndy9BrrU2vseMW3zimavi1AkBTC 3tWlmDwOyr/ng== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Geert Uytterhoeven , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH 2/6] kbuild: Inform user to pass ARCH= for make mrproper only when necessary Date: Thu, 22 Aug 2019 13:46:09 +0900 Message-Id: <20190822044613.5349-2-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190822044613.5349-1-yamada.masahiro@socionext.com> References: <20190822044613.5349-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit 3a475b2166fd ("kbuild: Inform user to pass ARCH= for make mrproper"), if you try out-of-tree build with an unclean source tree, it suggests to run 'make ARCH= mrproper'. This looks odd when you are not cross-compiling the kernel. Show the 'ARCH=' part only when ARCH= was given from the command line. If ARCH is the default (native build) or came from the environment, it should simply suggest 'make mrproper' as before. Signed-off-by: Masahiro Yamada --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/Makefile b/Makefile index a77102e4ee90..d9cbbc27d4ba 100644 --- a/Makefile +++ b/Makefile @@ -1121,7 +1121,7 @@ ifdef building_out_of_srctree $(Q)if [ -f $(srctree)/.config -o \ -d $(srctree)/include/config -o \ -d $(srctree)/arch/$(SRCARCH)/include/generated ]; then \ - echo >&2 " $(srctree) is not clean, please run 'make ARCH=$(ARCH) mrproper'"; \ + echo >&2 " $(srctree) is not clean, please run 'make$(if $(findstring command line, $(origin ARCH)), ARCH=$(ARCH)) mrproper'"; \ echo >&2 " in the '$(srctree)' directory.";\ /bin/false; \ fi;