From patchwork Tue Jul 30 15:58:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 170078 Delivered-To: patch@linaro.org Received: by 2002:ac9:2daa:0:0:0:0:0 with SMTP id g42csp4847317oce; Tue, 30 Jul 2019 08:59:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqxFsL7zPRi3HckgunFmX9NNdtYs8Rgy1siOl3VoWdz8uOMbAUnL1UfCCwRteKwfnuZp1XZk X-Received: by 2002:a17:90a:9604:: with SMTP id v4mr115420813pjo.66.1564502359817; Tue, 30 Jul 2019 08:59:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564502359; cv=none; d=google.com; s=arc-20160816; b=bRpo5GAVP7z18bzpda8PV1UBzDBy3lIWQqPX2QA5uRSwNDoL5gIqrnCvXWjEMCwUte KsJlh+SnwHifXoR7LW15e3nROvbnS9dp7hUViBGAtTkGvHtbyK4xR0eyTm6Li3ec28M2 +wZjF3FHIwWUzMEFEvzB5oUW+CrQpw8B+pFMe/UhAP9H3XQIdIF5VhSwcL1bTf0J1DfK ebg/gU+1VLlkeLbMvpiIQ6KEHYE9ECCnWJXP8F4E0fn+Wp0Q97H2xn0Tw70W+pSjugYL WTDDrgEE7FTVkCUPKSOqGRg08NLdKK44GB2vmBLIex8+6VeOAk2NWwrcL7KtaUNuqypG eprw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=tmS7rnSw2i0wnICGgr8MtsDLTrDE/y5htkc0RewVGsQ=; b=UFZy86m7n40oTt2hM/CMOqYb0uS6RAfILHafE3SKwUUgsJL8cINIwsePiUmqmgIt5G dlsjxZEAU7ETzkKr2OLgdTfFy8uwu4MoBr//sBnhXdvqBVHZhJUgNGm/0ovzsEw68kwu 4ge+qZC6lbXkggvK9n1sS544UPy8GLbpM6lcKF+2iiBGRAmC8WfAt8wesVnUbhnxKLL3 WYVahC6vqF3QHjB3Y1mq9obQYpbwrsi6quj7mt1xXG+4id3lVGbqGHAx4PI+TngRRHPd 77vw1xA4zO3J7YgZwDQu2+atXgzAq5EoSFjubBSh2wXZb/VdFW/iJbxc2j9bkrEe8SMp 49BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=SeHvLBy8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k189si30355427pgd.408.2019.07.30.08.59.19; Tue, 30 Jul 2019 08:59:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=SeHvLBy8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732728AbfG3P7S (ORCPT + 29 others); Tue, 30 Jul 2019 11:59:18 -0400 Received: from conuserg-11.nifty.com ([210.131.2.78]:60066 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729291AbfG3P7O (ORCPT ); Tue, 30 Jul 2019 11:59:14 -0400 Received: from grover.flets-west.jp (softbank126026094249.bbtec.net [126.26.94.249]) (authenticated) by conuserg-11.nifty.com with ESMTP id x6UFx3RY014915; Wed, 31 Jul 2019 00:59:03 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com x6UFx3RY014915 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1564502344; bh=tmS7rnSw2i0wnICGgr8MtsDLTrDE/y5htkc0RewVGsQ=; h=From:To:Cc:Subject:Date:From; b=SeHvLBy8UxNSSmSxw57UopL/v+/sDXCLCt5mURKX9QxblCFwEtObGcYs6AqFyWRae CQFOKPlz2LDf2LGVNZpY1vPVq5k5/r3rbWY6hR3+iVRPBJfn9lT+MV2AxbOo9L4+a6 TEOg6HC/Qqd/bh8PhpM7UbwTclEpieW4lRQn4KlckotzuDiqNStImwH4HrQIGSLxk1 58eIF1eqpAJ7qYM39BGpzRhVfkm75fltGTDCVc2fUIoZSs6EdFqDQK0KKlCcPpzM5w Iz8KZjhg3iXh8CpNY6pED7y2ZtyyGwTgZh1o2qP9mFFMHXzP7JPDBZsnY+rpZmdBs3 CE7aY0cjYfpMA== X-Nifty-SrcIP: [126.26.94.249] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada , stable@vger.kernel.org, Michal Marek Subject: [PATCH 1/4] kbuild: modpost: include .*.cmd files only when targets exist Date: Wed, 31 Jul 2019 00:58:59 +0900 Message-Id: <20190730155902.5557-1-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A build rule fails, the .DELETE_ON_ERROR special target removes the target, but does nothing for the .*.cmd file, which might be corrupted. So, .*.cmd files should be included only when the corresponding targets exist. Commit 392885ee82d3 ("kbuild: let fixdep directly write to .*.cmd files") missed to fix up this file. Fixes: 392885ee82d3 ("kbuild: let fixdep directly write to .*.cmd") Cc: # v5.0+ Signed-off-by: Masahiro Yamada --- scripts/Makefile.modpost | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.17.1 diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost index 6b19c1a4eae5..ad4b9829a456 100644 --- a/scripts/Makefile.modpost +++ b/scripts/Makefile.modpost @@ -145,10 +145,8 @@ FORCE: # optimization, we don't need to read them if the target does not # exist, we will rebuild anyway in that case. -cmd_files := $(wildcard $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd)) +existing-targets := $(wildcard $(sort $(targets))) -ifneq ($(cmd_files),) - include $(cmd_files) -endif +-include $(foreach f,$(existing-targets),$(dir $(f)).$(notdir $(f)).cmd) .PHONY: $(PHONY)