From patchwork Tue Jul 30 15:25:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 170074 Delivered-To: patch@linaro.org Received: by 2002:a92:512:0:0:0:0:0 with SMTP id q18csp2772351ile; Tue, 30 Jul 2019 08:25:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqzneXog87O5DyXvTY6LgsH237gxTj9ICob5vClR+8y7emRPW8U8Xws2EeKVJ6E9MQUd87rC X-Received: by 2002:a63:f750:: with SMTP id f16mr80119531pgk.317.1564500340134; Tue, 30 Jul 2019 08:25:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564500340; cv=none; d=google.com; s=arc-20160816; b=vvxjk/FrsGiWMfG97+rKbOatKqU3RcJceA0WLyqKM8cnfmKySm7+TirWu+KyZs0jWP QJJhTzjnf0wZxMyuKteyrlcLgJ8aqzlRUb8ljMspcOsW0ujBMLu2ZskEvqJCbyjdXWLA 2AaRVoHQbKRMqnQRAm09H7iqw7OVg4H+IAu5MGt413gOQXHP/6b9vbf2UVNRMb6xQ8/A tPv5TQEtbzmjOzVQ3CSvsNUVLkQtVNYu1rd1LXOZSVwch4DF/Xl6qBZRU11WO+41VZDM W2svXJJ7xRPC+SSc6WjT89o8E+PGUxHosNFp7RLUkeFez3p0UsirsxqE6QZ90s5Sngdc iHDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=a8k87dhuTxTzS+n3u2Ou7NXh77Uav3wOrh0j/WlwUGo=; b=AoeBzFf7X3DAUqZxJMJKfkFtyY1Yb5Wy1au5NwpAv8cJkDv6vZP8KqIdVYJ/dmf4OS oyRdkFpIdiF4/f9IPm/2KIYaLT7NMb8zuP5FPOmO5qT9eFhXfwuI2cBa6d5i6PSmAH/Z JyC9/Mp2Rd/ek+8pnfoaFC5RVEdshUVHyaT0ZkN2hrfIoebi+oDWoXTjxwZi/0EykL0d QFP1e9WuPqmoBaHnwICNYCAp1Myq9fZFxKmC7GrTewnlWRfOcBSzkuSJpsrMZGpRzvV5 +aqnQEvOGYKP1aGRqu+FtzuFX27JDupVqBf23ajzdBU47a3Xyp8bS4v55a5Crou1JJXn r3Xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=p5bsKDg7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f4si29563766pgg.334.2019.07.30.08.25.39; Tue, 30 Jul 2019 08:25:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=p5bsKDg7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732361AbfG3PZi (ORCPT + 29 others); Tue, 30 Jul 2019 11:25:38 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:35960 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732332AbfG3PZi (ORCPT ); Tue, 30 Jul 2019 11:25:38 -0400 Received: by mail-lf1-f66.google.com with SMTP id q26so45052544lfc.3 for ; Tue, 30 Jul 2019 08:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=a8k87dhuTxTzS+n3u2Ou7NXh77Uav3wOrh0j/WlwUGo=; b=p5bsKDg7tMBnd5qo4asPd25ewkYLyTBvTiDchpZUVrlXTDmyMEYZ5sLLXxeZE+FEJu fFFNjoTLkv5d2pa5xGLx9vkfp2kN2vnddjucaeZvUkFXRynv1VNzJ1pUcqmxb2Txe3do JzVko3L/nJk6RDWynthGjwo+jRTerO6ZGya1/kDLuC6bMX9B/IbVW/JZHrLMlgpcKLym sItTVYZ8Z+4m2Qww3kRTK+O9+PXHRF8M/C9S5nnxW1x3N3BsbW8oNQ7YaNaUDMO60oA1 XF9/tnA4qlzGsdu85SFUrd6yfss+zvC3BltZJqm8Q5sMSfDSix3SZ+AP1EjUxazCFJ4I wdPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=a8k87dhuTxTzS+n3u2Ou7NXh77Uav3wOrh0j/WlwUGo=; b=ZsG7b8B6D/GWYLet3L2wGbGMo1V0yGSuaRS33LX6kg/QZ20+IcLL5tiTObze9gNXuF 7WLTR1eFLX8VuaTHx4xS//Gcz0Wiwms8Vk1xDUnUKroC3CTwHCU/zLYOxhVXXPWQmg/1 rFuqS2EbMfVRpzr1t09giW8T/U1WlDA7YE90c7aC4HXFHfBpiewLCt2bcD0a/WI4Ecg2 0n7GjjjNUDUlHWRMeb+4KD17MU5xjki6xmll8aKdXIsFfa6/oi3xqSMA/CpeBnw7XzAz 98Nh9Jva50MR3BVXmJKIQwUhvMJ45OW3GxyJn88OAgYd81CdlYlWTvrsw3R68OzkzbCm kiVA== X-Gm-Message-State: APjAAAUVxy/rZzjBQCrNydsqv/k4H9dmrXyaIH8Jr8XJ189dI+LJrehg i2yIjQjdJ05s6ZaBBwJU90MNL8Wu8UykWg== X-Received: by 2002:a19:41cc:: with SMTP id o195mr10890679lfa.166.1564500336500; Tue, 30 Jul 2019 08:25:36 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id t5sm13280728ljj.10.2019.07.30.08.25.35 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 08:25:35 -0700 (PDT) From: Anders Roxell To: b.zolnierkie@samsung.com Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, gustavo@embeddedor.com, Anders Roxell Subject: [PATCH v2] video: fbdev: Mark expected switch fall-through Date: Tue, 30 Jul 2019 17:25:30 +0200 Message-Id: <20190730152530.3055-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that -Wimplicit-fallthrough is passed to GCC by default, the following warnings shows up: ../drivers/video/fbdev/sh_mobile_lcdcfb.c: In function ‘sh_mobile_lcdc_channel_fb_init’: ../drivers/video/fbdev/sh_mobile_lcdcfb.c:2086:22: warning: this statement may fall through [-Wimplicit-fallthrough=] info->fix.ypanstep = 2; ~~~~~~~~~~~~~~~~~~~^~~ ../drivers/video/fbdev/sh_mobile_lcdcfb.c:2087:2: note: here case V4L2_PIX_FMT_NV16: ^~~~ ../drivers/video/fbdev/sh_mobile_lcdcfb.c: In function ‘sh_mobile_lcdc_overlay_fb_init’: ../drivers/video/fbdev/sh_mobile_lcdcfb.c:1596:22: warning: this statement may fall through [-Wimplicit-fallthrough=] info->fix.ypanstep = 2; ~~~~~~~~~~~~~~~~~~~^~~ ../drivers/video/fbdev/sh_mobile_lcdcfb.c:1597:2: note: here case V4L2_PIX_FMT_NV16: ^~~~ Rework to address a warnings due to the enablement of -Wimplicit-fallthrough. Signed-off-by: Anders Roxell --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.1 diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c index ac0bcac9a865..c249763dbf0b 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c @@ -1594,6 +1594,7 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_overlay *ovl) case V4L2_PIX_FMT_NV12: case V4L2_PIX_FMT_NV21: info->fix.ypanstep = 2; + /* Fall through */ case V4L2_PIX_FMT_NV16: case V4L2_PIX_FMT_NV61: info->fix.xpanstep = 2; @@ -2084,6 +2085,7 @@ sh_mobile_lcdc_channel_fb_init(struct sh_mobile_lcdc_chan *ch, case V4L2_PIX_FMT_NV12: case V4L2_PIX_FMT_NV21: info->fix.ypanstep = 2; + /* Fall through */ case V4L2_PIX_FMT_NV16: case V4L2_PIX_FMT_NV61: info->fix.xpanstep = 2;