From patchwork Fri Jul 26 13:45:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 169830 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp83553ilk; Fri, 26 Jul 2019 06:46:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqwiMigd04Bl1r4dgSTJ2uxHZKgjUcXSwiLTKfwtKJxreEbDIQtwpxW9ruLNJA1K0Yef4Sq6 X-Received: by 2002:a63:6f41:: with SMTP id k62mr45591725pgc.32.1564148780721; Fri, 26 Jul 2019 06:46:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564148780; cv=none; d=google.com; s=arc-20160816; b=lCA7/mrPl3abn1BktHfBouUVcnC6sWt3PFnefEvqyowf+hlnnWfdWpvuk5JzdZuNLX +vL4FvkHQA2QSEntDPlEGBRA6lIJCOSjGbSIDIzvuUR64NqVmy3KgCrmsBR9rJzU2fi7 Ujib878tIThixd9yysTUu2FOu/tmcv+px6N5caTNqor84CV+not4eMoRV4caIHT6mdvW Vyogk8Wf4umENH+1Hkqzxm78470ORbI33eDjt97RyITOzcjOypSDrvwcKThHrUdWp6mu MdpGlXntTNrQHm4ZhaRrjnWISDSoVo3+WdYt3sSW8PD5BR9BMLYZmFemP9J9KphPkgTU N8gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=320TQZ5w2lNhAFIX1hOIch8yO3WN60yBrBwenhig/C4=; b=XJDLIGj+5WxvFHBcxn4m3YWDx9XnxXXzzCnHOaLFDnOr7Rr2mJjPaLYBqLLPu8nabQ 3Usss+d7iZQVMNuRjWfiK+avtqAItlhtLIqO8dgh5Bv82qt6GgMM4SxkQN+U8CRatFy1 pRmvDFqYJgCPU8Yvl4ABGbE1Kx2hyAacTYqxXv9MwC1AOyJutw2RLxVIm0zznRlTijv0 CfieBgUPdZ7eKKD6FEeuwlDDLnhuDorPl2prLkv5J/EK7R3jdINH603Hdj99tFTF6X1v tI+Iwbu0vQ5Ev8+L99Xry1GhoYyHAMQcEzArA7+9isOGDa9yws/Hl+NaJkUF/0mZrQL3 tvRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u3si19196169pgm.122.2019.07.26.06.46.20; Fri, 26 Jul 2019 06:46:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388686AbfGZNqS (ORCPT + 29 others); Fri, 26 Jul 2019 09:46:18 -0400 Received: from foss.arm.com ([217.140.110.172]:44048 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388648AbfGZNqI (ORCPT ); Fri, 26 Jul 2019 09:46:08 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 84532152D; Fri, 26 Jul 2019 06:46:08 -0700 (PDT) Received: from usa.arm.com (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4C3E33F694; Fri, 26 Jul 2019 06:46:07 -0700 (PDT) From: Sudeep Holla To: linux-arm-kernel@lists.infradead.org Cc: Sudeep Holla , Peng Fan , linux-kernel@vger.kernel.org, Bo Zhang , Jim Quinlan , Volodymyr Babchuk , Gaku Inami , Etienne Carriere Subject: [PATCH v2 3/6] firmware: arm_scmi: Remove extra check for invalid length message responses Date: Fri, 26 Jul 2019 14:45:28 +0100 Message-Id: <20190726134531.8928-4-sudeep.holla@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190726134531.8928-1-sudeep.holla@arm.com> References: <20190726134531.8928-1-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org scmi_xfer_get_init ensures both transmit and receive buffer lengths are within the maximum limits. If receive buffer length is not supplied by the caller, it's set to the maximum limit value. Receive buffer length is never modified after that. So there's no need for the extra check when receive transmit completion for a command essage. Further, if the response header length is greater than the prescribed receive buffer length, the response buffer is truncated to the latter. Reported-by: Jim Quinlan Signed-off-by: Sudeep Holla --- drivers/firmware/arm_scmi/driver.c | 6 ------ 1 file changed, 6 deletions(-) -- 2.17.1 diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index b5bc4c7a8fab..6ef652940099 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -230,12 +230,6 @@ static void scmi_rx_callback(struct mbox_client *cl, void *m) xfer = &minfo->xfer_block[xfer_id]; scmi_dump_header_dbg(dev, &xfer->hdr); - /* Is the message of valid length? */ - if (xfer->rx.len > info->desc->max_msg_size) { - dev_err(dev, "unable to handle %zu xfer(max %d)\n", - xfer->rx.len, info->desc->max_msg_size); - return; - } scmi_fetch_response(xfer, mem); complete(&xfer->done);