From patchwork Fri Jul 26 11:27:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 169812 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp12908789ilk; Fri, 26 Jul 2019 04:27:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqx05a8jpIM2DTMTzHCYecC9sjUvgOVWtmOL6mdVH5jAvLb2dsdo5pR2f6MS+XD0Q/IXFyPY X-Received: by 2002:a65:52c5:: with SMTP id z5mr76874139pgp.118.1564140456459; Fri, 26 Jul 2019 04:27:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564140456; cv=none; d=google.com; s=arc-20160816; b=J1dvV/oXyWf/razyP+H/Navy8lkdZrwY3+kPBd58NZin04AKnrbG1SIqgZDzajzR0i DtWHvhbK8mDBsNenAdipl5q3VTEFEcVs33kmtdV+Y4EwM5niKl2Fj8lj+ey/dV/L46i4 1i1Km0Ywtu45s6VALC2kI/e3c0ijM4X4PrysSt7D7wjhUx1NCPBhfHz+LMjyjhdlxqk/ B0lr+94ni5f7/PNjc/3pucbSgo/eK4gzAbEjEuspkYnrKOnrD1/zA7HoERYJMiCOBimm I+PqBK3h6YIaVRuX7D6TeLXGg86ZZ35kwOXrvglJNy2ranPjMk54rbNlrwcml3+qEA8K CYNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=VvJrkmi1Cwn8lyhtsQMDHS3PdPwEeGsIk+aMiHF32Hg=; b=SMXXSpRSatXJP4hCMMjGid9FgY0nGu2wCqIrNerMcYuAwKgMvoMp3TnTnZMQlQ9Q49 /TI7GFug0fDMpjYDIobrL7NcsQ+RemR98esylRk5xIJwg3AiZDrmcWgbMbosO58fbSSs eoty29Tn6TParYvEtNCuUXz8c5JL2YvMGgu/PaScpF7x6QcwfglcXgcmScXpqIcXbc76 Odh9ReUU+z1wJaOlsMh4TltvwreTe3SxdI5TYakoOXJNbmc+sjJl7u/N3wwJgmEyL3zQ PsSYhvjbwb7f4YvlRwGtt9GlZJggvnjH/Kuxfy2tJDqrCV4g1Ef5HGRR0Mof5XtZp8bq uR4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iZQOA7Vh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 6si20076195pgt.13.2019.07.26.04.27.36; Fri, 26 Jul 2019 04:27:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iZQOA7Vh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726942AbfGZL1e (ORCPT + 29 others); Fri, 26 Jul 2019 07:27:34 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:39421 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbfGZL1e (ORCPT ); Fri, 26 Jul 2019 07:27:34 -0400 Received: by mail-lj1-f195.google.com with SMTP id v18so51101141ljh.6 for ; Fri, 26 Jul 2019 04:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VvJrkmi1Cwn8lyhtsQMDHS3PdPwEeGsIk+aMiHF32Hg=; b=iZQOA7Vh1AeiCmJRZYyWRcnNJw7mx3vuhfziN5xJyN0nCT7/YCjDyON4hFIJluzUUJ PBTIsl/eTYaLQkxKXopF6i/KGxtsqDXJcMB/A4YDGS1hE+Ki4Pr4zt6VHpzzflC6hsWp MISFZM1VeJsGmuRFCfMd+od6WxGiROAM528q+xZV79/evZBuTXs4Bs6m3pc8kaILzXkl Dd49j4aAP4LQVPeWFIsFLkYUEgriYpGKy0OLxZSgXv9oy5W5YMtOLGvb63AJ1gKU+swq iLHXB9AOquA7wCoGVyOLOjI/gWq4QRP24yyN1zU9HTy/B6iQs3Kc3OUWz7Y5syEkxwKc IXFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VvJrkmi1Cwn8lyhtsQMDHS3PdPwEeGsIk+aMiHF32Hg=; b=AvlXNAgqU0QwSDxa2iCVF9+v8cvK7SkYSzZYyY/Wps8Z2qg4NXbtHtciBBEtz3Y9RG EK0rhA+AhkKnhAH+UAdO4ZMKWBw3ph2B0Kz4Ipe8yoYTBrlqFJETjakI6NhmjVCtHHPO U//0LPEOxIYU5oZIM14kVRmkfeyOW1YJCfNF0X0oMly32ixQ8NlLfFN1NobEFF7OTVJv ovbCu12DzRaNBNZDF2jtY5Q7BLkt1vesmYVpTxYJC6PpWhmTC00GSK4aRJnTi2UgGOL9 mqYBFcBh5nSLKPSSoJ/e7NYUf/PiaRhXz60BcXua0vsZ4HFoIpApdfPXsqKS2mVX8Yiq cwXA== X-Gm-Message-State: APjAAAV3eYdsmJTvUHF4iG2o+qopdQMa+L7akZpOFqQ3nIGQy2MadtVx NC0k2uPA4sn1Q8N4lxERZ6on1w== X-Received: by 2002:a2e:2b57:: with SMTP id q84mr49315455lje.105.1564140452344; Fri, 26 Jul 2019 04:27:32 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id i17sm8324734lfp.94.2019.07.26.04.27.31 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 04:27:31 -0700 (PDT) From: Anders Roxell To: catalin.marinas@arm.com, will@kernel.org Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH 3/3] arm64: smp: Mark expected switch fall-through Date: Fri, 26 Jul 2019 13:27:25 +0200 Message-Id: <20190726112725.19204-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When fall-through warnings was enabled by default the following warning was starting to show up: In file included from ../include/linux/kernel.h:15, from ../include/linux/list.h:9, from ../include/linux/kobject.h:19, from ../include/linux/of.h:17, from ../include/linux/irqdomain.h:35, from ../include/linux/acpi.h:13, from ../arch/arm64/kernel/smp.c:9: ../arch/arm64/kernel/smp.c: In function ‘__cpu_up’: ../include/linux/printk.h:302:2: warning: this statement may fall through [-Wimplicit-fallthrough=] printk(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../arch/arm64/kernel/smp.c:156:4: note: in expansion of macro ‘pr_crit’ pr_crit("CPU%u: may not have shut down cleanly\n", cpu); ^~~~~~~ ../arch/arm64/kernel/smp.c:157:3: note: here case CPU_STUCK_IN_KERNEL: ^~~~ Rework so that the compiler doesn't warn about fall-through. Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off-by: Anders Roxell --- arch/arm64/kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index ea90d3bd9253..018a33e01b0e 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -152,8 +152,8 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle) pr_crit("CPU%u: died during early boot\n", cpu); break; } - /* Fall through */ pr_crit("CPU%u: may not have shut down cleanly\n", cpu); + /* Fall through */ case CPU_STUCK_IN_KERNEL: pr_crit("CPU%u: is stuck in kernel\n", cpu); if (status & CPU_STUCK_REASON_52_BIT_VA)