From patchwork Mon Jul 22 12:44:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 169381 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp7482328ilk; Mon, 22 Jul 2019 05:45:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqyx8TRGCDJrlKyjk2x8hAIPe3g5xxD3yPCnE970s0PZB0zgo4dz4p07Pa0e6Je/db2Z2Gy0 X-Received: by 2002:a17:902:6a87:: with SMTP id n7mr74183346plk.336.1563799527957; Mon, 22 Jul 2019 05:45:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563799527; cv=none; d=google.com; s=arc-20160816; b=qNpQMZSCoHX9zu5maHQj8HtPjHi4VUX8+OKm7uxNJL2IHzhF21liS6b1BNdz3XkY8K r2rfILadCMnsOBydvYMHGhAqnzUHKnBYIhF1NktIRD5JQG7MZZ8QVaNx+LszopEqXzVO 99Td5Q9YMNjw28gb9RxoUqc69lqpk3OVtx7Rz7HVsDM/1kxPKa888ljGxBajNqNEYVPB eckok+IyNuQ6ZUSf4uPQt4pGUJZLMToCzCMH15rTvYxD9Nb0eL/duPgKG09vLox1C4eh 59Rcq3fFCT6Bw73Qh05IonF6I4nprutACa9oYLvdKv9vBPBTWzmZ8FbTPM9g7eiuHqFr uqEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=0mQKlCffs1DNG7ZQ46ebI4DBnHcVVpejD8xRadfBowE=; b=B5AQ7fI/vcQ3JbTL39ZBqqkUA1EgoL+g2kOcerpUukvRDVC5CZEihBRGeqDTVGvPeO dWGytR5Z+jom4wnUViDd385ZyD0HDa2XKvUpfmcDuPA164ktCcNGCwYinNlHNy7D3fNb 17VGxvDOzuJeN0zqvIlH5zM/zMFfwv2f2G+NEZQNSonIG1wXeeejOLQR8W3sjQCm4j5I H8rZXNAWbymvL26TctFAsTjk8rE60+3bjeqEeyoVw//5Gljak1o0egA13gxDV5RYiLC/ Z98eSD+Z5uZyw+TLdjFpyeqiVx9ch1nhwV3CgKXiuPMqTPjYeCN3UWH8+uqyAiocOSQX R+EA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=dmaengine-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q31si8450628pjc.33.2019.07.22.05.45.27; Mon, 22 Jul 2019 05:45:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=dmaengine-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727510AbfGVMp1 (ORCPT + 3 others); Mon, 22 Jul 2019 08:45:27 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:57701 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728298AbfGVMp1 (ORCPT ); Mon, 22 Jul 2019 08:45:27 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPA (Nemesis) id 1MTRAS-1hzSlf0CgG-00TlMc; Mon, 22 Jul 2019 14:45:03 +0200 From: Arnd Bergmann To: Gustavo Pimentel , Vinod Koul Cc: Arnd Bergmann , Dan Williams , Andy Shevchenko , Russell King , Joao Pinto , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] [v2] dmaengine: dw-edma: fix unnecessary stack usage Date: Mon, 22 Jul 2019 14:44:43 +0200 Message-Id: <20190722124457.1093886-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:YYatoRsXSnmJhuS9zQ32arIsHlbbR5TwQvO540Kwug1HsFi8yk3 Kt52+hk3Bnc9QwDzzrM0zJ2Xf/TbeFMIaneIxkPz1aAJNiOIPNd0eRa0sxEPiP+XHO5kRHg m8DfUJ22fnSE1lSn5KnTavkhtkdXhIOdFPxc4FvDgo5p2/U3ynruupU01STAhoEKwvjkUu/ aOLbyfKc9JHFrOoAtahUA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:Xf7VlFbttRk=:P5pqY5XIS0AguTxoatrB85 6/Dv4kEp/zrxSBGkDC/zCEYr6cIX110dt4M/PUeWZQy6+FeTT3x/AKFEgKWyp6ndpQnCzhNuP H9rf8Y684jHk5sEhgtAM3DZ/lMd2BpCPoLw9D/P/d1XWAt+iQCWxHjLUYSQgsjNaPeN7Tyaw7 5mb4qSCU8e40YszKrlxxiD3ntWflUj1Cv+q8FU7W1AXhoaQ4AxuhvbbPYO44PO937PFKbuidR 1F47QvQqCAhn83EXGcQGa5EmYyu31pWbtI5+wPH7aoGA6nbbpJvQzyrm5+WO1r4jouJ7MoNSa JoPxppQZBmP7+wFPNWdoRPvpvsz6YfjZknEUaTlbQDY9bLPuWwvTvYmvHYWaBH9UnBXpjo2b0 RwTkRRr4nrgC7ZuGYlxTdmuRpJUG10ErU2Mwnw06qLB6BzlcAZeP18UlQ8dtUOlbdvdY9fCKr T7deGhGJ31Mb4iwx7B7qGBndvbvdZW7LIgsIbceYp4YYDXl/F7ACL3ONniD0ASWpBjP9DHdYR 7pzQ2OOApGUu5xI7UmPJFvE6tKa1cN92IR+zfeEKRlLY9ddFhsk0H3GKh8ZKhIeb+49SdXlTL /Bm0/yZZd/L7RzNYSdZCkqXnyDJJwuDql8xgR7FS2SR10muMoOOtZaHw3H8fZwzDiGxES2pu8 4jRqEK0Hu59ASnTVESHRmh8AuMkMBaIRx/78qfwl6eoAsS4OvpxZnUggXLKs4tuwriLAWd3TA oKZK5SY4Gecik5cjHfrU01E2q/zWqheZqoOVug== Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Putting large constant data on the stack causes unnecessary overhead and stack usage: drivers/dma/dw-edma/dw-edma-v0-debugfs.c:285:6: error: stack frame size of 1376 bytes in function 'dw_edma_v0_debugfs_on' [-Werror,-Wframe-larger-than=] Mark the variable 'static const' in order for the compiler to move it into the .rodata section where it does no such harm. Fixes: 305aebeff879 ("dmaengine: Add Synopsys eDMA IP version 0 debugfs support") Signed-off-by: Arnd Bergmann --- v2: unchanged --- drivers/dma/dw-edma/dw-edma-v0-debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 Acked-by: Gustavo Pimentel diff --git a/drivers/dma/dw-edma/dw-edma-v0-debugfs.c b/drivers/dma/dw-edma/dw-edma-v0-debugfs.c index 3226f528cc11..5728b6fe938c 100644 --- a/drivers/dma/dw-edma/dw-edma-v0-debugfs.c +++ b/drivers/dma/dw-edma/dw-edma-v0-debugfs.c @@ -48,7 +48,7 @@ static struct { } lim[2][EDMA_V0_MAX_NR_CH]; struct debugfs_entries { - char name[24]; + const char *name; dma_addr_t *reg; };