From patchwork Fri Jul 19 20:03:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 169258 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp4273861ilk; Fri, 19 Jul 2019 13:04:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqyUjc6DjKARN5lx505rW7/KIc1qiduNvSiwaWlHVrxliurgUA9f7hXpDv/lmN2TNsydrAqA X-Received: by 2002:a65:5584:: with SMTP id j4mr25692434pgs.258.1563566647910; Fri, 19 Jul 2019 13:04:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563566647; cv=none; d=google.com; s=arc-20160816; b=HVTXjZ2pl0h+RbJnA98kCFYwITlJ5jwvJHzCPHg2gZAs0b+8C/y7v9TxGzUf8q9r7v JMxlnynl/MzMG3vr+4lHHrq3AF6q3GlExs+VPmmp050Nd8eAXcjWO48VLcEU2ITtaT+K qPdjwr8rzA95VFb9dvB3UhvkJU8RDeshlb5op97hSLml3svn1owmv+hByl9XF4IsVRcB sCbozK4W4FDOZ5HzGrt6Fq3xZ7uYtGnJFcoPqy0uNgA3FSL27dQu8JFUxJRUlqfAThuC GDqhLdCGzEzoCc0mEgUGQbjYyoPtatd0aJhVnyYc0epFqkt0ziPMSUaCztL69Xv6AYXr UrZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=6S+4K9/n9Gw0sVezoIJeoHXRfKqBwRbFe1Ybos+YA8g=; b=oJdS/rlGlLOPYLGsbLgBF7bOfgScjNptIgxO2cjrI6iLhS/LPcC6E2YTRniLYLioiI raNouSdl5bwjswMFWs/KL9uG/Kag0VRAX/WqKFTffjhvHCaxcZyZ41jvY4uwjBM93RWP V80cr07p9B5fBUZwGiN94lAUN93Y+ty93+tzAwTBbUfUVjO6+OH9BdUeZLJF78yr16fL AAjxszCLO4bWCAWoR8Eqqj3ZCkKYYA1CoYOzlYRLB4v8gfVATu2fb/d1vBq85cMVOTm+ 2EVU1O51MQuGG9Uta7gzV1+jbaPeAnFAqOccfB13h78MFCI2i77WlPz1+4Bjc3TNMpN5 3W1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u18si1119139plq.311.2019.07.19.13.04.07; Fri, 19 Jul 2019 13:04:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731474AbfGSUEG (ORCPT + 29 others); Fri, 19 Jul 2019 16:04:06 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:40099 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727497AbfGSUEF (ORCPT ); Fri, 19 Jul 2019 16:04:05 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPA (Nemesis) id 1Mnqfc-1iCLCN0wWI-00pPiL; Fri, 19 Jul 2019 22:03:53 +0200 From: Arnd Bergmann To: Andrew Morton Cc: Qian Cai , Mark Brown , Andrey Konovalov , Arnd Bergmann , Andrey Ryabinin , Vasily Gorbik , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: [PATCH] [v2] kasan: remove clang version check for KASAN_STACK Date: Fri, 19 Jul 2019 22:03:31 +0200 Message-Id: <20190719200347.2596375-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:J27HTozIf70i015ShzVyaLK+SKYj6oJakqgt/Py0qVMEmYfLKM9 j+FkpX8855SdCqSKs2wi92QbC7o3aqLQvNgxq/xx3R4aCeH08w0VqtGpX4T4EbPISZX3OY8 lSD+dj8qNlT3hfFZ7Ze1B3V3BzTo+QpxirpCVkZFyZHc38Mgnxb3kuu0/Nm4Jl7iwDFYLn9 qTVJIZwC5u7uUNp+jafJg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:/juMIMxIzxg=:iBIGzTzUSBL3xedoNlYaaG r5RefbUKXEHUEznMmsDzgDixJeDDy8cqrsL8mAg3tcJcc3zh6+dXKofFk3QOuXU4WNhIDkpfA HCJNRAiZKQM/Mjt9Vtag9p/URnIYCexJFgDYI1A111rD2WWRZqF2CyEfmixCGkRLHJZ2f6Sly +VFbLt/cQWHNholtFUY2zfUJFgfgohkx0QNniwURsZyx2y5pjvYiL6NFzXG3sbcP11U6nSpya 31MqUYh4A90SOiuyIZsyt9U8s+eMvlN8XgwjYXRwnHRXfjZIAWnBK/mr7NrDdjfkqqbmLp7OV tyNpGhwzjQfL9iRO6D1fD2dGRWSkTFhHisONWCazKwYNvsSD+9k7aY4QOWu/S0C+75Gks/hxY eAAdofAgm2J1FCmaPV7LBsQTmUDl9C/DKAMhQYIVkHvBaSQ7NhQ4vmzxDhome5y3B8AyvKrB6 wcyYzIwUCwBFSG0QCXRdrBi81uAAf6bkO1lkLmeQjVS7qQIMNSTelqOCeFRtmda1pI76nMJR7 +84sLsqgphb/1NyJOxpCD9Dr+BnM9MyvCob2rKhm9Eg9/N8U2WVU7FraS8mlJUI9XLBNC6Pos 4ABN9E13YYMcPfoBnVSzuUXhBXJTb2xdUwqJqtrVMUhEb40S/exUSunDA7c+R45pd6t/m108q naN/0db8NEDKpWK//bMM/+x8kNKCnq0uMXTVBi/0FNrRUNzVe9GW9kyucdWlu0JUZVbkRvUj8 +KsUe3idCPE7mg6SMPa1lCVGzx9N1L9faXM6kw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org asan-stack mode still uses dangerously large kernel stacks of tens of kilobytes in some drivers, and it does not seem that anyone is working on the clang bug. Turn it off for all clang versions to prevent users from accidentally enabling it once they update to clang-9, and to help automated build testing with clang-9. Link: https://bugs.llvm.org/show_bug.cgi?id=38809 Fixes: 6baec880d7a5 ("kasan: turn off asan-stack for clang-8 and earlier") Signed-off-by: Arnd Bergmann --- v2: disable the feature for all clang versions, not just 9 and below. --- lib/Kconfig.kasan | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) -- 2.20.0 Acked-by: Nick Desaulniers Reviewed-by: Andrey Ryabinin Reviewed-by: Mark Brown diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan index 4fafba1a923b..7fa97a8b5717 100644 --- a/lib/Kconfig.kasan +++ b/lib/Kconfig.kasan @@ -106,7 +106,6 @@ endchoice config KASAN_STACK_ENABLE bool "Enable stack instrumentation (unsafe)" if CC_IS_CLANG && !COMPILE_TEST - default !(CLANG_VERSION < 90000) depends on KASAN help The LLVM stack address sanitizer has a know problem that @@ -115,11 +114,11 @@ config KASAN_STACK_ENABLE Disabling asan-stack makes it safe to run kernels build with clang-8 with KASAN enabled, though it loses some of the functionality. - This feature is always disabled when compile-testing with clang-8 - or earlier to avoid cluttering the output in stack overflow - warnings, but clang-8 users can still enable it for builds without - CONFIG_COMPILE_TEST. On gcc and later clang versions it is - assumed to always be safe to use and enabled by default. + This feature is always disabled when compile-testing with clang + to avoid cluttering the output in stack overflow warnings, + but clang users can still enable it for builds without + CONFIG_COMPILE_TEST. On gcc it is assumed to always be safe + to use and enabled by default. config KASAN_STACK int