From patchwork Tue Jun 18 11:22:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 167141 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp4083535ilk; Tue, 18 Jun 2019 04:22:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqw5JL1h1NH+QF5QRVktfsRxZlkaf3SQd8bxGNLSzybIXbG7cjyVIYUyFi/lDruhfEwKacTC X-Received: by 2002:a17:902:7297:: with SMTP id d23mr100097270pll.254.1560856965161; Tue, 18 Jun 2019 04:22:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560856965; cv=none; d=google.com; s=arc-20160816; b=m7zfuntIqL01u7zOd4Srk3R4wM8JRsPj/dxghkNgnC6Vp4PZZLdGurgKT4MQhvgJ9d w2b05pHOtmoELCCmK+6f5EA8+9wfy/2O9dcstGoHUybmxlBSDR8FCovygUye6eS03wKv Q4KHuGIvZZT1A9l5NX7whMhkJIt3na+HB0nB+d+Pw/AfnmV++y1sBqIT/cHKqcTA9YCQ rfKa1iXcWa6IB5vWtCdhQcJaX/KcEsqK9HK3KN18JlX1+WJ2KwWlYqTq2WUaIpZ69AmE t21+acAUAZDcm26xgLRTEZQ5+RpN9Mm378OmsGB9yzlo/65PiO1NBAmRVLzPFvDtXNZt oTvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=NPuzMCNRa/ZjytKQ9z7yNEbo2vYYOHafRZ4wvD1tbn8=; b=GshpvK/UstCkCTpe2xGYa2s2lMlkMA1PIN8Q1AZiHPR6yOF6WrL3smFQsGjG+l56zj K1nBQlPnfBWz3iSA2AzkijsYgL/3Eep0jRx0FKKAG58PeMq6yrhn0MdRxD5ZQ0cNEOgd o9URR/yOhZII8ZpLDz7f+8GLl4KwTUenCGlpHXVClqXtP58eqglS+ucHu4KLFStU9RpT JZ0KiFaydLt6nLDdu7vUKwB4S81sVz7iTET/XAN4l+0djaxw+/Z1yRezLgaZOC1GzEEN QTXgAcpsUSDCZdaqmVuXR8msJZJk+QJvtrTUh0+yenVBL0zK260IvaJkzZJrGZhoKJOz DoTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j66si12533862plb.375.2019.06.18.04.22.44; Tue, 18 Jun 2019 04:22:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729664AbfFRLWn (ORCPT + 30 others); Tue, 18 Jun 2019 07:22:43 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:53727 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729110AbfFRLWm (ORCPT ); Tue, 18 Jun 2019 07:22:42 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPA (Nemesis) id 1M3D3N-1hcMiR2pDh-003bdJ; Tue, 18 Jun 2019 13:22:30 +0200 From: Arnd Bergmann To: Steffen Klassert , Herbert Xu , "David S. Miller" Cc: Arnd Bergmann , Florian Westphal , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [v2] ipsec: select crypto ciphers for xfrm_algo Date: Tue, 18 Jun 2019 13:22:13 +0200 Message-Id: <20190618112227.3322313-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:lw/hXW2vB3PxvLPFBjrfkYIPVf2yXaIQORIsqAOgDFhnL84DA4J dhVA4ckt++OIzSK04xeN0mEfdNrwclg6nZVM/LfQRR/IVWV6eh+enRiuzT2Nc9Rkw5HpaLH D3LvW31viw6IbVRcHXwmWTYpE5k8cnUdBPw4R1KmbiJUzXIWv3q1jKmKUa2FVrBlxv9tCTP 8Wj4xP6RLMsSl0CMVjHbQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:m/LZHXpwX90=:mFZxy/qdnw7gHjPsjoAtgb r6ENAoh5kpgj/Qwhf9FP/iop2ulo7mBq/tIZbXccWcXekIqWXLyyyddTVMvs1/3VdOWhnfZai DeIYmQm02WQku3i+E4KeAVKWIlS3sM8tfW1W7SWH3k0gsVhq14VFxPN2ZQ2n0pC7BhgQYx9zk ADiBjsnpNtcGLXQutUWveCLHm9Cjy1K6jfPRYmIIYMNIBzUl+m/oQLiinqmY9Nfq5FYZstdi+ 4JwfeSmW7Nmc6uaNFyuejiUKHikaWybcyRQFgW15/X34RVE15I9BF9MfT79lu8wIx2ZsjeXT9 bOtOzKiuJGTPEz68rDy8xLeljcb2+XGmRpNATWFr+KDUZ9gF8FvYEtfX9cMCabs1FMEHTcBv+ XVwa9vvS1sRrG5AC9xqO1WA6pRLAgA2Hcnua52mP8v24sn0KWOG+j6+aROydGKMWRpW/SoopL fiXE9JrY8kHH+m3RAT4fC13cVJnnimUbXYvqnB05WVVVVY3w1oVU+ki6OkUrWUse3ZB4igCrc C/38/Mqpuk/J2kPwuL8crdpeirfeg6Wa7EAaSS9FjsJUMdcH4/OzFkbS4mCrQfD0H6K2E44ih CTeBTGIcXUs6qdaPHfPC7L9gQt+fjoVJ0zV1kwlQ8ZOsYHAXLc0nk8OtRGNoggKgx7rCF9uNG Orciti3i/Z3wM2OCJr2pZUL01osHobaTROAdrCbWoEN8MZ++Fo12pnArQ1xBDUaKlBXiaogvi +TIU8WOq8OTq88Wogw5P1gvmfF+ZjRzqLFWcCg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kernelci.org reports failed builds on arc because of what looks like an old missed 'select' statement: net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs': xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash' I don't see this in randconfig builds on other architectures, but it's fairly clear we want to select the hash code for it, like we do for all its other users. As Herbert points out, CRYPTO_BLKCIPHER is also required even though it has not popped up in build tests. Fixes: 17bc19702221 ("ipsec: Use skcipher and ahash when probing algorithms") Signed-off-by: Arnd Bergmann --- net/xfrm/Kconfig | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.0 Acked-by: Herbert Xu diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig index c967fc3c38c8..51bb6018f3bf 100644 --- a/net/xfrm/Kconfig +++ b/net/xfrm/Kconfig @@ -15,6 +15,8 @@ config XFRM_ALGO tristate select XFRM select CRYPTO + select CRYPTO_HASH + select CRYPTO_BLKCIPHER if INET config XFRM_USER