From patchwork Mon Jun 17 13:13:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 167029 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp2850184ilk; Mon, 17 Jun 2019 06:13:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqx5hiHbWzudeJeA7VHxKwEnZQyiO+tabiiMVbg8mSFml7wLu3HJ/VlUXTkjFnkt7zTezSms X-Received: by 2002:a17:90a:7146:: with SMTP id g6mr26063364pjs.45.1560777237914; Mon, 17 Jun 2019 06:13:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560777237; cv=none; d=google.com; s=arc-20160816; b=wC2/3nHAwmuYKmAlqjzruuWGi5sffcsnbifozUH+TDfmK3O1SZNOEOEUdI5rhmKY9f Lp2PJEvQ1/SeUmvRUqDv7AJnsUayZvF5W1zwZkn2r4zDygOM/aYHxFiq0FQdT4el9Brr CZLLRlm8087m2vyP9bZOTlWItSUgSPSzvjSr7eemsvxM6kkYEp403v/GSCxF/caEd2cy /ZBHfNzKjI3uYfMAMDxlqXZLuxeg7TsDQgN2gTg+o9pOVsH3uzmZeCGsMOai3zEg8vSP LIvXMBEmpsKqNqxLgL4rx1NA2sTWRepCSWnyPy7WYSvQLvRJFZcJ/VzaZUqt8fP/k691 nZcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=hJbJgYkx8xwRvkr4ydiJx3ad9WtajiMKgxMZr5iaUZQ=; b=rf3WsOZsqW9A/7QvBZcP1dBHjKI3pZJSk2ZFt8bd+OqkClrwqnJJCNxrgU0qJ2Qh2U i6LsEUCmx4i38d4z3ixj8lcO63PmfcmA+LLJHfNuJgvpGLwWWSBHrpwNgGJCRbWwxPfl da+ucgh/n6Pc8LPFcGuC0RaaRJM72tfAzA7mxVJgmc9YzwOnSqY7cEinlyH5ZCEVSTf5 bQFp6alJolrvoIDUNV10y/VlxXWvWxxiUNW4GcrV0+P8QxCw+pFSs8ft4rTHjtG0Tw4v zMymaUn7EmTPGfdMyxPNm0ZRWffDhF47aEEVNspsow8upBnlZNAfdxcDlAziTi1d5bqp mfDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t8si10890799pgn.112.2019.06.17.06.13.57; Mon, 17 Jun 2019 06:13:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727947AbfFQNN4 (ORCPT + 27 others); Mon, 17 Jun 2019 09:13:56 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:45927 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725884AbfFQNNz (ORCPT ); Mon, 17 Jun 2019 09:13:55 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPA (Nemesis) id 1MNOZO-1i0ZUq1BHO-00OktR; Mon, 17 Jun 2019 15:13:34 +0200 From: Arnd Bergmann To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin Cc: Arnd Bergmann , Joao Pinto , Russell King , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Aaro Koskinen , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next] net: stmmac: fix unused-variable warning Date: Mon, 17 Jun 2019 15:13:03 +0200 Message-Id: <20190617131327.2227754-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:3iQswqHwy9CHF3y1gp7c7xlBW7MRNJ6Fv/0O9bUwjPHV/LWGdIh Sg9soT5vhpPfNJhxJsqwCgkwuTEe0AEIYCVllZ3t2UQIugkzeIa/1LuEaIZUloY3QurmxNh gczDmibxxnKXOGvclLvdFNkq77keyFmY3/wMG0JJpWlQyapLFJEW43ks+VIlxcOEDqSZwS3 OARaUsIkb9o2x/pv8mmcw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:3iQy2mN8gLw=:a/aWCEZLxeIcdIwAmPzzUe xGLtrdS/+m+HkJbvQmw4YCcKRq+jjVA4Wtn+HPWhql6rNXFI2OSAEXwdCkt4iIvUgoATCu+57 GS0GebKolVJMtTG0QEJlFFsIjyGO8m59rwwITRlcQggasDrAK8+rvAmkj0zXDQxH5nOcB/2WQ G9c81RQTG3axlhsfWamWceqs0YzM6AfyfS3NtMZWZ3xgTJhILdLuladwA70p/S8/0BnTTu3sS KgBZQkXn8EU9dMZSuJhwKGITr+O3U2A0GJnFezlKJmwLcpxABgMy2XseUoS8lYpD+HStwu7MN v5Lok7Nv1fo/vD0OPBH7p0XLNlDiRb1rfN2ouloulgNBCsKnL1A9bJ7n6UpOo1exVphGK8Tif hYs9W9CfOJzSMWLFoQd0w0JnNBjPYpaoLYfaQRueJ/d42aHeDlXu2KS4QfKp2aOaCDW2nGk42 CFtLQrArAaoKywY3KbXVgonhi/2dFRFUch79pGpZBX+eX4KT4Qv7sLcRKGltK3ZYuIrvYIC6o 4SMRIX3QMKVrsFsdr2IW+8d7+BwLB51x/8nuP82jiswqd2ExGYd0lujY7KUV5oRMDq3y/hipa jmjMn/gFYzIcsNHaLFxdR3Pi5aP/QyWpVbZW8FWNTZXLu8QxuM21jnQBn+UAns6Q8ZT5GRUgK PMho0FQJnlISs1mGsxCqrIbfXVdpNqvbxqe46DKNwVH93SXxuPwMlpfFho+kgiQ8xftV+c7+/ PlChMgjnn4hc9Nlo2a5n9L+84eTAkFLeiaSmdA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When building without CONFIG_OF, we get a harmless build warning: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_phy_setup': drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:973:22: error: unused variable 'node' [-Werror=unused-variable] struct device_node *node = priv->plat->phy_node; Reword it so we always use the local variable, by making it the fwnode pointer instead of the device_node. Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove phylib logic") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.20.0 diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 4ca46289a742..a48751989fa6 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -970,14 +970,14 @@ static int stmmac_init_phy(struct net_device *dev) static int stmmac_phy_setup(struct stmmac_priv *priv) { - struct device_node *node = priv->plat->phylink_node; + struct fwnode_handle *fwnode = of_fwnode_handle(priv->plat->phylink_node); int mode = priv->plat->interface; struct phylink *phylink; priv->phylink_config.dev = &priv->dev->dev; priv->phylink_config.type = PHYLINK_NETDEV; - phylink = phylink_create(&priv->phylink_config, of_fwnode_handle(node), + phylink = phylink_create(&priv->phylink_config, fwnode, mode, &stmmac_phylink_mac_ops); if (IS_ERR(phylink)) return PTR_ERR(phylink);