From patchwork Sun Jun 9 16:42:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 166233 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp56801ilk; Sun, 9 Jun 2019 09:53:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqy1H9xeLQoCcYMMnGFl6ttaHwC6Es8jT02gyqaDsk5ErMrkgSFOkhk1rmY8WAG0SOpxxSiD X-Received: by 2002:a62:1dd0:: with SMTP id d199mr17517249pfd.257.1560099187166; Sun, 09 Jun 2019 09:53:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560099187; cv=none; d=google.com; s=arc-20160816; b=D/H/us+Tfimy+IvfY+k0p71Eeoe8JJjK72NI90ZnrUUrhBk3hu8apaIcXPcu5oP80h nFXx2/fuU49v6Ojbbc2scRULnyUnYzqo7kINhFkee18aHvWwW8dVPsVfR6YBAm/cBhL1 r2wrCs3n4qWeR5YToTAwZ6G974yti8NlkZ20wuX8j7ixe7soJDveAx4YdkeETKBQT2LT fcvq8edHkEP8SlxBl01qEscayVQ9M6Vn/QqDkYKJgn902NP/C/I8u9ooJsFOz1vx4txN ZqSK6XBx1BRPUeazddRz1wWiCWc3YZPT2gxMfxxJ3IeTcWODeNN/n5Amodybh11gAhG7 KHCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=w7c0uN89M1txJb4p63sZ5NNeE5b4c28B+NR33o4WlFE=; b=BJu7c89dXFXXts7Qx9U/ehW9VxOrBC5bU2k7yTEXJCOtFjIWzCPsyGhJMobvDQS8tC SCTshx/zzAyiRJ4X65z31jrU+tW/x9YgIF0VF463lqvYzZVq5nA+fKrdlEeXGxPg8Thi bFsOuFSXRxQgGFoO9ho6ndedpo77uxtpKkC4SmsEKiyUQ8p4YSs0JvJJv1c194zawP9l QxKR5QPMFMAnWSYGap6M3928Q4QV07A2iDGac3M5rgE2PKRCos1tzalCoQPaIrZ4LHaf c0oS2zjhxCng7peLXAwc55/LAUDyPQQLAulBReVpUKFtz2yBPBTjoRDGjsfLx53sK0B5 smZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zWfWQ4eM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b38si4444147pla.137.2019.06.09.09.53.06; Sun, 09 Jun 2019 09:53:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zWfWQ4eM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732346AbfFIQxG (ORCPT + 30 others); Sun, 9 Jun 2019 12:53:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:54154 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732333AbfFIQxD (ORCPT ); Sun, 9 Jun 2019 12:53:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 58DC8204EC; Sun, 9 Jun 2019 16:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560099182; bh=op1gChslQGxNPa936LUqZEqpWuej5GsHZdQxDraDVkw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zWfWQ4eMhjWLSEWUtqE13N30Z8F8+oZ8Z/ZCTEK0xkyDthClvEofe+dHyPGtnNPdn PMOeVr6q/xZyq1n6rTksjBcM48wipe6prYfano6O4A4kVSN0lDcGxPr0XC+kyX+yma nuGHR4UD5kfRXqeJNNa4V1+LGtuHwaHWoUUQKYLw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jorge Ramirez-Ortiz , Bjorn Andersson , Stephen Boyd Subject: [PATCH 4.9 40/83] tty: serial: msm_serial: Fix XON/XOFF Date: Sun, 9 Jun 2019 18:42:10 +0200 Message-Id: <20190609164131.277962861@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190609164127.843327870@linuxfoundation.org> References: <20190609164127.843327870@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jorge Ramirez-Ortiz commit 61c0e37950b88bad590056286c1d766b1f167f4e upstream. When the tty layer requests the uart to throttle, the current code executing in msm_serial will trigger "Bad mode in Error Handler" and generate an invalid stack frame in pstore before rebooting (that is if pstore is indeed configured: otherwise the user shall just notice a reboot with no further information dumped to the console). This patch replaces the PIO byte accessor with the word accessor already used in PIO mode. Fixes: 68252424a7c7 ("tty: serial: msm: Support big-endian CPUs") Cc: stable@vger.kernel.org Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bjorn Andersson Reviewed-by: Stephen Boyd Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/msm_serial.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/tty/serial/msm_serial.c +++ b/drivers/tty/serial/msm_serial.c @@ -868,6 +868,7 @@ static void msm_handle_tx(struct uart_po struct circ_buf *xmit = &msm_port->uart.state->xmit; struct msm_dma *dma = &msm_port->tx_dma; unsigned int pio_count, dma_count, dma_min; + char buf[4] = { 0 }; void __iomem *tf; int err = 0; @@ -877,10 +878,12 @@ static void msm_handle_tx(struct uart_po else tf = port->membase + UART_TF; + buf[0] = port->x_char; + if (msm_port->is_uartdm) msm_reset_dm_count(port, 1); - iowrite8_rep(tf, &port->x_char, 1); + iowrite32_rep(tf, buf, 1); port->icount.tx++; port->x_char = 0; return;