From patchwork Wed May 15 04:37:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 164260 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp285108ili; Tue, 14 May 2019 21:39:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqyMdmWq6zFefsJ9tz763DrcVfegYnmJOuDf5kRlKb110OdeCAH/zrz6kElOnDZ93+YM/87o X-Received: by 2002:a62:7d10:: with SMTP id y16mr45037455pfc.116.1557895191184; Tue, 14 May 2019 21:39:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557895191; cv=none; d=google.com; s=arc-20160816; b=hmQ2KT3U9vIHWaQPFPAhCzRKsGfjzLxLy/FPTc+Xy4+xR8eTBJGoSE2lfRZziLiFW4 MQkFtAV9bH/9i+QkCd8RtxEUE2yF+OUkMlCa8JJrh5nPdBqnIov2aa3qZsJqulVocddh R0HKmpB1MO5YTxKPvifgoxK+hZj8qc108HrAowRbpXS28WGKLSu+LtGWV6bLCiyKteOH FaiRuGX+2ucw+11XHU6O7QEpx6QFI43dt63tWdA+x9Gp6gIvcv+12A1f1lsmBaOO2xro PYDjsn90ryuC2WP4oaW1TJer+lv1dJOANTLljWfSGadCkGE9emJXJyhs+EdzxIesXOmb zRYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=iE+vnhBUmohMYwyQNvfDgRKTtO/iv446MrZ818sQrfg=; b=pSEwf+5ZaX59OfSVmNNs7+YrWPDdQvggm+ArqUp6dwOPK0WvYlX0mcPxXG2ynkd6cx b8ZlmFi0aUnPBXGH3xMApQ8ucOs6mxKIAp0Fsnrgn1/FTRxsXclgDXmCJ/tcf+HehH8b vOKC3IcZ4EFtyl3q9e1eXVMa3Marp3KOycjsxYK4CyqxX2LdConAehpgqUWJZZhoj5Ei y1XCpFGBRIifKtrYwvB7Old7YC7U9n56d025pb7RbvKg3jJozOmyGtWz72f/lWPdVeDK NjkOdUwuP6J6pDzBAxjszGkq/s2MhgibopALKiGrSf98GlRlDqhyI7sCREfyGeMtgGBV cBWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=R0deHWNC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k7si855469pgm.302.2019.05.14.21.39.50; Tue, 14 May 2019 21:39:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=R0deHWNC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbfEOEjq (ORCPT + 30 others); Wed, 15 May 2019 00:39:46 -0400 Received: from conuserg-08.nifty.com ([210.131.2.75]:24238 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbfEOEjq (ORCPT ); Wed, 15 May 2019 00:39:46 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-08.nifty.com with ESMTP id x4F4c7cJ027504; Wed, 15 May 2019 13:38:08 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com x4F4c7cJ027504 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1557895089; bh=iE+vnhBUmohMYwyQNvfDgRKTtO/iv446MrZ818sQrfg=; h=From:To:Cc:Subject:Date:From; b=R0deHWNCr8I/DXB/MhqjIvColCojk6Y7goEygOJC5ejAgxWyLBiiPJOm//+HtBCl1 TjVp4QFaqbx0jr0j8pdIpfN10N1/XiIo4+rQOcgPEZlhuB6ScN0FWtKWmCGfODSMoB gZUg7rz2k0/wDpxuUF9Ucwj0+uo1jc7NunXGXLr55iAaYqVIbnbLbG8wuGXq2pEIe8 6Bn1EJIrazZmarw8BcPdSQhJD0EYinFIQZ1S8rH+g3nSImYLnspcC7I+8HlvDXsQHW oLolUTueapGrO3nEa+E/Ha1/M4EjRrGgDSeN4u8Yxpmec/vqseQ60PMsbvukstYryd Y8m+89dOpKZUg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org Cc: Dave Airlie , Sam Ravnborg , Masahiro Yamada , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter Subject: [PATCH] drm/i915: drop unneeded -Wall addition Date: Wed, 15 May 2019 13:37:53 +0900 Message-Id: <20190515043753.9853-1-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The top level Makefile adds -Wall globally: KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \ I see two "-Wall" added for compiling under drivers/gpu/drm/i915/. Signed-off-by: Masahiro Yamada --- BTW, I have a question in the comment: "Note the danger in using -Wall -Wextra is that when CI updates gcc we will most likely get a sudden build breakage... Hopefully we will fix new warnings before CI updates!" Enabling whatever warning options does not cause build breakage. -Werror does. So, I think the correct statement is: "Note the danger in using -Werror is that when CI updates gcc we ... ^^^^^^^ drivers/gpu/drm/i915/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index fbcb0904f4a8..4a4f60c7edfc 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -12,7 +12,7 @@ # Note the danger in using -Wall -Wextra is that when CI updates gcc we # will most likely get a sudden build breakage... Hopefully we will fix # new warnings before CI updates! -subdir-ccflags-y := -Wall -Wextra +subdir-ccflags-y := -Wextra subdir-ccflags-y += $(call cc-disable-warning, unused-parameter) subdir-ccflags-y += $(call cc-disable-warning, type-limits) subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers)