From patchwork Tue Apr 30 11:38:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 163105 Delivered-To: patch@linaro.org Received: by 2002:a92:7e86:0:0:0:0:0 with SMTP id q6csp3118827ill; Tue, 30 Apr 2019 04:49:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqxnh8tWzt2bINcKAz6dtvjV1CU21T0tJR0WV7WD6HR0fbnYEN/vywkt0d65DmDLm8gSNsyT X-Received: by 2002:a17:902:9a48:: with SMTP id x8mr21722393plv.133.1556624996382; Tue, 30 Apr 2019 04:49:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556624996; cv=none; d=google.com; s=arc-20160816; b=vdI4Q+Lg2AzipI2Yy0LMLDKxBiykF2caOpwBPRe5Em69FLJuWfMpe96erWJUT6cE7m v9yktn7FULbkLCsTnWzTAulnlfi05/zSs2cLTU3OrywQSz0IytwMFgIdizf8ol2cpvV5 kjomtVgtNU8rQ1ttcFXd4bsEXTyml94shDaW0x2PXn6cCxzNyV2iluoPWUxqaxXcQhTF fMtz0B8WWTds3mJhYSkLoHAboZWkvEi/vkyoeMz/Hahn6WQ9lABuAkPbFF++jTpRftFA I1V6DPwSM/1B1ToEfFl5k9N9c3ncO14SNmAOW8EyFRp2t9QQLz9lB4RB/anahlhYhywV ESpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ot9GoE7PN3Xcsagv3xwuybkfXyuAjhkc1TmwYKFneSY=; b=rnh0fzxm3C5xjvb0w4Ij/H5f5iSzFrzpZNCfHiDNMgKCrn94s0lwwTCNqd0oxzSFks 4XIsK4ONA8gV2+yY+RzZi7iDY2xqu3GmNw5YZwjUBQ3clEgKWC8vymzUd0CWaSny55fZ pbGHWr2I0cjzOXTsxCKGKkqv51Wt92egcgaVpUFFqOO7aFVrsomKTrxzHMjfQWqeBklG Fzk1tvSxSWINSPwGmP3vXcGon5Q05hVKKaQEbbockxvs9OOZ7J4/KZAnSDlqXQ8edVTA If51N+UP7e6xNswWoVSmWZ1pRUuNibyU6EvKxzBcTt8z8Wkrz8yw+sapakjfh+xaO96X 7s5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yekqfFra; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l3si34122056pgj.136.2019.04.30.04.49.56; Tue, 30 Apr 2019 04:49:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yekqfFra; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731087AbfD3Lty (ORCPT + 30 others); Tue, 30 Apr 2019 07:49:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:36510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731078AbfD3Ltw (ORCPT ); Tue, 30 Apr 2019 07:49:52 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D2BF2173E; Tue, 30 Apr 2019 11:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556624991; bh=TsZdpmCy1pcPB5gfC6C686aDfKiW4WLiHwcWOX4x58w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yekqfFra68Hqp5thEvG9aDcnnJAEhjuGjn4ZAIY3jp5txFBQtelGuaBdm9Z4mCWuu +66MSHflMMj1n5LFfe22fw/c3Qn1zrcpHA8oB5OkGdaE+Iy4aSSt+wOnE8fdEy5uYB Egl9lrtqt0D1f2kLIRd7G2cPxYG8kMPWGua9hsmQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Baolin Wang , Linus Walleij Subject: [PATCH 5.0 15/89] gpio: eic: sprd: Fix incorrect irq type setting for the sync EIC Date: Tue, 30 Apr 2019 13:38:06 +0200 Message-Id: <20190430113610.404625881@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190430113609.741196396@linuxfoundation.org> References: <20190430113609.741196396@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Baolin Wang commit 102bbe34b31c9159e714432afd64458f6f3876d7 upstream. When setting sync EIC as IRQ_TYPE_EDGE_BOTH type, we missed to set the SPRD_EIC_SYNC_INTMODE register to 0, which means detecting edge signals. Thus this patch fixes the issue. Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support") Cc: Signed-off-by: Baolin Wang Signed-off-by: Linus Walleij Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpio-eic-sprd.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpio/gpio-eic-sprd.c +++ b/drivers/gpio/gpio-eic-sprd.c @@ -414,6 +414,7 @@ static int sprd_eic_irq_set_type(struct irq_set_handler_locked(data, handle_edge_irq); break; case IRQ_TYPE_EDGE_BOTH: + sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0); sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 1); irq_set_handler_locked(data, handle_edge_irq); break;