From patchwork Thu Apr 25 19:52:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 162887 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp2364387jan; Thu, 25 Apr 2019 12:55:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqyyveTtbdtqpgdSQWt+AnnCr/l4+70l0IC1GauLQVTumuv9/ORh+08r8Om6e7w/J+nimvP9 X-Received: by 2002:a63:4721:: with SMTP id u33mr9125511pga.199.1556222151635; Thu, 25 Apr 2019 12:55:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556222151; cv=none; d=google.com; s=arc-20160816; b=LV1VX1yf7kKfd1XUA/N6IYFhcrdfjE5i8wpGT40P0PL+OJJdGaljW1uHAag7F4PTL/ f/d7/yVbqToiRc4Dce0H2UYT/iM3cG4aNEmRoc5TjFpSCF6qtKMOCY56wZT1AdQcGnyT VI0qXqrP9lnOw3bNIRdAzgaBQF3TvDFUnVt/ZrcEw/fM8m6+wfM9oxxY3QXHHoVBVwV3 MdUznuzx3XNGQGXC/Ha80pkO+PVSthv+JDd2CIlcZYQoW2oj2mhrQWADref6XNF4vUw3 7aeeMGgI3FWmJuH7xq9l7evtl9uA2lQwOv3V4GB2NcU9j/w1zC/16B4aY0QO8siZUSQt BLMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=+iu5H/2lxwy+6+UhJlntqHJob3sHa1BeLPUZsfgVglo=; b=KZkmS0TUx0KKYOZwgnm0prdfnRs2EXsxFpUplc30ZqmbFcksFtyHFEgpC0sb4I2JJF JQx+HbexBKxFMjmyy16JXfC1WJsMgS6JmeWpUrADnbupU6Ph2kv/aDKFWDN2Th29pEKR ix6qL00aM1qqgQ3iWPGxv0XsrQR7aPv6pWqee4b46mIWwsK6PZ7LzglX+V72cufGIk5q FWbMsuZxJDvMaag092SIkAx0AZIj0EyKdcqDJb+TmYWVjmVNG+zwU4nNawtBd5cJCciK 4JGSpLt99TQeBSZBw0aB236QI0q38lfTYH5IQW28PK6mGwUxER3qk453Rf1HZ1vf38iv 0/xQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OkbArDe8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m184si4673024pfb.166.2019.04.25.12.55.51; Thu, 25 Apr 2019 12:55:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OkbArDe8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730779AbfDYTzu (ORCPT + 30 others); Thu, 25 Apr 2019 15:55:50 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:33136 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387598AbfDYTxX (ORCPT ); Thu, 25 Apr 2019 15:53:23 -0400 Received: by mail-pg1-f194.google.com with SMTP id k19so381445pgh.0 for ; Thu, 25 Apr 2019 12:53:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+iu5H/2lxwy+6+UhJlntqHJob3sHa1BeLPUZsfgVglo=; b=OkbArDe8GBSK+syoZHtEW2nXOo3TYWnR5IbxVJcqvp+Hu/YpFDAumLmf4Qk//W7DOb 7Uf2F/QIJTC+nW7UUCl7WES5yrYW42dwVhCLv4B27nhIxpf+RLF9XtgJs2fdC5H1epBt mjjHhXmdj3H1Y5RYWEmX/2MDlJJ8rT5L04+CoipKvEOiz94bX8YXRnsTYteG0TTR9gT/ 7NhoKJGE9qZVvjogVrw1qHaufofv1YONl7m4oOrnP8lgWaek5+uzewS5RPWdSS7Gw3Yl mdqNhmgREYO5J2OtOOhFngP82YT+1b/WXHk7gQLu84pK0mrhXsHAHFi8uuo5Tl4n0UyZ iBqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+iu5H/2lxwy+6+UhJlntqHJob3sHa1BeLPUZsfgVglo=; b=DT5+o0l62A3r/ghYSKMGvjHw5GxQ1ovq83EL+xPrP8IJYW/dZi/AiiJc2Z5MTodEWN 6cv9ffAIvSRegKMDrAa9llSqFtmXrD7NLGiNC8FxxU/yTy7CWiqkvfMWvkaam7m79DpP 4rY7XnP+f/zkL0ykmgty0dWwUR3kbw8fhyagKmTZrhn9kbJRp8Z5u8VoiiQ4bU2rKnAv cXAUVEmvXJfy04lwP8uf0ETsBtJgw923TzTOxCvLeGbTivJixqyWbn01pfYViILXRbRg DJKoQjZcDJ+dTgzynd+QC2MECclvIgpF56YmaYe3T6JxW0I9+6kKRssGBergf/E/ZS0p WnkA== X-Gm-Message-State: APjAAAVdXFyc7nKMOjwLD/jU5QM4PS4V3hM1C6fyGHylRMckNCOAjZPC JfcfMPHJ+TX8HtD95tXcwHKCYQ== X-Received: by 2002:a62:1d0d:: with SMTP id d13mr42334756pfd.96.1556222002731; Thu, 25 Apr 2019 12:53:22 -0700 (PDT) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id t64sm47261961pfa.86.2019.04.25.12.53.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Apr 2019 12:53:21 -0700 (PDT) From: Mathieu Poirier To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/32] coresight: Fix freeing up the coresight connections Date: Thu, 25 Apr 2019 13:52:46 -0600 Message-Id: <20190425195310.31562-9-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190425195310.31562-1-mathieu.poirier@linaro.org> References: <20190425195310.31562-1-mathieu.poirier@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suzuki K Poulose With commit c2c729415b2d2132 ("coresight: platform: Cleanup coresight connection handling"), we switched to re-using coresight_connections for the coresight_device. However, that introduced a mismatch in the alloc/free of the connections. The allocation is made using devm_*, while we use kfree() to release the memory when a device is released (even though we don't support this at the moment). Fix this by leaving it to the automatic freeing of the memory. Fixes: c2c729415b2d2132 ("coresight: platform: Cleanup coresight connection handling") Cc: Mathieu Poirier Signed-off-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight.c | 1 - 1 file changed, 1 deletion(-) -- 2.17.1 diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c index 29cef898afba..55204dd47479 100644 --- a/drivers/hwtracing/coresight/coresight.c +++ b/drivers/hwtracing/coresight/coresight.c @@ -973,7 +973,6 @@ static void coresight_device_release(struct device *dev) { struct coresight_device *csdev = to_coresight_device(dev); - kfree(csdev->conns); kfree(csdev->refcnt); kfree(csdev); }