From patchwork Thu Apr 25 19:52:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 162884 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp2364172jan; Thu, 25 Apr 2019 12:55:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqz7Py/UXYt37/5nROrcSt7sEurkUIfcwVtn2S25vXf/aL/NHdoJ1gAvazO62EmslgnC7x8I X-Received: by 2002:a62:3501:: with SMTP id c1mr18042292pfa.184.1556222137605; Thu, 25 Apr 2019 12:55:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556222137; cv=none; d=google.com; s=arc-20160816; b=fL9eOajPz1fPs6PtGEPXXqwQHXZZq+mL3DNYHcDkLQvxIFby99kCqK0QcdNXoRIgoM YQhJxlkv9Nt9OaTLWdeslG//9aSixYC6Tt4ofXo2W7aO9lAF9OT/6HsXWNHYYt7vDv8u w9kMEIAlaUJaIIjKscPoJXXgRP90/f0dmhpPd5XRX7FxNTSiD1sqEWjqqQzzDOvcH99X GLKLjecsGfB7JWgRavuyP24cCT7BFiB8WiOvfA16rYm5w6b2hhAYzjxjAIc8w3hOU8cd N7CNzmVj7SFR61r6YsxkD0PeYupIzQZVF1ygNcH8UjVx6e1GwAQ/wl7JKWwFSSBQgq6Q dHQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=jtvY10kYu/UgXuic20owCvhI/8GuPQmjFeAnMENcPb8=; b=FyAX1ZKpRs/kL6+kx0LmvefGPW6uXeNcxhOLzgeah3B1n43aKJgXSEObCv9fIl9uky pN5gh4ArtoI/ixMTkiWs6CIhSIpClTa5waRlzFwmVj9A64TWWSDVvqobNDksHk4eP2NC yswK67I0GkvkwOwGBHtGFSlVsU03yGU3OnzW3L1v7I+f9jgydyicUsFmrRA6O9GYWrSn 4TsQVIi3OQPxUa1jqUbQKkgin8pjX5Rx3JOtkW22BWVrNOwvMj49Ft0/wnbsn5vt0bSg Yu2kAM5EBf4gTlPJzUJQEQiXVZ4ONE0sdkYL7rTGfAOxbis9+S64HDzQPq/6/HOPtuy5 CUNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rhdWvw2W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p61si24142011plb.428.2019.04.25.12.55.37; Thu, 25 Apr 2019 12:55:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rhdWvw2W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387953AbfDYTzb (ORCPT + 30 others); Thu, 25 Apr 2019 15:55:31 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:46871 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387714AbfDYTx2 (ORCPT ); Thu, 25 Apr 2019 15:53:28 -0400 Received: by mail-pg1-f194.google.com with SMTP id n2so346731pgg.13 for ; Thu, 25 Apr 2019 12:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jtvY10kYu/UgXuic20owCvhI/8GuPQmjFeAnMENcPb8=; b=rhdWvw2WbI8ZwsgR9Ea2apCocBC3wDQ1cVKhXdexnzeN6Z+iKrfh7LE3/j40d4eiee TW+sKpplvu4XZtnIYooJkkk0Z6uQF3wB5LuIEZYY2Rbn998YaXwG1JXoNnJzMxiCRR2E VCLePDQHJEPx0fUO3LRMcO5XU12svsSixgpdgi7ZDdfvtXxUaAlKACO+Lk7gh9ETeIRl 0vt35jTtZctGIUjr+qkzs/MGpP+8yfQyG+oT0UbtE7qZ13QHxbL07/8RrUCTLQWyifFl jYsXOJul+akM6ocN3RQKS+IRspcM9G8zzuKhJhd/tg6V7pMc8Pr2d2y3t64yWKV/d2fP D4WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jtvY10kYu/UgXuic20owCvhI/8GuPQmjFeAnMENcPb8=; b=oCIbwcXt3mmu7TJ8cf36AfwBJi9cSsp1xGZOooajWHGXSfbJU0oxTjDQAlAO2T5AV+ p9MCH9tvJ0X9MUis3lWKkIzh7h0rOMF4Dq8/gQNPFJykDrlgBUVLR2O1u0DrfiJwbMFT 7Wyg/X9FW+CzJ2Q5nD9itzUUZNPLCszwbwsHTQ2ROTIt92ggo2GCkEwPsTktm+eCjgEG ERtiuJ5HPO2UdWmlzjspSag3U0KMHdn/sisrgmUg/fQVQQL80RHme6ePL0IVWKsnM/aA hibRZV2E2xRCDDSAImMfFH8MlupiI4NKmq3Bo1Ij2x/F4Ai6GrDXrAiOQ/12a1XN6lq0 HI9A== X-Gm-Message-State: APjAAAUJNtRSRxcOvrgzoSWVFJ3inRd6evI78HafLaEEKtLXnOL5ihgw Hsac01y3k5xrIMgkT2XhM7D9Sg== X-Received: by 2002:a63:115c:: with SMTP id 28mr39367291pgr.270.1556222007875; Thu, 25 Apr 2019 12:53:27 -0700 (PDT) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id t64sm47261961pfa.86.2019.04.25.12.53.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Apr 2019 12:53:27 -0700 (PDT) From: Mathieu Poirier To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/32] coresight: tmc: Cleanup power management Date: Thu, 25 Apr 2019 13:52:50 -0600 Message-Id: <20190425195310.31562-13-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190425195310.31562-1-mathieu.poirier@linaro.org> References: <20190425195310.31562-1-mathieu.poirier@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suzuki K Poulose Drop the power only if we were successful in probing the device. Cc: Mathieu Poirier Signed-off-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-tmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c index 647b6aa93554..c6a5462ebf27 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.c +++ b/drivers/hwtracing/coresight/coresight-tmc.c @@ -432,8 +432,6 @@ static int tmc_probe(struct amba_device *adev, const struct amba_id *id) drvdata->size = readl_relaxed(drvdata->base + TMC_RSZ) * 4; } - pm_runtime_put(&adev->dev); - desc.pdata = pdata; desc.dev = dev; desc.groups = coresight_tmc_groups; @@ -476,6 +474,8 @@ static int tmc_probe(struct amba_device *adev, const struct amba_id *id) ret = misc_register(&drvdata->miscdev); if (ret) coresight_unregister(drvdata->csdev); + else + pm_runtime_put(&adev->dev); out: return ret; }