From patchwork Wed Apr 17 20:43:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 162422 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp5955380jan; Wed, 17 Apr 2019 13:44:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqx34ns4uvdbFp+4lH70kbF+g02oMbjhDEcc6BsjgAIGMZj+WD9degUl4dvzxkMcDPKqxocJ X-Received: by 2002:a63:1d26:: with SMTP id d38mr78983813pgd.357.1555533856817; Wed, 17 Apr 2019 13:44:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555533856; cv=none; d=google.com; s=arc-20160816; b=djDUz9Ko/hZ25xaUa/a4p+rJwAkKqEvDNIsL+mChkYdcgDXa7wmN48T9yqqB5Jd6a9 d5iOBSPUKOy6VdmUy5jIoLWCdhvNPOiuuh4aYJDBu/8mJhyj+klWHZo0hq4hBU6BZAV8 CBUR17kNp4bREKBL9GiZ5Uux5ygZvuDhYUoffShwc3qKe2mOy7pcmjHemtSZbWTlVnP6 Lh/lgPfwQw+PnM7kHkY8w6z7ZcNJA4P7wolWtbPFkq/X06gFXz4JvdMkGkvTI5naoncW fNWNUyUrS5jxNc1Csy7Z3qsGxpyIQji0rCvPHMIT0F9VcNfI/XxvNnnQFArrERrythvp SeqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=w1pW48pbPFvZbhJkwoKxPVapl0Fl2yGEGKo5zLNjkdw=; b=O7FiG8EtcPTooVsT6ynkYphje+10xa4DmhPRpsQivIisWJwsre1WOiLiPrvJs5VvVz s/MQJ2Ql5ZNgmZgm0aoZU6oXgZkIvtyHBaEGoFF333XehkgxDIRgZGQ3k2jroahLRAB/ KVlPmzspJ5kU/m7LTHRF4XK1sUh23Dixb3WL/Tk7FuIFFOXqePzdOBN6NY08s5NDjXG9 Qctxi69BcNd50iILACk9+tEDEpOcJ6bx6wIKww5kDUw0d//HjoUTpRTitBHpYj4g+F45 kCKmekWQ2MNca/naxang04nvA/ULh8xKFpThdtzt3u2NXmb8fy+qm7wwF0HEYCCoIqmb oQ+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=1FR1Pacd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v2si4452plp.191.2019.04.17.13.44.16; Wed, 17 Apr 2019 13:44:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=1FR1Pacd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733184AbfDQUoP (ORCPT + 30 others); Wed, 17 Apr 2019 16:44:15 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:34910 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732543AbfDQUoK (ORCPT ); Wed, 17 Apr 2019 16:44:10 -0400 Received: by mail-wr1-f68.google.com with SMTP id o12so111186wrn.2 for ; Wed, 17 Apr 2019 13:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w1pW48pbPFvZbhJkwoKxPVapl0Fl2yGEGKo5zLNjkdw=; b=1FR1PacdQ8mXv9C6T5DTFoe3CVzRscWQE+uxrgdsEaoShIulc95xQsIdTtKd4DRjVh YfDkUPGVLcUqjHjGOxa2185xMmiynn9EtcSKFTrdsFr6nGbkxA8kwjSdoxpFe52SameY kuP+Dd1oiemB0n54v87R6G8RsmvOaFmlk7jJ06iI2/zEbwJfEW1nB769d5Iak0qDoA3x uSiYL/84ZjyJl9rwuRAnUm0CsKshLzCJDmk36XpZXkvzEM1pVF8640JGfYPfk1UwwC/z aBzawWLceIRetZFlOX31z98w4/Z79krvDvlVF+GGx30O1svCVNDyBvP2BfJ9suZ2Yk/r YNuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w1pW48pbPFvZbhJkwoKxPVapl0Fl2yGEGKo5zLNjkdw=; b=AlIcoAGePJEoFqi6CM+lH7lQala1xMeRsEuPDEND3prL/KmsXd8hfFyoApJ10FMuh9 bBxtXcAckqzU30slujXJf4rMsL8HqIAEHelmFFt2JRWipX5zLyhGNx4lQsW7mbnTNSy9 popLC8eAjPoGZ1GAQVehfxUrPaHH2eW3ski27d7gYBDtOF5nDKo+NaDnLwk+MvJ7Co0W 2njXcGDchd2yb5yKOFQ4ys4GtpiuO94gUslH2Qc9YqUqELJtVYk7tuBh3QAHm4rzbOIM DrqgeV2bR6eqqGJB9RoiTAMa+Sd636ik2qqjwYiVvVxI/HXfmk1loQhmDQszhOPoj5bT MDCw== X-Gm-Message-State: APjAAAU0KzCkTwK/BsV+ssqvoX1c9oWstWWyR3czYPQunBho56/meT6z fm5LKe20XYJ6mLjBJAKRTolchg== X-Received: by 2002:adf:fe4d:: with SMTP id m13mr61038475wrs.267.1555533848824; Wed, 17 Apr 2019 13:44:08 -0700 (PDT) Received: from boomer.lan (cag06-3-82-243-161-21.fbx.proxad.net. [82.243.161.21]) by smtp.googlemail.com with ESMTPSA id c20sm98716866wre.28.2019.04.17.13.44.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Apr 2019 13:44:07 -0700 (PDT) From: Jerome Brunet To: Ulf Hansson , Kevin Hilman Cc: Jerome Brunet , linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/7] mmc: meson-gx: ack only raised irq Date: Wed, 17 Apr 2019 22:43:50 +0200 Message-Id: <20190417204355.469-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190417204355.469-1-jbrunet@baylibre.com> References: <20190417204355.469-1-jbrunet@baylibre.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is merely a clean up. It makes sense to only ack raised irqs instead of acking everything all the time. Signed-off-by: Jerome Brunet --- drivers/mmc/host/meson-gx-mmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.20.1 diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index 2deeacc051b1..8b690ecde4c5 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -1082,9 +1082,6 @@ static irqreturn_t meson_mmc_irq(int irq, void *dev_id) } out: - /* ack all enabled interrupts */ - writel(irq_en, host->regs + SD_EMMC_STATUS); - if (cmd->error) { /* Stop desc in case of errors */ u32 start = readl(host->regs + SD_EMMC_START); @@ -1096,6 +1093,9 @@ static irqreturn_t meson_mmc_irq(int irq, void *dev_id) if (ret == IRQ_HANDLED) meson_mmc_request_done(host->mmc, cmd->mrq); + /* ack all raised interrupts */ + writel(status, host->regs + SD_EMMC_STATUS); + return ret; }