From patchwork Fri Apr 5 13:59:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 161851 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp472023jan; Fri, 5 Apr 2019 07:00:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqwRce0f+gOO6hS0xkAswtRvLtf0fSHn2FaG2/1po60D6Y9L6UMDUsmOtO3Cnx9Nwh5go8yz X-Received: by 2002:a17:902:b286:: with SMTP id u6mr13225298plr.310.1554472817080; Fri, 05 Apr 2019 07:00:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554472817; cv=none; d=google.com; s=arc-20160816; b=rxryiXO6WWSjnPRtG+kpHGrwxyDPvXYiI34ZKMw3TaA0vvkP+jjDE2vBQQyJcuC9n7 f38eOIDKUJNe9Qz196poi75ABQlU+gvkYdG7EHnoM9IceRg3wNbDZ7JpgZ75O2/51FEQ E94V7a5N0XZyQdKwcE6zgn7ZPjUaDziSuAAwhRjTen3+q9WDm7+9Tew6IhpBC8sEVRvj bEmE3mWbaiCcXwD3jQHs0GNL1GszlQ9vY5RyW/VJ7slEMwFzKKJMYYrg3t02esRCQA9p gat8Xj+74sC+gbAwL/+DpbwciP32WWoOw2M4TU7LdLY3aGc08ikfH/qJNuHDF0vcblot X4aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=f7WYeoPaZNPQ57fzzvqL/gu1swrT+HjFsb8LEv/f3MY=; b=FJzWa+Dqwwoa1WSBiUXhzLoqSojjwzzuWEV9o0zu9I4vqPdclgin0xVEzG3M3qzoVh lHjvf7iTeQfNQgeOBKos9a48PM/I+4tS9UkKqRI/OwpSgfEzp2cm+y+Ijy3jiBzkPOrY Zr2EBNsZkkIPg8Rn7PKbPpcfxnvOXezguawcV/KrZiEz+lwFEf1J4zyRPnj0s59B6/Cf ZbgO6E2v4HFYrwpOhpsRa2uECf/mcvSC76qPRQvgakbWrskq3j+Eac47v2xMaEgy8Wde yzFRrq9pgGV5bS9563Y9J/pt+lptY7ureVWLiahrlepbxlrWSP4KFbIIuZ59mPUjDsnx nNyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v12si19088624pgh.303.2019.04.05.07.00.16; Fri, 05 Apr 2019 07:00:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731377AbfDEOAP (ORCPT + 31 others); Fri, 5 Apr 2019 10:00:15 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:49266 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731306AbfDEOAO (ORCPT ); Fri, 5 Apr 2019 10:00:14 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CEC2116A3; Fri, 5 Apr 2019 07:00:13 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8B06B3F68F; Fri, 5 Apr 2019 07:00:09 -0700 (PDT) From: Will Deacon To: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Will Deacon , "Paul E. McKenney" , Benjamin Herrenschmidt , Michael Ellerman , Arnd Bergmann , Peter Zijlstra , Andrea Parri , Palmer Dabbelt , Daniel Lustig , David Howells , Alan Stern , Linus Torvalds , "Maciej W. Rozycki" , Paul Burton , Ingo Molnar , Yoshinori Sato , Rich Felker , Tony Luck , Mikulas Patocka , Akira Yokosawa , Luis Chamberlain , Nicholas Piggin Subject: [PATCH v2 07/21] x86/io: Remove useless definition of mmiowb() Date: Fri, 5 Apr 2019 14:59:22 +0100 Message-Id: <20190405135936.7266-8-will.deacon@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190405135936.7266-1-will.deacon@arm.com> References: <20190405135936.7266-1-will.deacon@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org x86 maps mmiowb() to barrier(), but this is superfluous because a compiler barrier is already implied by spin_unlock(). Since x86 also includes asm-generic/io.h in its asm/io.h file, we can remove the definition entirely and pick up the dummy definition from core code. Signed-off-by: Will Deacon --- arch/x86/include/asm/io.h | 2 -- 1 file changed, 2 deletions(-) -- 2.11.0 Reviewed-by: Thomas Gleixner diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h index 686247db3106..a06a9f8294ea 100644 --- a/arch/x86/include/asm/io.h +++ b/arch/x86/include/asm/io.h @@ -90,8 +90,6 @@ build_mmio_write(__writel, "l", unsigned int, "r", ) #define __raw_writew __writew #define __raw_writel __writel -#define mmiowb() barrier() - #ifdef CONFIG_X86_64 build_mmio_read(readq, "q", u64, "=r", :"memory")