From patchwork Fri Apr 5 13:59:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 161859 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp473187jan; Fri, 5 Apr 2019 07:01:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqymX3OO9aIqi126pVOZZmw8U3TMkPX25Qh9X/AwYpOo9wyj9PbrVP5Adsb/QfjBlD1xKazz X-Received: by 2002:a65:625a:: with SMTP id q26mr12474540pgv.68.1554472867244; Fri, 05 Apr 2019 07:01:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554472867; cv=none; d=google.com; s=arc-20160816; b=S7HFoavdCyfE7oD4VkrdwqphePaLSg1S/fMg+yrUcQe12k4eAydjy2rVe4TURvRPCY +X09UYno36JEOmcNMgl84a1zIgpIiEDLupxy5OMfG4NhI2ihZugekLyP9Tk4pF7GmA7r Hwrv/aNr4Kc0O8vYZHIVD5e9cnd+I51dNssOgML7h8idc8/rERjoEk3YPDbPJ2yHgiBb RMMbJYg4BNwRVBymwX0IhCav+eSg40hBV1tK0Y1pgiCookeur2kBPKuLATzZrw1S3GBB b9zBRnQ6P0cPppeuVMYAFRq4tQLXEPh3qHwTQA9UKcFCIEjKvFXbd4nvSXNip+iSRvDI 4vkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=mSWn8cyR9XjMSMJQTXk6ljMTsISghCN0n3Ou6TyqRFw=; b=ptk8+rx8SHkC1HW+qqbe5J1TxNXSo/OE+lHH/fHzeePtOikVOYPQsji8EKxuMH10TY emnEDt/YrUcU/CZlwNaoiH6pLhpQkuZaHZRqeVdhWlT9ypYHFnEc1Gy+eJiBJi0IaTf/ T4JjRDBp5/Ablr3ExC7CUwOEfL3lvoWVB1IO2PJ9vOnrZ7mid3ZBc3fgObLW2tO3lCTX W/3VHfeZvZM1irhDy1tNkMiKW2YNbO6qmUpn4oALTTU6oFKE0JLB4q/A3vhZqjsGxuo7 V4E7MdvyOlA6dqlL3IGfilpZ5hJQhyPVPDc9ythmnDFqKDLIyVAJQ1SRTbybM1AP230J LSOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f191si18906781pgc.570.2019.04.05.07.01.06; Fri, 05 Apr 2019 07:01:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731566AbfDEOBF (ORCPT + 31 others); Fri, 5 Apr 2019 10:01:05 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:49730 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731545AbfDEOBB (ORCPT ); Fri, 5 Apr 2019 10:01:01 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9576A1BB0; Fri, 5 Apr 2019 07:01:00 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B0E613F68F; Fri, 5 Apr 2019 07:00:56 -0700 (PDT) From: Will Deacon To: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Will Deacon , "Paul E. McKenney" , Benjamin Herrenschmidt , Michael Ellerman , Arnd Bergmann , Peter Zijlstra , Andrea Parri , Palmer Dabbelt , Daniel Lustig , David Howells , Alan Stern , Linus Torvalds , "Maciej W. Rozycki" , Paul Burton , Ingo Molnar , Yoshinori Sato , Rich Felker , Tony Luck , Mikulas Patocka , Akira Yokosawa , Luis Chamberlain , Nicholas Piggin Subject: [PATCH v2 18/21] scsi/qla1280: Remove stale comment about mmiowb() Date: Fri, 5 Apr 2019 14:59:33 +0100 Message-Id: <20190405135936.7266-19-will.deacon@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190405135936.7266-1-will.deacon@arm.com> References: <20190405135936.7266-1-will.deacon@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All mmiowb() invocations have been removed, so there's no need to keep banging on about it. Signed-off-by: Will Deacon --- drivers/scsi/qla1280.c | 10 ---------- 1 file changed, 10 deletions(-) -- 2.11.0 diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c index 93acbc5094f0..327eff67a1ee 100644 --- a/drivers/scsi/qla1280.c +++ b/drivers/scsi/qla1280.c @@ -3363,16 +3363,6 @@ qla1280_isp_cmd(struct scsi_qla_host *ha) /* * Update request index to mailbox4 (Request Queue In). - * The mmiowb() ensures that this write is ordered with writes by other - * CPUs. Without the mmiowb(), it is possible for the following: - * CPUA posts write of index 5 to mailbox4 - * CPUA releases host lock - * CPUB acquires host lock - * CPUB posts write of index 6 to mailbox4 - * On PCI bus, order reverses and write of 6 posts, then index 5, - * causing chip to issue full queue of stale commands - * The mmiowb() prevents future writes from crossing the barrier. - * See Documentation/driver-api/device-io.rst for more information. */ WRT_REG_WORD(®->mailbox4, ha->req_ring_index);