From patchwork Thu Mar 7 09:14:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 159807 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp7202800jad; Thu, 7 Mar 2019 01:15:49 -0800 (PST) X-Google-Smtp-Source: APXvYqwCDMLBqgs8WBIYGNhDFqE0e5CVNOyFgun8kBhYzk0szMJmFUfFavJDcxkPCgkDBth1exko X-Received: by 2002:a17:902:8602:: with SMTP id f2mr11920233plo.263.1551950148937; Thu, 07 Mar 2019 01:15:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551950148; cv=none; d=google.com; s=arc-20160816; b=noix8hAC9u8IpUrQjXQYGPAwQNvcLTpsAvHHZ4LvCzuymG5EGqMtOoQjy34B1s5jQT a3JoWOaUfx7rn5LAMn/qFZwuHRkul/H1jPrs9wrxck7/rNFSlnn9iifumsJdoHb7NI44 Gj0XBtnSkbpntL8svK/QkdEXPnwiBqN9nEgKu+wwmP92+5WmqRDhFitmIA8on0sOzlqO kOppG0mQPOhA7esUKgdlzVMJpOvLynljMPWJljl8v3XB3WLaXR5Mj/5tNH2s545ssMBO uYgojRAMYZAYP5FkC2AG7QwhVNGXgrgi9ebph4XQYQFgLFb8xBbqEDpEUqO+T+Y8BKf+ +WEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=3oFA3LbMsHv7UTJAUzzn+pFlDFLLXzOswvchRfjeYmw=; b=0XamPsNwAEARx2B5GJk1dmPZo0PUBj10MnSjijyZY79r1og0reGxlHQdMhDjHsqUN3 E1p9kM/u1GFUwLcs8kyVDIAGfjn+rRVeHCM6EfKFDX6fQe3OLEp//6AhsAbBWxCP+UN2 sA0gc6k0otgHVDt90VZMcaP/J9ggOnQJUbEzJpr3tzg6EZqini43iCeatjSbypDltggS HCvLdM+0frZGQbXu3FLvyI0fX4HKa/Y1q4OAf0bA+FUhmuQ3PaQzudPrh1dIR7Rq4+u6 QAyrsG2LGbaRgfD6v1hmCS4+ZrIRi4QF8QjeTF6cukwNr3zZAOg0pzSY945uXRoHGzA/ t4WQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i21si3446535pgh.123.2019.03.07.01.15.48; Thu, 07 Mar 2019 01:15:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726250AbfCGJPq (ORCPT + 31 others); Thu, 7 Mar 2019 04:15:46 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:34585 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725795AbfCGJPq (ORCPT ); Thu, 7 Mar 2019 04:15:46 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPA (Nemesis) id 1MEC8L-1hBxzM2n1p-00AGZI; Thu, 07 Mar 2019 10:15:17 +0100 From: Arnd Bergmann To: Russell King , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart Cc: Nick Desaulniers , Arnd Bergmann , Davidlohr Bueso , Elena Reshetova , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: [PATCH 1/2] futex: mark futex_detect_cmpxchg() as 'noinline' Date: Thu, 7 Mar 2019 10:14:48 +0100 Message-Id: <20190307091514.2489338-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:S3kUtMzoNI8KlQ2wKB+ejkwBPfOfIgqsOL/AUMi0Cb+3hosjQHE vtgKLV6Ss6vzmeqtYoaAXMilaBkzsri1RGXH5CGNpXl2PtoT/xbylPuhxbfiVT6P5k0yQGi ckcewuAugshOAWkiBb1xkm8/ohk0wZotaZqX2VPU0TjcKvX1KcMd9onAwIOXXYdAL/t+E0Y P6pOctJCZ+sWe28t7YT2g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:mcwu7Q9Iyxs=:LmRcAUw+K9SxQVksjd8NUm Le0p9KwIkdAGTwiV+h9k3ObOg/tyurz2w+wSt9FkYYKhyxklQvPkz5DUnBFuNUP+sdbnmDAzW A2dB/dhghmACaxbWgoPARsSg1AI7YRzHLhFgyDcMtyRDR+FFp5SmAkUS0RduZK8Ny1DZcZOai +u+NrFulVIYOJtr+9fHp6pF1p3AYhiKrIM4n+n4DYvvSlDnGhPGgmVYxtkAfYCCIxabwfg6yk w/z+hOLE0g94gQRHbv9ZrO8RRxEADgN0TgVedrF0aaECokFiYKZgee3JFL3mkmjsLQctvG2tR 8bIwnqIYrpI5oW5++OK9qx7klx8szfQ4RAhdwO+RZGXDVxvsYsfUOyD682399ibKegDlLOvSU LRAJRWgs5mqbKWP5wKShrJfPX20CSALs/LGwoJdu3fAv0l6VRFxLDoc7yLm/824sXbBNB2p1u 7BLUAvCuazFxIxM021/Z7u7VqcZWtY0N4Iog+k7saV9k1rZ6gXjrthGjIP2tA+4GBPtAvgWvP Z6/uDAZjqCfu2YPv4KnRA6uDtLoaugvgVH3QC2mKf0fxvPX30QsIS50SCwEqVI3UuJGEk4haq M9PYCebeM72Wy0RFJLYv0Q0I3dppPfscgDdU76Hl8LYRgC8SfgxLjcE8yMHuQUhPQiKQJ2zOP zT03HV8SIa4opwW9msq9b1bZ7n94K6yMr+R/dlmcoXltKkUFRcm9/NeMTDdcb2dIqR4yNkd3g 0i5GTPB16FGCN9xNN7RBu2QSlkTqhTNdMqbcGg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 32-bit ARM, I got a link failure in futex_init() when building with clang in some random configurations: kernel/futex.o:(.text.fixup+0x5c): relocation truncated to fit: R_ARM_JUMP24 against `.init.text' As far as I can tell, the problem is that a branch is over 16MB apart in those configurations, but only if it branches back to the init text. Marking the futex_detect_cmpxchg() function as noinline and not __init avoids the problem for me. Signed-off-by: Arnd Bergmann --- kernel/futex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 diff --git a/kernel/futex.c b/kernel/futex.c index c3b73b0311bc..dda77ed9f445 100644 --- a/kernel/futex.c +++ b/kernel/futex.c @@ -3849,7 +3849,7 @@ SYSCALL_DEFINE6(futex_time32, u32 __user *, uaddr, int, op, u32, val, } #endif /* CONFIG_COMPAT_32BIT_TIME */ -static void __init futex_detect_cmpxchg(void) +static noinline void futex_detect_cmpxchg(void) { #ifndef CONFIG_HAVE_FUTEX_CMPXCHG u32 curval;