| Message ID | 20190304201930.1622839-3-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] phy: allwinner: allow compile testing | expand |
On 3/4/19 4:03 PM, Enrico Weigelt, metux IT consult wrote: > On 04.03.19 21:19, Arnd Bergmann wrote: >> LEDS_GPIO can only be selected when LEDS_CLASS is already enabled: >> >> WARNING: unmet direct dependencies detected for LEDS_GPIO >> Depends on [m]: NEW_LEDS [=y] && LEDS_CLASS [=m] && (GPIOLIB [=y] || COMPILE_TEST [=y]) >> Selected by [y]: >> - PCENGINES_APU2 [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && INPUT_KEYBOARD [=y] >> >> Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> --- >> drivers/platform/x86/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig >> index 4d65d37b0c86..d64529352a9c 100644 >> --- a/drivers/platform/x86/Kconfig >> +++ b/drivers/platform/x86/Kconfig >> @@ -1308,6 +1308,7 @@ config PCENGINES_APU2 >> depends on INPUT && INPUT_KEYBOARD >> select GPIO_AMD_FCH >> select KEYBOARD_GPIO_POLLED >> + select LEDS_CLASS >> select LEDS_GPIO >> help >> This driver provides support for the front button and LEDs on >> > > ACK. Just was about to post the same :) > > Reviewed-by: Enrico Weigelt, metux It consult <info@metux.net> > Enrico, you were also cc-ed on this patch on Feb.25, 2019: https://marc.info/?l=linux-kernel&m=155113875310485&w=2 > > thx. > > --mtx > -- ~Randy
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 4d65d37b0c86..d64529352a9c 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1308,6 +1308,7 @@ config PCENGINES_APU2 depends on INPUT && INPUT_KEYBOARD select GPIO_AMD_FCH select KEYBOARD_GPIO_POLLED + select LEDS_CLASS select LEDS_GPIO help This driver provides support for the front button and LEDs on
LEDS_GPIO can only be selected when LEDS_CLASS is already enabled: WARNING: unmet direct dependencies detected for LEDS_GPIO Depends on [m]: NEW_LEDS [=y] && LEDS_CLASS [=m] && (GPIOLIB [=y] || COMPILE_TEST [=y]) Selected by [y]: - PCENGINES_APU2 [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && INPUT_KEYBOARD [=y] Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.20.0