From patchwork Tue Jan 15 13:43:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 155664 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp4907039jaa; Tue, 15 Jan 2019 05:43:59 -0800 (PST) X-Google-Smtp-Source: ALg8bN6Ug7C4T1NUkk0TY8/VsByua3gWjyPeorQ5/lngfh84eONiMZevUjv//30X2ooWnbm7L5IO X-Received: by 2002:a62:be0c:: with SMTP id l12mr4026939pff.51.1547559839385; Tue, 15 Jan 2019 05:43:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547559839; cv=none; d=google.com; s=arc-20160816; b=bSqost6cSfHVRdohOEsLo7Wu1AnB0C00SmZkxmZR0gwCXl4u79aAiFRRCJeY0LBrKW fhA3tt3Kj0nR7XacA30nstxwf0eGenj0u1RsTIWuYvpAO30DowC7nxWVrIIcCOl5zVJ8 C5HKpXxQfVQUVtE5fTvl82IoZGF5a6V5/kJa4Q5J7FKuXO/LSMtUKmpM2J43LhxnKPQX zjpuB2ip3ZV1CTaajmsPg3PaCTPYubt4/NpxRVJAH6m4N5gDZq276yBHw6AnFOZRBi9A tHrXjc/sP2Vuk4ZImnFdpbDo0xdOT7+uxI5rAZ0UBtzD1H7eTq4skEvZvj0qf3EmF/u4 pSJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=OLWGgWUAXV4+NRnPf2nYT9l1zhiwjTptWj5S11i8zNk=; b=hstcOfxpeF53unXQiK0N1ckK9m5pAR5ZMaznP3RQY4KWgQIBI1WBijpvGjmYSu4Mds H0yU+5j53nZ/HpFvl1/tqO5Y+enU06BKXlnA2IgTOAm6nqW8gCCQRtlNyhMWf0HygdC8 +86d5PAScCSnk93LZWmn0h74FgMTfo3zKYvxBRQGxRRMlZNOqXyEXsPu9QoeBxDqt6X3 xUY8jKnEUBVbtzQz5CFDxhsnhDH5fw0Yf48aFowcGzl/5oczvZdZk5a8DUfbfswScYNW 6JNaekdpMG5drD9IWUK4R0N1xt1R8VGTNqQ4bQ+/lwRTTb0zAPvwGXMjmBk9+XqtScqK nLMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l17si2945844pfd.236.2019.01.15.05.43.59; Tue, 15 Jan 2019 05:43:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729943AbfAONnw (ORCPT + 31 others); Tue, 15 Jan 2019 08:43:52 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:50768 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729245AbfAONns (ORCPT ); Tue, 15 Jan 2019 08:43:48 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8E2F3EBD; Tue, 15 Jan 2019 05:43:48 -0800 (PST) Received: from e110176-lin.kfn.arm.com (e110176-lin.kfn.arm.com [10.50.4.178]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 421483F70D; Tue, 15 Jan 2019 05:43:47 -0800 (PST) From: Gilad Ben-Yossef To: Herbert Xu , "David S. Miller" Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/7] crypto: ccree: shared irq lines are not a bug Date: Tue, 15 Jan 2019 15:43:16 +0200 Message-Id: <20190115134318.28712-7-gilad@benyossef.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190115134318.28712-1-gilad@benyossef.com> References: <20190115134318.28712-1-gilad@benyossef.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ccree driver was logging an error if it got an interrupt but HW indicated nothing to do as might happen if sharing an irq line. Remove the error as this is normal and we already have a debug print for the IRR register value. Signed-off-by: Gilad Ben-Yossef --- drivers/crypto/ccree/cc_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.20.1 diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_driver.c index 8ada308d72ee..e75fbe7a8f84 100644 --- a/drivers/crypto/ccree/cc_driver.c +++ b/drivers/crypto/ccree/cc_driver.c @@ -103,10 +103,10 @@ static irqreturn_t cc_isr(int irq, void *dev_id) /* read the interrupt status */ irr = cc_ioread(drvdata, CC_REG(HOST_IRR)); dev_dbg(dev, "Got IRR=0x%08X\n", irr); - if (irr == 0) { /* Probably shared interrupt line */ - dev_err(dev, "Got interrupt with empty IRR\n"); + + if (irr == 0) /* Probably shared interrupt line */ return IRQ_NONE; - } + imr = cc_ioread(drvdata, CC_REG(HOST_IMR)); /* clear interrupt - must be before processing events */