From patchwork Wed Jan 9 03:55:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Pitre X-Patchwork-Id: 155042 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp254674jaa; Tue, 8 Jan 2019 19:55:48 -0800 (PST) X-Google-Smtp-Source: ALg8bN7rkrmubUGFE0rL7E4ZWdQfuUPTp1DMrWfffFHycumA/4gCQxL64GC4dtCeyD60xGfKSnUz X-Received: by 2002:a62:2cf:: with SMTP id 198mr4416191pfc.67.1547006148844; Tue, 08 Jan 2019 19:55:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547006148; cv=none; d=google.com; s=arc-20160816; b=n0L+lu5zwvjIPZOFBdGuKGP6TgAHs37e6ZDSwc4Os3/TjcfDqfMtzP+E7RWposXyqX pU3joNF2D3HaY1AGQ72usWyNVn1NT/gZ4Lw1rRY9dg6fOdbYHxv2/cFgFxjNfjQm+pkU fH8YhSE0htpf7a8/he5Xwsakqdefg/S7vYAwdnNdye+CYf6ddlvBdWy53ZkEsuknaSZo f67WBwIhm536SEZIcjAOcxAcs0dSp/2Vgj6/jAqptQ5plOlAdLaVIjzvv5dCSSkUWv6N TD5I4uSIj+Pp/P67hF30yocVJ4IbvwmcqaD1W5gasexHBjnwm38zcGM/vUfWgdirZYpz X2RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rncEwA0OlWlyYnPllVBLdEKszVHRyTdh4mWBzRxvR34=; b=CfrOjC+hSWbBOo5XE5RwwmLcvuWj2Sb4/GVMziRVgNcALvOHeIhwumTmNd46jDeAyP X3wyvZv65YNywGSJLJ5KwQbaZkTg3lIWVO63561ylXAN5m3hH04AZd+pbiDsHg/ZnCPK kbYTUmLRTmqYV9V2ei/vEaAqc4QcTedxRoj5FmT8d2FCk7aLD1X2VGfmvoz0Xql/UUSh scFcskmv3/Lh2DFh/fh9h9NLbmYHsYs0S2EToWMsNfspvU7BPpvANNAbs+nWCYAs9+Yr EZfTL/xC0PlyvFR0e5qw4OOY9TwhPcasAjkkJvQT8rFyQeVbeT9njbgCwvNQHJ2ESpfW Q5rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b=QyCZDEEd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v83si68407139pfk.264.2019.01.08.19.55.48; Tue, 08 Jan 2019 19:55:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b=QyCZDEEd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729201AbfAIDzr (ORCPT + 31 others); Tue, 8 Jan 2019 22:55:47 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:62701 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728278AbfAIDzr (ORCPT ); Tue, 8 Jan 2019 22:55:47 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id BFC68119305; Tue, 8 Jan 2019 22:55:46 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=sasl; bh=O5HoLbt0EAT7EAsbBj0FKXLgN eQ=; b=QyCZDEEd537clSdq4Jx0eEd+9cdY7t6MpqT9WiVVk76i5IUEib3c0iIa7 VL/B0YW6qCEXvzWm5IxNoEGdsGp9k1k1aKvSMv9yEQ2gztcwUqmu2Qp78xjlv8c/ EcpttwAC5C09L2huRdvUQJqriXnWUGS3LkYnVoR0mlAUjD3AWc= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id B5913119304; Tue, 8 Jan 2019 22:55:46 -0500 (EST) Received: from yoda.home (unknown [70.82.104.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 288741192FD; Tue, 8 Jan 2019 22:55:46 -0500 (EST) Received: from xanadu.home (xanadu.home [192.168.2.2]) by yoda.home (Postfix) with ESMTP id 4EB392DA041D; Tue, 8 Jan 2019 22:55:45 -0500 (EST) From: Nicolas Pitre To: Greg Kroah-Hartman Cc: Dave Mielke , linux-kernel@vger.kernel.org Subject: [PATCH 2/6] vt: always call notifier with the console lock held Date: Tue, 8 Jan 2019 22:55:00 -0500 Message-Id: <20190109035504.8413-3-nicolas.pitre@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190109035504.8413-1-nicolas.pitre@linaro.org> References: <20190109035504.8413-1-nicolas.pitre@linaro.org> MIME-Version: 1.0 X-Pobox-Relay-ID: 719702DE-13C2-11E9-A82B-70EFDD2159A7-78420484!pb-smtp1.pobox.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Every invocation of notify_write() and notify_update() is performed under the console lock, except for one case. Let's fix that. Signed-off-by: Nicolas Pitre Cc: stable@vger.kernel.org --- drivers/tty/vt/vt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index b9004bd087..5b8b0e33f9 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -2764,8 +2764,8 @@ static int do_con_write(struct tty_struct *tty, const unsigned char *buf, int co con_flush(vc, draw_from, draw_to, &draw_x); vc_uniscr_debug_check(vc); console_conditional_schedule(); - console_unlock(); notify_update(vc); + console_unlock(); return n; }