From patchwork Mon Jan 7 06:41:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 154864 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp3171674ljp; Sun, 6 Jan 2019 22:44:34 -0800 (PST) X-Google-Smtp-Source: AFSGD/VsKVS5mdUTAUdXQ538+XYPnd6BCP4k1TGxSbdN6C3QqaBL6BqafcG3BulHmlM+soTEnlhZ X-Received: by 2002:a62:75d1:: with SMTP id q200mr61705857pfc.254.1546843473995; Sun, 06 Jan 2019 22:44:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546843473; cv=none; d=google.com; s=arc-20160816; b=So0gQuuT2or2SXn2ZbNlSkkkuWjCZXX58yF9ABjbSxDL51LQD9u66LgnzOwPz1dxcQ IU9+j3JhSKPOEEnFU11jvkzeatkSJxad93eWj0dhd32NjxYbZBIJD9WoeEniJGw/nEt4 q0sGX7g9KjZFZcoPHLPh8JEzGaWNdWQ84Hsh17kAIURW7krjLSek6dIvEPCkDTNHteyR tFJDkwi0qvd17p5DUc9tBtS0s+aMqYj/Ac378IO72/KM9GZ4ilUPfp1p0pul8DEDl/IB VfVtmC9+U/NErbMJZ2Hk1KLk9/pulRcNoQDP4jgoe+A8z4VPwb5meOY2bhU0h7s6vt9t WB8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=JHufpCFiR5hyFNaIpQ75Q1+qFFkM6nzfAJw54s+6OLU=; b=xP8hKw1NOFo4NaS2SDrbEbKsk4jKKH77S219YGyfLQGD9OIbfFjQf24pDVL7LkC6D7 seU/m8U8spnN7oaB9nniXQryCpGGoVk0tRuAe+9qfVnR/IcSeYmyWJQ4tPpxRwz6kuU7 +2H2hl+jaEhRV/XRFc/7h9+E6lzFMXMk302Tm/zMNmkx4OKp0L8ASgO16xeIRr4f2hkL 53G6jKqdLoybAPigCGCrCqRdGlxi8QfGu5zlgfwPm3TkVNOLTlqGB/IApEf73GWTsRsb nO1uUil00+mfyaewYKj3mMvIwXXSAlSZqGXNxmGsyUft2R9uuevCN3SXNBm0ONu08DrT QEQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=MBObeyt6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p11si59390976plo.363.2019.01.06.22.44.33; Sun, 06 Jan 2019 22:44:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=MBObeyt6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726723AbfAGGoc (ORCPT + 31 others); Mon, 7 Jan 2019 01:44:32 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:39046 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726602AbfAGGn6 (ORCPT ); Mon, 7 Jan 2019 01:43:58 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x076hdpd055394; Mon, 7 Jan 2019 00:43:39 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1546843419; bh=JHufpCFiR5hyFNaIpQ75Q1+qFFkM6nzfAJw54s+6OLU=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=MBObeyt6dnvi1vJS559IYKSldAfq7ColwoeIx5+OqlXRnlffir47/KGV+Zer1iQiJ 1xC3DsidrE0ec8VBZkNZ3M83NFMD2TL3xkHpI0QKA9vRXUHXTJxaYqjC/sPmnmmybl j7tClpnbpereIioUcSwrkRglhWQBGzuy1K+Onw/g= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x076hdtF038724 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 7 Jan 2019 00:43:39 -0600 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 7 Jan 2019 00:43:39 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Mon, 7 Jan 2019 00:43:39 -0600 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x076gfo9002672; Mon, 7 Jan 2019 00:43:35 -0600 From: Kishon Vijay Abraham I To: Lorenzo Pieralisi , Bjorn Helgaas , Gustavo Pimentel , Alan Douglas , Shawn Lin CC: Jingoo Han , Heiko Stuebner , Cyrille Pitchen , Jia-Ju Bai , , , , , , Subject: [PATCH 12/15] PCI: cadence: Remove pci_epf_linkup from Cadence EP driver Date: Mon, 7 Jan 2019 12:11:45 +0530 Message-ID: <20190107064148.10152-13-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190107064148.10152-1-kishon@ti.com> References: <20190107064148.10152-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org pci_epf_linkup is intended to be invoked if the EPC supports linkup notification. Now that pci-epf-test uses get_features callback, which indicates Cadence EP driver doesn't support linkup notification, remove pci_epf_linkup from Cadence EP driver. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/pcie-cadence-ep.c | 12 ------------ 1 file changed, 12 deletions(-) -- 2.17.1 diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c index 14c2545bb17e..def7820cb824 100644 --- a/drivers/pci/controller/pcie-cadence-ep.c +++ b/drivers/pci/controller/pcie-cadence-ep.c @@ -396,18 +396,6 @@ static int cdns_pcie_ep_start(struct pci_epc *epc) cfg |= BIT(epf->func_no); cdns_pcie_writel(pcie, CDNS_PCIE_LM_EP_FUNC_CFG, cfg); - /* - * The PCIe links are automatically established by the controller - * once for all at powerup: the software can neither start nor stop - * those links later at runtime. - * - * Then we only have to notify the EP core that our links are already - * established. However we don't call directly pci_epc_linkup() because - * we've already locked the epc->lock. - */ - list_for_each_entry(epf, &epc->pci_epf, list) - pci_epf_linkup(epf); - return 0; }