From patchwork Sat Dec 1 15:41:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 152635 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4934464ljp; Sat, 1 Dec 2018 07:53:16 -0800 (PST) X-Google-Smtp-Source: AFSGD/UOsHkW4HTQKGf/ZH63abSfKTVmx7EmVBo/Cwxw1yXFBSN5u4Zk+1+/Gc/Nc0shbRwffuxV X-Received: by 2002:a62:5716:: with SMTP id l22mr9962336pfb.16.1543679596053; Sat, 01 Dec 2018 07:53:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543679596; cv=none; d=google.com; s=arc-20160816; b=zI9PIoaa4u9pxb+z+Bg0EmRrwi2lwRKCk84YDpUDTDMphHeiEQ7aNLz4cJDvvQWw6J HEgJLrliX17swzjMnF+AXInx6HnMdsBCUgE1IdC+NI4/6TbvD0/v4JJyLzMLSqXsRXv1 9hh9HuDfBaErcjSErmkuOvnASaHrFO6bJArpTMZOvXQ25OaL1oCOsEM0NFFJGjnsFU2r f04ppIalLCB3Fcvc8MSEUtG4xn0Q9QBhOt/algcHgyi1OZirCkFd/VHhDWXd6qchyNRW nFQT5MOza64NEildNwdWfnD7jBMB+/CVeJ9ENq1EhNiOW9Pkvm7vI1haApeHBcVA+PBE re7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kRRqVVwMz5ixbamRKAl9gUoe/zOElJopLPpSl/n7en4=; b=ce1+E4H7Vl+N+74liHKDX5X79s2wBoM0SDKIVXlPifiX6uibg7yt/26XMUFWY0U6iU M9BusZZvmHUC76mfBU6eXS9sTxdFdNDsaj5btC36kxlUSin6i12+FP3D9zwG9fnxCLgj lne4PchB0uzxkyO4cboxIxzDl+xFDOEDxOTcax7kZLhAVz1U/CAcIQMFHHkrPI3ieB0R P84Zgb1VNBxDzvidtsGuQiEaRaIZjOthg1cT41kupbPyieqn5hYUXQ2L8Nte3Op8T3s8 NJlqopZJlsNVxfZVrqmAKjLxYN/4TrrUAUP2McX8UZTRMRpETf0NG+E59G+ibFR74d1L 51yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="JThfbg/l"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w16si7927668pga.328.2018.12.01.07.53.15; Sat, 01 Dec 2018 07:53:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="JThfbg/l"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727266AbeLBDGB (ORCPT + 32 others); Sat, 1 Dec 2018 22:06:01 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:45217 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727226AbeLBDGA (ORCPT ); Sat, 1 Dec 2018 22:06:00 -0500 Received: by mail-lf1-f68.google.com with SMTP id b20so6179743lfa.12 for ; Sat, 01 Dec 2018 07:53:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kRRqVVwMz5ixbamRKAl9gUoe/zOElJopLPpSl/n7en4=; b=JThfbg/lOMn+xzuNaXHGw5fxxc6JgwX3c8sTa9g9M1xQwp2EdSRPgWwBwkTv5fyiAG Q3e3FBWNCQNW7ilQSIPXLa4S5eNrDgiL1yYMZoxNu/gVHPnb4ljyOvTejUHcuP091y8Y VNgyfKsYQnhYGgaRvJ7otQBDfkt20Rl5yEbrg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kRRqVVwMz5ixbamRKAl9gUoe/zOElJopLPpSl/n7en4=; b=kw3Wgz64FSedQb7Fnpx6FFROYB5GTjelVTjY0h922aCz1tbgpHCjQhjC6dfTa09Uas hNnJGF67iH9HwqoOHPd/bF9vYohBMNm88gWijxRr6N/avlE7glbCjaQWEz+pJC3AZILN Dhy7zPHJXVFqO6Ilve3GUwpK0z4HGWu+0pyk0jMogtZrqfyaHRZORjRWWOBhuWvhshRi 6cezyzIEgsnoJ6hbiyJl8yxtiuAiFHAlEZtkERyiIf6H3g0OMmHKiK/9jGmF0g/bKFwR 0Ga/yb6wv0AzQaKUaMFs+Me2PIJSMwz/7DBowPa0oDsN90zS4/+oB5qKdTo5Y8uR3igJ WhIw== X-Gm-Message-State: AA+aEWb6Mas2aylV2vKPMOQY2NVc/+Kuq8HGt61cmFNoYI2KOp2pQ+F+ CWBW4wZ1PTpOcGflJWA/GVVQ6g== X-Received: by 2002:a19:fc09:: with SMTP id a9mr6080583lfi.21.1543679590022; Sat, 01 Dec 2018 07:53:10 -0800 (PST) Received: from localhost.localdomain (c-ae7b71d5.014-348-6c756e10.bbcust.telenor.se. [213.113.123.174]) by smtp.gmail.com with ESMTPSA id 13-v6sm1365426ljj.49.2018.12.01.07.53.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Dec 2018 07:53:09 -0800 (PST) From: Linus Walleij To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, Charles Keepax , Bartosz Golaszewski , Marek Szyprowski , Linus Walleij Subject: [PATCH 04/13 v2] regulator: lp8788-ldo: Let core handle GPIO descriptor Date: Sat, 1 Dec 2018 16:41:42 +0100 Message-Id: <20181201154151.14890-5-linus.walleij@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181201154151.14890-1-linus.walleij@linaro.org> References: <20181201154151.14890-1-linus.walleij@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the gpiod_get() rather than the devm_* version so that the regulator core can handle the lifecycle of these descriptors. Fixes: 2468f0d51548 ("regulator: lp8788-ldo: Pass descriptor instead of GPIO number") Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Drop the gpiod_put() on the errorpath after devm_regulator_register() as this will be handled by the regulator core. - Put a comment in the code so maintainers knows not to use managed resources (devm*) --- drivers/regulator/lp8788-ldo.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.19.1 diff --git a/drivers/regulator/lp8788-ldo.c b/drivers/regulator/lp8788-ldo.c index 553b4790050f..2ee22e7ea675 100644 --- a/drivers/regulator/lp8788-ldo.c +++ b/drivers/regulator/lp8788-ldo.c @@ -501,8 +501,12 @@ static int lp8788_config_ldo_enable_mode(struct platform_device *pdev, return 0; } - /* FIXME: check default mode for GPIO here: high or low? */ - ldo->ena_gpiod = devm_gpiod_get_index_optional(&pdev->dev, + /* + * Do not use devm* here: the regulator core takes over the + * lifecycle management of the GPIO descriptor. + * FIXME: check default mode for GPIO here: high or low? + */ + ldo->ena_gpiod = gpiod_get_index_optional(&pdev->dev, "enable", enable_id, GPIOD_OUT_HIGH |