From patchwork Wed Oct 17 07:41:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 149040 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp328194lji; Wed, 17 Oct 2018 00:43:10 -0700 (PDT) X-Google-Smtp-Source: ACcGV60ru+Y0+Yt5hUVlrFXMV+4WluqyUPYeMjnqliLcmJQPfiNBpLd6gkNb3XoBtxK8VeTHmDDX X-Received: by 2002:a63:30c8:: with SMTP id w191-v6mr23054874pgw.447.1539762190283; Wed, 17 Oct 2018 00:43:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539762190; cv=none; d=google.com; s=arc-20160816; b=rOfHZgI1m0IdMWRCDWcTwIJ05PHER1emjEhx14ivZ8E1CbsGWlk8ZXMh0EjwUYNF8X sullkYkiBXQuK3MKAL5tAmhtWx0gZWO1giIYbcSHxKrIbGSbW3/JGBvok4eZHujH9M5i KeECqC/pbg4tN3+NLNFoNUmrQ3rU9KBix6oiHkj+QyUexWdEgsNn2ZxcuyYmy792GJnr 9hhwrR76zKVcm6aGazj3MC+m1CY6Imb6E04mXCeiohvyOUiVVHcZoJfyMOUa0Qx2akGn sOHfeXElXv0w2ySdaPzarhfLX830yV3/NMQvMW4YQMN76pQ/poRhIZ1txLxhvJJM7Ew8 LrEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=QC6R01oOfBedPs18DXWbzKSKHpZhAnqAxHPEUw6bcpc=; b=DCmBNgzlXCVhNxrLse5B4YLps6HUyJyusO5NG4LJ60kN6NLh/A/90FOxSyR16LKTdG LaUdtLmpIDyg3+sHq5KPz/DfqAn9ujm9ipN2e/u89HwisL3ZhVy67XfuQb/A8iaSEVwW 5X41OeI4tKgCyVmoNYly8nApjrnexrk66kC2EGPIvbsWNymGhK+DYm8/tZBvR8ogtG0p +8tNoqPOSALdOw1Kgb4BEbJt4sgPr24fDou3/aTdyQHFP2oiSIwVp4g4BIwVIdmcyTFb pWMrziDudGa0NNHpdrtIUNdAwjDtCG4e2ZqhbJ9phCx0m/kpaBrxpLUTizfpx6YI1f7H t5nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=TNMCxrnN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y13-v6si16262418pgl.236.2018.10.17.00.43.09; Wed, 17 Oct 2018 00:43:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=TNMCxrnN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727733AbeJQPhb (ORCPT + 32 others); Wed, 17 Oct 2018 11:37:31 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:52786 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727655AbeJQPh3 (ORCPT ); Wed, 17 Oct 2018 11:37:29 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id w9H7gkEX052664; Wed, 17 Oct 2018 02:42:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1539762166; bh=QC6R01oOfBedPs18DXWbzKSKHpZhAnqAxHPEUw6bcpc=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=TNMCxrnNQvyYj06S6QSbdfkJdF4V/bTABXr6XHPJRC4fgso6FgVKdxT/JqApxPYYk k23Rm9T1zMFQFR0+YwhVb8oE/2YaTxhuf9UqHE7ston1AXyyNaYx7OZMSEHS9J4339 y64MDDbiACLy1tx6FNTdO0cuWN8dSYnjyIhT4EAI= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w9H7gkuD025580; Wed, 17 Oct 2018 02:42:46 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 17 Oct 2018 02:42:46 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Wed, 17 Oct 2018 02:42:46 -0500 Received: from a0393678ub.dal.design.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w9H7fgSd009413; Wed, 17 Oct 2018 02:42:43 -0500 From: Kishon Vijay Abraham I To: Bjorn Helgaas , Lorenzo Pieralisi , Murali Karicheri , Jingoo Han , Gustavo Pimentel CC: Rob Herring , , , , , Kishon Vijay Abraham I Subject: [PATCH v2 18/21] PCI: keystone: Use ERR_IRQ_STATUS instead of ERR_IRQ_STATUS_RAW to get interrupt status Date: Wed, 17 Oct 2018 13:11:11 +0530 Message-ID: <20181017074114.28239-19-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181017074114.28239-1-kishon@ti.com> References: <20181017074114.28239-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use ERR_IRQ_STATUS instead of ERR_IRQ_STATUS_RAW to get interrupt status. ERR_IRQ_STATUS_RAW has the status of the interrupts before masking whereas ERR_IRQ_STATUS has the status of the interrupts after masking. Since all the interrupts are unmasked here, use ERR_IRQ_STATUS. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.17.1 diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index e181e6277323..c0bba7b604fa 100644 --- a/drivers/pci/controller/dwc/pci-keystone.c +++ b/drivers/pci/controller/dwc/pci-keystone.c @@ -80,7 +80,6 @@ #define ERR_IRQ_ALL (ERR_AER | ERR_AXI | ERR_CORR | \ ERR_NONFATAL | ERR_FATAL | ERR_SYS) #define ERR_FATAL_IRQ (ERR_FATAL | ERR_AXI) -#define ERR_IRQ_STATUS_RAW 0x1c0 #define ERR_IRQ_STATUS 0x1c4 #define ERR_IRQ_ENABLE_SET 0x1c8 #define ERR_IRQ_ENABLE_CLR 0x1cc @@ -249,7 +248,7 @@ static irqreturn_t ks_pcie_handle_error_irq(struct keystone_pcie *ks_pcie) { u32 status; - status = ks_pcie_app_readl(ks_pcie, ERR_IRQ_STATUS_RAW) & ERR_IRQ_ALL; + status = ks_pcie_app_readl(ks_pcie, ERR_IRQ_STATUS); if (!status) return IRQ_NONE;