From patchwork Mon Jul 23 01:57:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AKASHI Takahiro X-Patchwork-Id: 142530 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp5522849ljj; Sun, 22 Jul 2018 18:59:58 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcNhJoQXaeHKj3LrlTQYl1a9Bb1wsGKV+6mJG2eYFfJGglYApUyuPW9VL3mnaQyuu4FynT6 X-Received: by 2002:a17:902:bb08:: with SMTP id l8-v6mr7056166pls.246.1532311197964; Sun, 22 Jul 2018 18:59:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532311197; cv=none; d=google.com; s=arc-20160816; b=UKsa72kTGS7uEclXYJ723ishJghgM8cva4eyPBXfb7wYdN/pVjTiBmyUiBO7ZOZhjr i/P3+8nY0H0GfCrFUKOaSs5SrW2ynYTDQam3qdir7LxbLbGZShRs8af85RnMdlCHHtHX pXCW5La7a5Jigg+mtwEjYE36ClaaelQ/NZHwiAgorOcDPSXG3gtUEEiYuw+RNaSQWCGq hge5rO3y6TJCCwwrc1oOhkk7JPKpwyPPuVCWzOTBM5iUTS5x1vxzhquu7366oxZWEdMO KVVIjg52qMa5DpZopqB/8aeyRAt+t0OXEvFiE7tq3PnhNyNa1cs2CET61MrXli6Qx0x2 kjQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=aiI32IJC87n1yrLeU9zsbi8Z298a1EB8XLfokLEiOx0=; b=QaIpvM9QURPEUF4A4jK7Avvq/KArXZhKS730qZwMHWhtk0GXgMJwdiASj2asywwqVg zPYdehPPKu2aYG5tceaenjw/R9rVNDeWuVLmde6qazFEswDxECZD1tDtZgPduusvkxgm wU2ZZXz5hYOztnR12YCQ871xZhCcTkjwoe9HyPuKLNqCA2unfDDhUoB9qfNxatBAFflQ FzYHMVJPJvr+A1bXk35nhUV56c3rYe7rgshbCCZc5N0Q8/xyt4PNtnDYMO6M90RZ7w4Z aiqVTfdAJdjP7BoP4tRpMk/RHJtrWAwFO8Be6VtxZe4kGTwvy0N7jwpjYwqW7DlUeg1S MPIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LCQUREp9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5-v6si7221580ple.417.2018.07.22.18.59.57; Sun, 22 Jul 2018 18:59:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LCQUREp9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387802AbeGWC6l (ORCPT + 31 others); Sun, 22 Jul 2018 22:58:41 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:45031 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387689AbeGWC6l (ORCPT ); Sun, 22 Jul 2018 22:58:41 -0400 Received: by mail-pg1-f194.google.com with SMTP id r1-v6so11058064pgp.11 for ; Sun, 22 Jul 2018 18:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aiI32IJC87n1yrLeU9zsbi8Z298a1EB8XLfokLEiOx0=; b=LCQUREp94LJj/UbwQ1WlvKHuiSLfHdIhXSELJpx7EaJq4upi0yxteLLk1mc7kzaU3x OLoD9kzQuzd4FtjdgjWKRwpHM3XgUzE7JeHmskIkS9XID4FzDKDaG5PEcjB8ApEO39o0 upnfD+C4KiXUeE8Kk1uKBraH1mqikV89HcYLM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aiI32IJC87n1yrLeU9zsbi8Z298a1EB8XLfokLEiOx0=; b=TRKD3+qXbnxwDO+KnajzYJhdXwXw2t0ZlMnUPdAVVOlLL9t46s6h5a8VPszZzKV6BX t3hSX2507pgLvsKM76kY7KIl2MhSCg9yhg9YKlA1S9bIAEGA5L/c/Iw56Nu5cy4FFu6D x14oa3utatQkxubJ2f5E/zT++YVefRE2fb8ZpVnRzCUlySiRx7x1GUIzYWawc1qQjXgV rEMavYdAVvC4JfCVOJfOarVCzd2diDd8N/7plV8Me+B9Rrw+t/I/sgLJ979WoCuAplfE RehT6JdtnuebVS4msGRuFFnbB76oCu5ORE8NXpL/J/9rjm1WBq7ibTeNM35a0YdrYuMY 2hVw== X-Gm-Message-State: AOUpUlEoh3HoiQI1/572Tmyo7Kv3lR1rbX0tsPHE73YyC9Sx+a9lAXFC 5UwrAe+3qmH1muKQecGGAesR6w== X-Received: by 2002:a63:f414:: with SMTP id g20-v6mr10308718pgi.407.1532311193979; Sun, 22 Jul 2018 18:59:53 -0700 (PDT) Received: from linaro.org ([121.95.100.191]) by smtp.googlemail.com with ESMTPSA id a11-v6sm13539222pfl.66.2018.07.22.18.59.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Jul 2018 18:59:53 -0700 (PDT) From: AKASHI Takahiro To: catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, lenb@kernel.org, ard.biesheuvel@linaro.org Cc: tbaicar@codeaurora.org, bhsharma@redhat.com, dyoung@redhat.com, james.morse@arm.com, mark.rutland@arm.com, al.stone@linaro.org, graeme.gregory@linaro.org, hanjun.guo@linaro.org, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, AKASHI Takahiro Subject: [PATCH v4 5/5] arm64: acpi: fix alignment fault in accessing ACPI Date: Mon, 23 Jul 2018 10:57:32 +0900 Message-Id: <20180723015732.24252-6-takahiro.akashi@linaro.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180723015732.24252-1-takahiro.akashi@linaro.org> References: <20180723015732.24252-1-takahiro.akashi@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a fix against the issue that crash dump kernel may hang up during booting, which can happen on any ACPI-based system with "ACPI Reclaim Memory." (kernel messages after panic kicked off kdump) (snip...) Bye! (snip...) ACPI: Core revision 20170728 pud=000000002e7d0003, *pmd=000000002e7c0003, *pte=00e8000039710707 Internal error: Oops: 96000021 [#1] SMP Modules linked in: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.14.0-rc6 #1 task: ffff000008d05180 task.stack: ffff000008cc0000 PC is at acpi_ns_lookup+0x25c/0x3c0 LR is at acpi_ds_load1_begin_op+0xa4/0x294 (snip...) Process swapper/0 (pid: 0, stack limit = 0xffff000008cc0000) Call trace: (snip...) [] acpi_ns_lookup+0x25c/0x3c0 [] acpi_ds_load1_begin_op+0xa4/0x294 [] acpi_ps_build_named_op+0xc4/0x198 [] acpi_ps_create_op+0x14c/0x270 [] acpi_ps_parse_loop+0x188/0x5c8 [] acpi_ps_parse_aml+0xb0/0x2b8 [] acpi_ns_one_complete_parse+0x144/0x184 [] acpi_ns_parse_table+0x48/0x68 [] acpi_ns_load_table+0x4c/0xdc [] acpi_tb_load_namespace+0xe4/0x264 [] acpi_load_tables+0x48/0xc0 [] acpi_early_init+0x9c/0xd0 [] start_kernel+0x3b4/0x43c Code: b9008fb9 2a000318 36380054 32190318 (b94002c0) ---[ end trace c46ed37f9651c58e ]--- Kernel panic - not syncing: Fatal exception Rebooting in 10 seconds.. (diagnosis) * This fault is a data abort, alignment fault (ESR=0x96000021) during reading out ACPI table. * Initial ACPI tables are normally stored in system ram and marked as "ACPI Reclaim memory" by the firmware. * After the commit f56ab9a5b73c ("efi/arm: Don't mark ACPI reclaim memory as MEMBLOCK_NOMAP"), those regions are differently handled as they are "memblock-reserved", without NOMAP bit. * So they are now excluded from device tree's "usable-memory-range" which kexec-tools determines based on a current view of /proc/iomem. * When crash dump kernel boots up, it tries to accesses ACPI tables by mapping them with ioremap(), not ioremap_cache(), in acpi_os_ioremap() since they are no longer part of mapped system ram. * Given that ACPI accessor/helper functions are compiled in without unaligned access support (ACPI_MISALIGNMENT_NOT_SUPPORTED), any unaligned access to ACPI tables can cause a fatal panic. With this patch, acpi_os_ioremap() always honors memory attribute information provided by the firmware (EFI) and retaining cacheability allows the kernel safe access to ACPI tables. Signed-off-by: AKASHI Takahiro Reviewed-by: James Morse Reviewed-by: Ard Biesheuvel Reported-by and Tested-by: Bhupesh Sharma --- arch/arm64/include/asm/acpi.h | 23 ++++++++++++++++------- arch/arm64/kernel/acpi.c | 11 +++-------- 2 files changed, 19 insertions(+), 15 deletions(-) -- 2.18.0 diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h index 0db62a4cbce2..68bc18cb2b85 100644 --- a/arch/arm64/include/asm/acpi.h +++ b/arch/arm64/include/asm/acpi.h @@ -12,10 +12,12 @@ #ifndef _ASM_ACPI_H #define _ASM_ACPI_H +#include #include #include #include +#include #include #include @@ -29,18 +31,22 @@ /* Basic configuration for ACPI */ #ifdef CONFIG_ACPI +pgprot_t __acpi_get_mem_attribute(phys_addr_t addr); + /* ACPI table mapping after acpi_permanent_mmap is set */ static inline void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size) { + /* For normal memory we already have a cacheable mapping. */ + if (memblock_is_map_memory(phys)) + return (void __iomem *)__phys_to_virt(phys); + /* - * EFI's reserve_regions() call adds memory with the WB attribute - * to memblock via early_init_dt_add_memory_arch(). + * We should still honor the memory's attribute here because + * crash dump kernel possibly excludes some ACPI (reclaim) + * regions from memblock list. */ - if (!memblock_is_memory(phys)) - return ioremap(phys, size); - - return ioremap_cache(phys, size); + return __ioremap(phys, size, __acpi_get_mem_attribute(phys)); } #define acpi_os_ioremap acpi_os_ioremap @@ -129,7 +135,10 @@ static inline const char *acpi_get_enable_method(int cpu) * for compatibility. */ #define acpi_disable_cmcff 1 -pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr); +static inline pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr) +{ + return __acpi_get_mem_attribute(addr); +} #endif /* CONFIG_ACPI_APEI */ #ifdef CONFIG_ACPI_NUMA diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c index 7b09487ff8fb..ed46dc188b22 100644 --- a/arch/arm64/kernel/acpi.c +++ b/arch/arm64/kernel/acpi.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -29,13 +30,9 @@ #include #include +#include #include -#ifdef CONFIG_ACPI_APEI -# include -# include -#endif - int acpi_noirq = 1; /* skip ACPI IRQ initialization */ int acpi_disabled = 1; EXPORT_SYMBOL(acpi_disabled); @@ -239,8 +236,7 @@ void __init acpi_boot_table_init(void) } } -#ifdef CONFIG_ACPI_APEI -pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr) +pgprot_t __acpi_get_mem_attribute(phys_addr_t addr) { /* * According to "Table 8 Map: EFI memory types to AArch64 memory @@ -261,4 +257,3 @@ pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr) return __pgprot(PROT_NORMAL_NC); return __pgprot(PROT_DEVICE_nGnRnE); } -#endif