From patchwork Fri Jul 6 12:58:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 141310 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp3083944ljj; Fri, 6 Jul 2018 05:59:10 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdmB3bc4yZ7kOeVuM9E7vbjyMXahIbX4qQ8f9P6dQeAfLdrUTUzx3PwQBjP4TyH40wy+kV3 X-Received: by 2002:a63:2f04:: with SMTP id v4-v6mr9230190pgv.33.1530881950640; Fri, 06 Jul 2018 05:59:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530881950; cv=none; d=google.com; s=arc-20160816; b=xG2lXsfjXU3esejmKLKJIgFUO+qI5rTv8Q16kpYezl2reuT7vuRSO4i/O/ek9nzUrB eejk/y29lOtp14HjMxXvxyzi9xsdSbZFaMGSLT1uxx/xrUBoWbfXGHcKal2k/AvurOPt 7Ks2Dz0T4cSY5SuLQolVuAKLvOxUXC+lRIB7Lov4mqsvHOE9vjmG0uvJb4s9t0thS0D0 aB8N4dLsu4Yfw1lBPGDoPbQScNQSCI5BEKvxdchiGvc+Un4XhuVsSor5r52fBKINpwyz DwbpF0ViwG+zI/5vAT5Wgd7ZIznyizEZ2LbzsYQvzXojhPeAXDQvh8eNEGJurvTDEa7W LHkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=t+tqCLsTZvFDvbgwoM2IW2pdq1UL1XzdultOVFuxDGw=; b=tl6gLPjxlML7EN7pPzvi8Xc3PmOYukbFdqXdgsHSwUY2guORS5DpAnMgZkzf9sbXEW /yfQMGJaQLmkX/zio4OGxHUQqbb42+ar0Zj5TwDw/M6LU3t8NWgrsCh5K4gjCnljLLVP 96Ne4IZ6Mk5M/25hyUCJCnAh/dRhqwjY+Vdd/WPyc2pIyO3h9Lu2q+UtnxuhGtjUiRzC HQTv/p3R12D1/6szAotZhuQY2wmItiGUkqM43y1X4/VafIa0GFKDif9Jxcjk6SCtXPkn fJWaGMkFH1kX8Yv4RrYU/7ygotBrIRzA6lo+7D2YRjwRkks4RzG6wySXq8SSaq2CX4cG mDUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d37-v6si8369427pla.85.2018.07.06.05.59.10; Fri, 06 Jul 2018 05:59:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933294AbeGFM7I (ORCPT + 31 others); Fri, 6 Jul 2018 08:59:08 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:55877 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932569AbeGFM7H (ORCPT ); Fri, 6 Jul 2018 08:59:07 -0400 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue006 [212.227.15.129]) with ESMTPA (Nemesis) id 0MUyT2-1fcRTs1QwG-00YCVW; Fri, 06 Jul 2018 14:59:00 +0200 From: Arnd Bergmann To: Jiri Pirko , "David S. Miller" Cc: Arnd Bergmann , Arkadi Sharshevsky , Moshe Shemesh , David Ahern , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [net-next] devlink: fix incorrect return statement Date: Fri, 6 Jul 2018 14:58:51 +0200 Message-Id: <20180706125858.3602497-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:DEUtdz05Vw6g4RvEt4zvf7+0YQ/0XtY/XkUbIVTuA5tDXvgHwo7 o0qZWCQWP3aHFGM/K86Dje9GCm6k3FXEPY8ZrmSwvraHclWsgUSh4YcFH0QaFgVrcXPFg42 fFyaoE2KOXnlYLaFrgtzS0Awz4nv8j8PT72RD2GRQyT2hM/YpESo1HDFAQfTorRBHU/do8D 53GO1TVvB/xAS/qK2c23Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:+zV9HUG1cRU=:xgnZBL+9PNBft8oDf5UyMg nXqfr85wIRRbLVUDpDjrl8U4zOvZ3HRV+/f8aKqivaiW3SOfFPA6CsF/WIpYmFDygWn8gI7fU LJZYrTzkAwoCN0QaX4bXiaJAMtRtTAGrccbEuXr97HmflQMqAWUlxrepcWA7j+2vfPP1uJRU7 W3WHQ0EY1COX0hMDW8gE1tsjqzfe5rK/c7FAZzi0phNA8Zj4vgzEOynypAvqaNz+Ms22NaSGo cjkZElUQb0xv2UbEBezZolC9XKUEDBFVwwzMFPbkyU5F+jq0/BYM4gkXdn9P2QE9P1Cckp4vi /bCYs7OZL9krBmrLDayl+/mCqlfXWfXtjWaI7ZkVgdX1/6qW+ZzkJh68oQlaN88xPzP03ldKZ MrtafkACqTQZRi1ZKHuw1vl+vj8bmJHQXwRflchnP/XYRNGeNNbvQuTWhzYhAOGXCNKaSYv9z bhlilqtB+DzW0FSyJ94SGJuGbQ8Y4HsCp/8dOfDF4fg8mfaL8JU9cKOQUjJZK8NOhsFnIfWWG arRSUfo3LtkUQIEL4Tw8SbuBHL6HzsVAYEXaMr8GMgOx/zEMHUtUkN0rVG8fqe5wYGU2Gc4mN Oalu0x/aqKKQFxhWNDGKVMsHZEp5rfo+RWVYYRQ5vRcsLgsPsGucfjHWN8fzvB+81teBqxsLg K7w1pCAVtvn+iAktB+3MEYjL+N0PghZGiJkakS+LpHb+FXnNE7dzybO5lcz0WKOAWsUc= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A newly added dummy helper function tries to return a failure from a "void" function: In file included from include/net/dsa.h:24, from arch/arm/plat-orion/common.c:21: include/net/devlink.h: In function 'devlink_param_value_changed': include/net/devlink.h:771:9: error: 'return' with a value, in function returning void [-Werror] return -EOPNOTSUPP; This fixes it by removing the bogus statement. Fixes: ea601e170988 ("devlink: Add devlink notifications support for params") Signed-off-by: Arnd Bergmann --- include/net/devlink.h | 1 - 1 file changed, 1 deletion(-) -- 2.9.0 diff --git a/include/net/devlink.h b/include/net/devlink.h index 8ed571385626..f67c29cede15 100644 --- a/include/net/devlink.h +++ b/include/net/devlink.h @@ -768,7 +768,6 @@ devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id, static inline void devlink_param_value_changed(struct devlink *devlink, u32 param_id) { - return -EOPNOTSUPP; } #endif