From patchwork Tue Jun 19 06:44:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AKASHI Takahiro X-Patchwork-Id: 139091 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp4837855lji; Mon, 18 Jun 2018 23:46:49 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIRQfg5n15A91+2bP87w1fqfY3YwCwmQfbOJSaFggBGTKpJwJjOlIly5C9TxAlrJp2MZaVi X-Received: by 2002:a63:3807:: with SMTP id f7-v6mr13762847pga.446.1529390809477; Mon, 18 Jun 2018 23:46:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529390809; cv=none; d=google.com; s=arc-20160816; b=PKUuPa4BJkT5g7p6zx5WAtOeE3fFwI+JQm9dzvWk7ByeqC4AI64Ge8wfdUtzB7fDig nV/+pIoJN06deVAKDP8AcjO2bbVlUxIdZiy4KOQJ8VoQkmvpHGzW9kbvO1vUmdvNK4PG IFL61aRggOQJ/nwT9ZM0t5Tq5hy1cy7obgk6r2n5qbrNCCxHvqheJaSYA5yujyTFUZqA VwDPv5Djjz7avXN/uSz2LRcegh8Ffn/661TulLchA24ToIkMR7++TojQaOv2nAbIrKf6 tjAT+YgJygwZoXWvof3iAKCMZP1pev2iGfZ4SAftQXkmtsIXtc+ScGcJXqvXKbkq+xZ3 X0pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=U5jmUh0cvS7hoqJAsRrWRzTdfHnP4v9CDis62qBU8Q4=; b=i75cYZBUCfMqf9sDfsSOm25acnyRHw6FTaqgku5gPyE7Qm9Cmd4GlZeE1oS/VMsyVS Qpt+MIEDOYRSbmjqWxO+HmbA3qyq23qrWml8+ewnQp5+IGsLgyDXIVSk+sBZqN/JKMrj UsMMVP+sQqSgLzu0P7hSBv1N5bTEeydV2qUh43UBK0Oa58jx5feIZ4wyVvztKN93O6qv N2BGXlId5d0+IOxe/faziHkPZ5OIegGT3AZHFH6C3O9aPuYVPePXJITz96HtVgSv3HvE 8vgpCkRzgP9sH8v5kWZ92vUy0ZN9jWXjlFHRKGM1IePcwmo6mvtVaoIMu4QOWWG3fK6+ Sg6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ok9AH5f6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x32-v6si16632276pld.435.2018.06.18.23.46.49; Mon, 18 Jun 2018 23:46:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ok9AH5f6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756117AbeFSGqX (ORCPT + 30 others); Tue, 19 Jun 2018 02:46:23 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:44444 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755553AbeFSGoU (ORCPT ); Tue, 19 Jun 2018 02:44:20 -0400 Received: by mail-pf0-f194.google.com with SMTP id h12-v6so9424967pfk.11 for ; Mon, 18 Jun 2018 23:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=U5jmUh0cvS7hoqJAsRrWRzTdfHnP4v9CDis62qBU8Q4=; b=Ok9AH5f63Z5P4nLp4R86Cbrme3ylXGTziiRhMeWfAfpPvZsvjHvNmdfovMFBW4Kz4K 7+++RgkEKLM/N4q+KBmciZjxPBGWbXK61CHVGyCHqJVZ7fzGw5T5LuT5i+3TRjPfEgD3 RZNR8ZiIC2kxfN5DmmHRDMDjV1jfSBW2H3mew= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=U5jmUh0cvS7hoqJAsRrWRzTdfHnP4v9CDis62qBU8Q4=; b=nUn0W5nQWRbOD1jMkPqax0T9W5VkGKMkki96vOyhae765zq1fwHReBf4ObJo8wqwTs YimoRyn8n7dTuFkHMIew9qZ5iyATnVXv24zNNjyJeqWjzeP+3+rd6uH6qUM761hlE3zy KxNxzkuIQfrtXG7bbnS2DpX86kz1s9HkuNHGNMIi51I1N/vvi+sYs+KSyeetz659HV// k+xvWoU6YXGru8kEz2MWnYxePwYW4n4GgvrcYv9RePc9G2K0hu6w6aAZC2Xd1rJtQkE+ /ERHCpu6tNAFblfKkdm+xuv6v2eDvrUB0xWY1Mn03Xw1HE1ruAeFa5jtkICM/leXN27F pmNg== X-Gm-Message-State: APt69E3gXoJrTUQf3qzWqSsRHreIlpyvOwlJw+4T09SwniKDOzBQpsQf VCuswmzgGtkru2LPamtQio33rg== X-Received: by 2002:a65:508d:: with SMTP id r13-v6mr13893264pgp.143.1529390660231; Mon, 18 Jun 2018 23:44:20 -0700 (PDT) Received: from linaro.org ([121.95.100.191]) by smtp.googlemail.com with ESMTPSA id i71-v6sm23289450pgd.22.2018.06.18.23.44.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jun 2018 23:44:19 -0700 (PDT) From: AKASHI Takahiro To: catalin.marinas@arm.com, will.deacon@arm.com, akpm@linux-foundation.org, ard.biesheuvel@linaro.org Cc: tbaicar@codeaurora.org, bhsharma@redhat.com, dyoung@redhat.com, james.morse@arm.com, mark.rutland@arm.com, al.stone@linaro.org, graeme.gregory@linaro.org, hanjun.guo@linaro.org, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, AKASHI Takahiro Subject: [PATCH v2 4/4] arm64: acpi: fix alignment fault in accessing ACPI Date: Tue, 19 Jun 2018 15:44:24 +0900 Message-Id: <20180619064424.6642-5-takahiro.akashi@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180619064424.6642-1-takahiro.akashi@linaro.org> References: <20180619064424.6642-1-takahiro.akashi@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a fix against the issue that crash dump kernel may hang up during booting, which can happen on any ACPI-based system with "ACPI Reclaim Memory." (kernel messages after panic kicked off kdump) (snip...) Bye! (snip...) ACPI: Core revision 20170728 pud=000000002e7d0003, *pmd=000000002e7c0003, *pte=00e8000039710707 Internal error: Oops: 96000021 [#1] SMP Modules linked in: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.14.0-rc6 #1 task: ffff000008d05180 task.stack: ffff000008cc0000 PC is at acpi_ns_lookup+0x25c/0x3c0 LR is at acpi_ds_load1_begin_op+0xa4/0x294 (snip...) Process swapper/0 (pid: 0, stack limit = 0xffff000008cc0000) Call trace: (snip...) [] acpi_ns_lookup+0x25c/0x3c0 [] acpi_ds_load1_begin_op+0xa4/0x294 [] acpi_ps_build_named_op+0xc4/0x198 [] acpi_ps_create_op+0x14c/0x270 [] acpi_ps_parse_loop+0x188/0x5c8 [] acpi_ps_parse_aml+0xb0/0x2b8 [] acpi_ns_one_complete_parse+0x144/0x184 [] acpi_ns_parse_table+0x48/0x68 [] acpi_ns_load_table+0x4c/0xdc [] acpi_tb_load_namespace+0xe4/0x264 [] acpi_load_tables+0x48/0xc0 [] acpi_early_init+0x9c/0xd0 [] start_kernel+0x3b4/0x43c Code: b9008fb9 2a000318 36380054 32190318 (b94002c0) ---[ end trace c46ed37f9651c58e ]--- Kernel panic - not syncing: Fatal exception Rebooting in 10 seconds.. (diagnosis) * This fault is a data abort, alignment fault (ESR=0x96000021) during reading out ACPI table. * Initial ACPI tables are normally stored in system ram and marked as "ACPI Reclaim memory" by the firmware. * After the commit f56ab9a5b73c ("efi/arm: Don't mark ACPI reclaim memory as MEMBLOCK_NOMAP"), those regions are differently handled as they are "memblock-reserved", without NOMAP bit. * So they are now excluded from device tree's "usable-memory-range" which kexec-tools determines based on a current view of /proc/iomem. * When crash dump kernel boots up, it tries to accesses ACPI tables by mapping them with ioremap(), not ioremap_cache(), in acpi_os_ioremap() since they are no longer part of mapped system ram. * Given that ACPI accessor/helper functions are compiled in without unaligned access support (ACPI_MISALIGNMENT_NOT_SUPPORTED), any unaligned access to ACPI tables can cause a fatal panic. With this patch, acpi_os_ioremap() always honors memory attribute information provided by the firmware (EFI) and retaining cacheability allows the kernel safe access to ACPI tables. Signed-off-by: AKASHI Takahiro Suggested-by: James Morse Suggested-by: Ard Biesheuvel Reported-by and Tested-by: Bhupesh Sharma --- arch/arm64/include/asm/acpi.h | 23 ++++++++++++++++------- arch/arm64/kernel/acpi.c | 11 +++-------- 2 files changed, 19 insertions(+), 15 deletions(-) -- 2.17.0 Reviewed-by: James Morse Reviewed-by: Ard Biesheuvel diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h index 0db62a4cbce2..68bc18cb2b85 100644 --- a/arch/arm64/include/asm/acpi.h +++ b/arch/arm64/include/asm/acpi.h @@ -12,10 +12,12 @@ #ifndef _ASM_ACPI_H #define _ASM_ACPI_H +#include #include #include #include +#include #include #include @@ -29,18 +31,22 @@ /* Basic configuration for ACPI */ #ifdef CONFIG_ACPI +pgprot_t __acpi_get_mem_attribute(phys_addr_t addr); + /* ACPI table mapping after acpi_permanent_mmap is set */ static inline void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size) { + /* For normal memory we already have a cacheable mapping. */ + if (memblock_is_map_memory(phys)) + return (void __iomem *)__phys_to_virt(phys); + /* - * EFI's reserve_regions() call adds memory with the WB attribute - * to memblock via early_init_dt_add_memory_arch(). + * We should still honor the memory's attribute here because + * crash dump kernel possibly excludes some ACPI (reclaim) + * regions from memblock list. */ - if (!memblock_is_memory(phys)) - return ioremap(phys, size); - - return ioremap_cache(phys, size); + return __ioremap(phys, size, __acpi_get_mem_attribute(phys)); } #define acpi_os_ioremap acpi_os_ioremap @@ -129,7 +135,10 @@ static inline const char *acpi_get_enable_method(int cpu) * for compatibility. */ #define acpi_disable_cmcff 1 -pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr); +static inline pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr) +{ + return __acpi_get_mem_attribute(addr); +} #endif /* CONFIG_ACPI_APEI */ #ifdef CONFIG_ACPI_NUMA diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c index 7b09487ff8fb..ed46dc188b22 100644 --- a/arch/arm64/kernel/acpi.c +++ b/arch/arm64/kernel/acpi.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -29,13 +30,9 @@ #include #include +#include #include -#ifdef CONFIG_ACPI_APEI -# include -# include -#endif - int acpi_noirq = 1; /* skip ACPI IRQ initialization */ int acpi_disabled = 1; EXPORT_SYMBOL(acpi_disabled); @@ -239,8 +236,7 @@ void __init acpi_boot_table_init(void) } } -#ifdef CONFIG_ACPI_APEI -pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr) +pgprot_t __acpi_get_mem_attribute(phys_addr_t addr) { /* * According to "Table 8 Map: EFI memory types to AArch64 memory @@ -261,4 +257,3 @@ pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr) return __pgprot(PROT_NORMAL_NC); return __pgprot(PROT_DEVICE_nGnRnE); } -#endif