From patchwork Mon May 28 15:50:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 137097 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp2986132lji; Mon, 28 May 2018 08:51:19 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoTpqBJypK3Ue6OOPj3VDa0p4cXpXSmzD5PM+kobXJ+FUA+X+EEIruU+7/atEsGXBIb1x3b X-Received: by 2002:a17:902:b409:: with SMTP id x9-v6mr14390379plr.180.1527522679662; Mon, 28 May 2018 08:51:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527522679; cv=none; d=google.com; s=arc-20160816; b=uT85S+GBPbyYdyVaX+1l5UdIn6cienHVfZTN5p2AjwC8zC986VN3TDbs3vHB9W5MLP 4hNRVs/kdCpUjXxEkPVv5wqKVt8rYMP/E92n/f0dyATxSffHKbkUpi00iwIoGp5Nbq19 Bndp+n7izuuVGdMWItYtcOQ4eLCc1cu0rgRyUamSoltoizxniVLSfqsQJJqs0cg6lMWT D+4QZkUGfvkL7My/CzNtwvlyZTDyk+HrCmDnc7j8mEwho84vX3B8wXe9i6z7tXNIwmaM Q7HTYVO1l7HwcpDctmYIP/xZL3NolOfaJmzSkpmonxLG5tXm8wkTyEeTEr07mzvnMJxu pD8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=zBkCqrR/Vqvw0wUi1CSzDu25rXlVC11LtgKMt8yDJOM=; b=x/tjAB3l0ZeLN+uQFz+IGs4bp85db/7VgyK584XcIVvs5q/03FV5jP0XzL4i/5SsTa KN/Iwt234mtmVJ9PeOqAixLKNrRHN+fRFw614OEGJwHAVENXF+aVIobx4kLotPEIrueL EoEcU3ECBp4qMbqugX+KDbrsznROpjxkQTYzzAv2y5BWNBeiK7LpsQFoFA6qSb/IN8f9 JEyan+ugDpQB7kXqJ5yEU72BSm/WDMF1hkXsnijE4ux54hzVHfDQJ4FZWV0G0opdG+Im xb9GAV53oqyWiiQBan/ekVW+5lF2ejyFKOWszjUMdxQt7EILfhVbApqdvT5zuchKxYpN NIbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64-v6si29938557plk.137.2018.05.28.08.51.19; Mon, 28 May 2018 08:51:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035037AbeE1PvR (ORCPT + 30 others); Mon, 28 May 2018 11:51:17 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:49581 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034909AbeE1PvK (ORCPT ); Mon, 28 May 2018 11:51:10 -0400 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0Lafkm-1g3EoH1CAK-00kRAk; Mon, 28 May 2018 17:51:01 +0200 From: Arnd Bergmann To: "David S. Miller" Cc: Arnd Bergmann , Grygorii Strashko , Sekhar Nori , Florian Fainelli , linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: davinci: fix building davinci mdio code without CONFIG_OF Date: Mon, 28 May 2018 17:50:20 +0200 Message-Id: <20180528155059.2736080-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:laYbLfwtkFRugoloOA16dfhOo0aZWP/ZLkfgUgyWktElNUmlMnB Jj2ImGl805agh63By3fzBaC4CBiZKEJd3rjKAJ8smCUKIevSUgr4/1b/702vJ9ALGuPk2K3 TI9uKN984Q61cFhojIZmUA+1dA1t2n6S7EUUM2VlDpQ8vAQBCFafa+SYe/nSOdqSpHDr2Fb 9pEPBvcHK/12p0bzpqh6A== X-UI-Out-Filterresults: notjunk:1; V01:K0:DEd8Fye4Caw=:1Oc9WAhq36axtVZFjJkO6j hSC0hh7vrDjV4UAkGGdWqoEc3SN8q3qb7j+u3KCVzTsaztF9VHKOpAVOmcVMAMAYinY6HaGW7 C1bJWZI3XI2SmFnaMdu0MaNlmaotXEHJxduBIpgMC1oIim78fjUqdk+/tMlJx9YuiMaOHtWdj PamLs4ccLZeTep5qCRdvBju8hGfv95jWmIEavJ1mnIdzcSGFij+UdIScRnR53rvkcEcYuxhmM 9MSuuBPQ3T0hnZYaoBlWFo0Ki64GdI3/ausk7ywne0g03Sk/Fzjw+zv+S0Xdl2xlBdtiII1Ml BvBM05iqVNZLMQLICpbQd7vb9yb8Q9+FDt0F630sBW75XhlQ8KNlgLaLEpx5nltVgeCes2yYL mvp2xuhcvI2+XZU/kd3vHZzsX7wyQrpmdCd5VORi6DnnnDqZCmfdn4h3aPLCya72Bog8rRbuW JHiv/J8dQXxiespJhTIArafZi4g6mTuVNUkdQovdYgc37CutKJmFZYVKmg3R2YP3I4wF9jTr7 7/cjH/fq4R5ra/sVgbpkNcGMa910pfpsXL1np77A/XnldvG+TqeAmGer5q8gb9QbzQyx4kPvc AxhCSqbUGTzlyY5LXiqRtbIi+xFqKDmzusSF2jpxHTRTZPk7eFhBGzolUv4B1r3LkTaQ9ubrH dLR2KTTeHRp8IZDXLbnDByQByk/QZFiR8OB5NzxIpEb+j0qwrwpBKMbFfy6Sm8ld2YuI= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Test-building this driver on targets without CONFIG_OF revealed a build failure: drivers/net/ethernet/ti/davinci_mdio.c: In function 'davinci_mdio_probe': drivers/net/ethernet/ti/davinci_mdio.c:380:9: error: implicit declaration of function 'davinci_mdio_probe_dt'; did you mean 'davinci_mdio_probe'? [-Werror=implicit-function-declaration] This adjusts the #ifdef logic in the driver to make it build in all configurations. Fixes: 2652113ff043 ("net: ethernet: ti: Allow most drivers with COMPILE_TEST") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/ti/davinci_mdio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.9.0 Acked-by: Sekhar Nori diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c index 8ac72831af05..a98aedae1b41 100644 --- a/drivers/net/ethernet/ti/davinci_mdio.c +++ b/drivers/net/ethernet/ti/davinci_mdio.c @@ -321,7 +321,6 @@ static int davinci_mdio_write(struct mii_bus *bus, int phy_id, return ret; } -#if IS_ENABLED(CONFIG_OF) static int davinci_mdio_probe_dt(struct mdio_platform_data *data, struct platform_device *pdev) { @@ -339,7 +338,6 @@ static int davinci_mdio_probe_dt(struct mdio_platform_data *data, return 0; } -#endif #if IS_ENABLED(CONFIG_OF) static const struct davinci_mdio_of_param of_cpsw_mdio_data = { @@ -374,7 +372,7 @@ static int davinci_mdio_probe(struct platform_device *pdev) return -ENOMEM; } - if (dev->of_node) { + if (IS_ENABLED(CONFIG_OF) && dev->of_node) { const struct of_device_id *of_id; ret = davinci_mdio_probe_dt(&data->pdata, pdev);