From patchwork Tue May 1 18:55:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Salil Mehta X-Patchwork-Id: 134799 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp5283156lji; Tue, 1 May 2018 12:01:25 -0700 (PDT) X-Google-Smtp-Source: AB8JxZphJLbOJljJfmtUjVtLz04ia6XL+BYYsZOEUwVG+d59WJVAwt7h/WHHCt3FwXevylaqHCYi X-Received: by 2002:a17:902:b497:: with SMTP id y23-v6mr9856416plr.309.1525201285029; Tue, 01 May 2018 12:01:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525201285; cv=none; d=google.com; s=arc-20160816; b=KrdoaqLGG/5nyzhmnMslZ0DcnHw5Q3zzvOaEm9uxZtK+XQQsweIFKyhnavlx9fox4q wfB/7KlskodNZBI7otsR0YjF6ByZRVmoXP+2E1ZnSMl19UBgx8nWPnPrfZr20mUzdPNL BAdUe5WsL2F+5sg+VneCufe22PXwP/hL3CpZ64KxtqPQthTGxcQ89ScFAecf/DGXND/a /HOLG8wbKbutdLivlIjTx+ZC6io63QX2KbBtwx+dOY+aHkAd0wnxAvCWdj+darp/8z/L dCSmWkXAvsthqPiKfh1HzU/VUKkJeT9WIAfhdOxhKUNmgRfFqo6tFYcSqIzTKmZfDctv aqdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=VhbI9b6lNCxtc/5qOrX8wIsJRULVrHSr/GBF+M42h/c=; b=TGQ5cNjjAe9uHWFXvWdb7eBSvj+jxhJ4CMif486xSojSYK8TBFlgPWHDK2l0EEvI9e p0n5AEgKQ2yk21ew47F/JE+xj9xmKGN/a5Mg0bUXQjWCr9xRegGq1UBwve50caKfALEG slDiaqhahig9uVHDWpE19gxGHX4i76/h0/cF/QBxmnS6d6RsBO9Fqy3h/FO/OKQiv7g2 yv/RPnqn/MP0nUMJnvXQp/KKof5O3480SYTm6QfcxxFSImwgRfNloKbbbtTaJnDb025y pokJkgc1d5E86Q7kG7BzlhadPKKFMz5zs1Pj5/hK8Vj/Qpx/ENwCu07oxSjbi8YCQsOy cF0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w71-v6si1179897pgd.1.2018.05.01.12.01.24; Tue, 01 May 2018 12:01:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756134AbeEAS55 (ORCPT + 29 others); Tue, 1 May 2018 14:57:57 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:7638 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753505AbeEAS5z (ORCPT ); Tue, 1 May 2018 14:57:55 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 361DAAA760EA0; Wed, 2 May 2018 02:57:42 +0800 (CST) Received: from S00293818-DELL1.china.huawei.com (10.202.226.46) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.361.1; Wed, 2 May 2018 02:57:35 +0800 From: Salil Mehta To: CC: , , , , , , , Yunsheng Lin Subject: [PATCH net-next 1/9] net: hns3: Remove error log when getting pfc stats fails Date: Tue, 1 May 2018 19:55:57 +0100 Message-ID: <20180501185605.9584-2-salil.mehta@huawei.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20180501185605.9584-1-salil.mehta@huawei.com> References: <20180501185605.9584-1-salil.mehta@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.202.226.46] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yunsheng Lin When mac supports DCB, but is in GE mode, it does not support querying pfc stats, firmware returns error when trying to query the pfc stats. this creates a lot of noise in the kernel log when it prints the error log. This patch fixes it by removing the error log, because it already return the error to the user space, so the user should be aware of the error. Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.7.4 diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c index 885f25c..c69ecab 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c @@ -134,11 +134,8 @@ static int hclge_pfc_stats_get(struct hclge_dev *hdev, } ret = hclge_cmd_send(&hdev->hw, desc, HCLGE_TM_PFC_PKT_GET_CMD_NUM); - if (ret) { - dev_err(&hdev->pdev->dev, - "Get pfc pause stats fail, ret = %d.\n", ret); + if (ret) return ret; - } for (i = 0; i < HCLGE_TM_PFC_PKT_GET_CMD_NUM; i++) { struct hclge_pfc_stats_cmd *pfc_stats =