From patchwork Mon Apr 9 00:26:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 132971 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp687940ljb; Sun, 8 Apr 2018 18:41:34 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+180A5R2wOzDAJpV4pKxbJ3+cHzIHr2XqubKiAv059XGlF6vTadpinctx3eCab6Dtx+1U0 X-Received: by 10.98.236.220 with SMTP id e89mr27311075pfm.173.1523238094522; Sun, 08 Apr 2018 18:41:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523238094; cv=none; d=google.com; s=arc-20160816; b=YBQkD9a/C/fqxQeFwUqNSxhkxqS+PD4X04OwD0f9S6YkVbFr/zDC+Tsefz138mp51A bccAdISzVxRxc8f74LMk+jXKz/sSqWSWUHjeCVLQFqstGS1HU4b4J6hioBOD8KZjIOrV 7vSc4NFEC4+QRjN9S4htSYUDdb9aa/6TxLIuAR8LRkBu/u7+DXw0E7zzO7IhBrtSiSFC MU1bI7pG4ZmyVN0orDaOUeN9Yv3hZBPb5zBM9JJ1BbgHjpHJgMXRkrcr+5Gf2GKGQyVO KVmAynTGz18WMFYcR1corVphgais21B8/HvJi13f2/cVR53AUTlykv8158MvaxFgoJp+ Is3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=b0O65XNpY45LzQofsOGQ0PkdJeWRCPgqKusEPbZzBOQ=; b=lrzr3kM9OEli7zyyH12St4TifU60fzM5Cedn4Bub7VLvvVjc9iaR8NvYaGA6EO0Cbi zpa/AMl8KsXbHOFSWyjcQQJ9Hfudg50iCbtN8b2zaK1WysuhMWMjujn6S3+TgBwwEct4 CLlkSNrMAP1ixM33xAK1kYxR/qtgi8VBU0H8WxVduJW0TCppt5J7tAJb4k9qJUYxKwwl vwh3oR+3wfhy45FpJvcUWaDkCvtkM/TteuhSca01jrpE3QnSmzYWm0d4GfBNH5eISpB7 Kj3zpFIjFxz3/tG2ZYHMZ2GV5zsIxjrbEjSYk/FtkcOLgpwj8tGVH3o8/RjUjBf1ukcf JwIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=W2YMmeVB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s3si3328071pgr.421.2018.04.08.18.41.34; Sun, 08 Apr 2018 18:41:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=W2YMmeVB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932852AbeDIBlO (ORCPT + 29 others); Sun, 8 Apr 2018 21:41:14 -0400 Received: from mail-by2nam01on0110.outbound.protection.outlook.com ([104.47.34.110]:2593 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755776AbeDIAe4 (ORCPT ); Sun, 8 Apr 2018 20:34:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=b0O65XNpY45LzQofsOGQ0PkdJeWRCPgqKusEPbZzBOQ=; b=W2YMmeVBtOPOJtCBNEHTD7q+pMhAC5gA+F0Nt1+lH4FK8DtnuZlxazJAG5ZfHR/2pUgPbnSKdqQ/bjS1p0i9Qrh2ZsdxKkmMOdWMeN+3wGP0kSw2W3ErJgSrp+8xtpjCoFfzB53+azACKfgmb+lKYOaB134XeRjoteoBI7HzZ6o= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB0806.namprd21.prod.outlook.com (10.167.107.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.3; Mon, 9 Apr 2018 00:34:49 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:34:49 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Mark Salter , Marc Zyngier , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 293/293] irqchip/gic-v3: Change pr_debug message to pr_devel Thread-Topic: [PATCH AUTOSEL for 4.9 293/293] irqchip/gic-v3: Change pr_debug message to pr_devel Thread-Index: AQHTz5lxKiIW/GueLkOOVs/pa9/9Ag== Date: Mon, 9 Apr 2018 00:26:45 +0000 Message-ID: <20180409002239.163177-293-alexander.levin@microsoft.com> References: <20180409002239.163177-1-alexander.levin@microsoft.com> In-Reply-To: <20180409002239.163177-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB0806; 7:Ng7t+e4nkRKteA7deOe0fYdXkR/pJ8wmP1oMwQSjak+r2p4bIqEqW60zdU4ihZD4xFb2Ay4vf0/5NjGRFgWGxCumuFSy3sZvn0tlazybz1DMgbsBP5PBjrTeMRODpZhB1+ui3juBH4bu4QiUpjGl+6YEO22nxRMkr0Ccy+L0sICuhmpHoz2tNFh7ONBMuToRr2+Tj2ewuuGHbekSLhBAkJxQmjlU69ZDTo/oeKcdQ3KI7xoQvbicwtEORC+FEx0e; 20:f+SlDMJqr7yT7sTUYzeOHk/KjFHGjRbz7vGSpaAxuUQ2y+X01N+eUTITj0vdigebTHd8/yPtqeR+VTwoEnEKJj3A7tb4VCB9pyvwpVr1MYr7FmzsreylaUZeqZmNWD23qHWEAwVONEd1z/rODFNMYkGauKKoccfLcnmfyDPS2+4= x-ms-office365-filtering-ht: Tenant X-MS-Office365-Filtering-Correlation-Id: 05e85e00-0295-4443-87bd-08d59db1b3d3 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR2101MB0806; x-ms-traffictypediagnostic: DM5PR2101MB0806: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(180628864354917)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(61426038)(61427038)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:DM5PR2101MB0806; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB0806; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(39860400002)(376002)(396003)(366004)(39380400002)(199004)(189003)(2906002)(25786009)(2501003)(10290500003)(476003)(11346002)(446003)(97736004)(5250100002)(68736007)(2616005)(102836004)(6506007)(59450400001)(3846002)(3660700001)(486006)(3280700002)(305945005)(6666003)(99286004)(5660300001)(76176011)(1076002)(186003)(26005)(7736002)(6116002)(81156014)(81166006)(86612001)(4326008)(105586002)(15650500001)(10090500001)(2900100001)(54906003)(22452003)(316002)(36756003)(110136005)(107886003)(8676002)(6436002)(478600001)(53936002)(66066001)(6486002)(6512007)(86362001)(14454004)(72206003)(8936002)(106356001)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB0806; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 0bLJ9mE36/0AFUWfwWzV2NFUra0vOD+3ePcrZXmcvSrUzGbMoVQSC04GYrHu8sZEbE856IqFwVTuVwmV3FVLlO+97TajrlyTpF+fzdvnPGlrg2AaAnqIIaB7JUu6zm5YWRbfWXKs0U5W04GE4+r39VQxQ3VvrsZsiNFqXP13sbVS8Nwz1hz7QJB/f8U7XIRGXM6tVC528amWgY6wvELdStqnYXUyHDECHTiPi8iTLdZQZkWsIFdhXpROkYAE0XdmW+vpmfAaCJpayRmO96YBiu9T+Wp4scPpi421sf9iPcx3JhC+CQl/NUEyywH2F1lDYFRHf1U8mnAMrClrZJv5GoZt2GvqQJNaywu2C6wPMktczlvlkxXfW6jorkpcoYK+NpRPXcJdWNjTmPyUHNXlK1ccumYvxk0VvY5mqtoKx7w= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05e85e00-0295-4443-87bd-08d59db1b3d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:26:45.8478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0806 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Salter [ Upstream commit b6dd4d83dc2f78cebc9a7e6e7e4bc2be4d29b94d ] The pr_debug() in gic-v3 gic_send_sgi() can trigger a circular locking warning: GICv3: CPU10: ICC_SGI1R_EL1 5000400 ====================================================== WARNING: possible circular locking dependency detected 4.15.0+ #1 Tainted: G W ------------------------------------------------------ dynamic_debug01/1873 is trying to acquire lock: ((console_sem).lock){-...}, at: [<0000000099c891ec>] down_trylock+0x20/0x4c but task is already holding lock: (&rq->lock){-.-.}, at: [<00000000842e1587>] __task_rq_lock+0x54/0xdc which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&rq->lock){-.-.}: __lock_acquire+0x3b4/0x6e0 lock_acquire+0xf4/0x2a8 _raw_spin_lock+0x4c/0x60 task_fork_fair+0x3c/0x148 sched_fork+0x10c/0x214 copy_process.isra.32.part.33+0x4e8/0x14f0 _do_fork+0xe8/0x78c kernel_thread+0x48/0x54 rest_init+0x34/0x2a4 start_kernel+0x45c/0x488 -> #1 (&p->pi_lock){-.-.}: __lock_acquire+0x3b4/0x6e0 lock_acquire+0xf4/0x2a8 _raw_spin_lock_irqsave+0x58/0x70 try_to_wake_up+0x48/0x600 wake_up_process+0x28/0x34 __up.isra.0+0x60/0x6c up+0x60/0x68 __up_console_sem+0x4c/0x7c console_unlock+0x328/0x634 vprintk_emit+0x25c/0x390 dev_vprintk_emit+0xc4/0x1fc dev_printk_emit+0x88/0xa8 __dev_printk+0x58/0x9c _dev_info+0x84/0xa8 usb_new_device+0x100/0x474 hub_port_connect+0x280/0x92c hub_event+0x740/0xa84 process_one_work+0x240/0x70c worker_thread+0x60/0x400 kthread+0x110/0x13c ret_from_fork+0x10/0x18 -> #0 ((console_sem).lock){-...}: validate_chain.isra.34+0x6e4/0xa20 __lock_acquire+0x3b4/0x6e0 lock_acquire+0xf4/0x2a8 _raw_spin_lock_irqsave+0x58/0x70 down_trylock+0x20/0x4c __down_trylock_console_sem+0x3c/0x9c console_trylock+0x20/0xb0 vprintk_emit+0x254/0x390 vprintk_default+0x58/0x90 vprintk_func+0xbc/0x164 printk+0x80/0xa0 __dynamic_pr_debug+0x84/0xac gic_raise_softirq+0x184/0x18c smp_cross_call+0xac/0x218 smp_send_reschedule+0x3c/0x48 resched_curr+0x60/0x9c check_preempt_curr+0x70/0xdc wake_up_new_task+0x310/0x470 _do_fork+0x188/0x78c SyS_clone+0x44/0x50 __sys_trace_return+0x0/0x4 other info that might help us debug this: Chain exists of: (console_sem).lock --> &p->pi_lock --> &rq->lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&rq->lock); lock(&p->pi_lock); lock(&rq->lock); lock((console_sem).lock); *** DEADLOCK *** 2 locks held by dynamic_debug01/1873: #0: (&p->pi_lock){-.-.}, at: [<000000001366df53>] wake_up_new_task+0x40/0x470 #1: (&rq->lock){-.-.}, at: [<00000000842e1587>] __task_rq_lock+0x54/0xdc stack backtrace: CPU: 10 PID: 1873 Comm: dynamic_debug01 Tainted: G W 4.15.0+ #1 Hardware name: GIGABYTE R120-T34-00/MT30-GS2-00, BIOS T48 10/02/2017 Call trace: dump_backtrace+0x0/0x188 show_stack+0x24/0x2c dump_stack+0xa4/0xe0 print_circular_bug.isra.31+0x29c/0x2b8 check_prev_add.constprop.39+0x6c8/0x6dc validate_chain.isra.34+0x6e4/0xa20 __lock_acquire+0x3b4/0x6e0 lock_acquire+0xf4/0x2a8 _raw_spin_lock_irqsave+0x58/0x70 down_trylock+0x20/0x4c __down_trylock_console_sem+0x3c/0x9c console_trylock+0x20/0xb0 vprintk_emit+0x254/0x390 vprintk_default+0x58/0x90 vprintk_func+0xbc/0x164 printk+0x80/0xa0 __dynamic_pr_debug+0x84/0xac gic_raise_softirq+0x184/0x18c smp_cross_call+0xac/0x218 smp_send_reschedule+0x3c/0x48 resched_curr+0x60/0x9c check_preempt_curr+0x70/0xdc wake_up_new_task+0x310/0x470 _do_fork+0x188/0x78c SyS_clone+0x44/0x50 __sys_trace_return+0x0/0x4 GICv3: CPU0: ICC_SGI1R_EL1 12000 This could be fixed with printk_deferred() but that might lessen its usefulness for debugging. So change it to pr_devel to keep it out of production kernels. Developers working on gic-v3 can enable it as needed in their kernels. Signed-off-by: Mark Salter Signed-off-by: Marc Zyngier Signed-off-by: Sasha Levin --- drivers/irqchip/irq-gic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.15.1 diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 0ef240c64c65..4a9f26723783 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -601,7 +601,7 @@ static void gic_send_sgi(u64 cluster_id, u16 tlist, unsigned int irq) MPIDR_TO_SGI_AFFINITY(cluster_id, 1) | tlist << ICC_SGI1R_TARGET_LIST_SHIFT); - pr_debug("CPU%d: ICC_SGI1R_EL1 %llx\n", smp_processor_id(), val); + pr_devel("CPU%d: ICC_SGI1R_EL1 %llx\n", smp_processor_id(), val); gic_write_sgi1r(val); }