From patchwork Mon Apr 9 00:20:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 132990 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp750084ljb; Sun, 8 Apr 2018 20:17:38 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/VtT5mhM8gZ/J7GnNT/ZwwHHhFVU2dRIplUQT4Upw5xn9Klfs6xKRlnPM2nnaScR/GT7gQ X-Received: by 10.99.153.17 with SMTP id d17mr24054427pge.62.1523243858469; Sun, 08 Apr 2018 20:17:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523243858; cv=none; d=google.com; s=arc-20160816; b=ZeuochIMCwTbBGn1cJIvwBe3K76QqZib0AT+rwz3PHq9JNGsME0Qh6Ft5i+m0Jbaxr cjt5SlGBOxbp5HtoDRR4P7ZHyBqJXSCpkYhrhi9VOZEkaQHlu7K/D1aSPYkj191N+LET 33SwS2KH3Wgubn/zXSob934jczKdMimJOlkHzc2aR7WbcMAg9Nhm2YOjgl3JcZAmwpEE ne1xdy24kM2//T1jD4O+l2LC9vAY9VKYdnl82D/hHJI+648ZvdV7PCbZsuuYTdduAvoa gtbV4OC7MF3O24QRyTRnzyoAdgrTYchTkMpOEPthqvyNyldAIu+EU3e7N6L9kyZAdAfb HBGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=hzMZY3DaNp1nbYji6bW4VPw/geV/k1dXAuXCwXMydOM=; b=sX+mSMpJplEUAB5c0wuNyAv9+FgkNm6WlxPOH9rLSq1P4X78FoaQAOBYcJsVR8/BlI gvt9pMoQKXU/BdtEFlFRouggGgLIZaO0OyskOb089Ly6yJuKEVIc+l+URT81KVsqlUPr lXQIb3Ypmt97/iH7rc142AnDMPYrUJ60n5ReKp03xjLVnvBtGobUANU66cfgMPAG268h xMa5+9pWdD/qaesICnbalZsLiUT2mxRhfPaDYWQMvxt1XK0vd5kbewzsnzbjxT05mhc8 Ahq8zVkEAT3FjGJzdJchXTh0TS8/1c544qfwV5HMTrnjsNhIYrdNNZNig13ak/x1/N2o +CAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=a4e5PNCF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3-v6si15977469plc.63.2018.04.08.20.17.38; Sun, 08 Apr 2018 20:17:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=a4e5PNCF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752372AbeDIDRF (ORCPT + 29 others); Sun, 8 Apr 2018 23:17:05 -0400 Received: from mail-by2nam03on0112.outbound.protection.outlook.com ([104.47.42.112]:27929 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754794AbeDIAXf (ORCPT ); Sun, 8 Apr 2018 20:23:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hzMZY3DaNp1nbYji6bW4VPw/geV/k1dXAuXCwXMydOM=; b=a4e5PNCF6h8SQy25mCDocFD2utBsB3nn6CD/NgKuKIoFMF+ZAQzLkmQLPkjxm+oDLiPV08Ljawgi0llm9JlcNanOVZmI/nyuYn7IfdtZrNFpChmqfA9LqBDS5YS5ITuDmQpjqpJDXb09tdhiBjd6Veq5UTzcx8/DKxWphe0shBk= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1080.namprd21.prod.outlook.com (52.132.130.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.0; Mon, 9 Apr 2018 00:23:34 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:23:34 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Arnd Bergmann , "Martin K . Petersen" , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 060/161] scsi: fas216: fix sense buffer initialization Thread-Topic: [PATCH AUTOSEL for 4.14 060/161] scsi: fas216: fix sense buffer initialization Thread-Index: AQHTz5iUF8KwTdG7TEmiGGk62yKb2A== Date: Mon, 9 Apr 2018 00:20:35 +0000 Message-ID: <20180409001936.162706-60-alexander.levin@microsoft.com> References: <20180409001936.162706-1-alexander.levin@microsoft.com> In-Reply-To: <20180409001936.162706-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1080; 7:kRAhF0FD4cnUHx/oIQVL9AqAdlQbnymK261+hHBlSy1xRlAADNGCbqnGxd/GiS6xVhpcHrO/4nIk64Zvq1PjiyEGT47fZ41Vhhn22iiC47T0/xNOJDQdfXLeElzKObdAjS4H4w1dLfnTnJ4gi+9DgO6z2ytPaeQfgjUMD/0AmcEs6lKujB1JThdKRhmlJc7dbUNGv4FGgi+SgiYcIbwMMG4M1JlTjfOcczZaF0IIqB5FBL7HczVRX/aFoMMMAW8I; 20:zSogrR+ir0fq+N8SY8/nHB0npVIbB7MpHi2YrWkhZcnIycwNMxI3yMCqAZd/k9YJH4AjLZeDp1zXCGrKiXYvTbh8HAMDKka1GVajgFaq3Oz2svfMsKy2IrWERmeZZ24leay3SzgWL71LhJmGKziyBvqc9pVoSCnyB67bK6MDnYk= x-ms-office365-filtering-ht: Tenant X-MS-Office365-Filtering-Correlation-Id: 5fa4a2dc-8397-43ec-f79f-08d59db02153 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR2101MB1080; x-ms-traffictypediagnostic: DM5PR2101MB1080: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(146099531331640); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231221)(944501327)(52105095)(6055026)(61426038)(61427038)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:DM5PR2101MB1080; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1080; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(346002)(396003)(39380400002)(366004)(39860400002)(199004)(189003)(2501003)(5250100002)(8936002)(10090500001)(5660300001)(3660700001)(446003)(107886003)(14454004)(36756003)(6436002)(476003)(3280700002)(2616005)(11346002)(4326008)(53936002)(6512007)(22452003)(305945005)(10290500003)(316002)(102836004)(2906002)(6116002)(66066001)(6506007)(3846002)(7736002)(486006)(54906003)(110136005)(186003)(72206003)(26005)(1076002)(105586002)(2900100001)(6486002)(97736004)(478600001)(81156014)(81166006)(86612001)(8676002)(106356001)(99286004)(86362001)(76176011)(59450400001)(68736007)(25786009)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1080; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ajrogu9gqFHWE31Y6EqB3Gn9fZ6sDgdW/xL+e4FdtqkFaDcrivwF7eDOp43aqruotMU7iEAEdqrr3E2/KVL7fJVAXCdlRNbB1OVd5iEbH1kOO6n8UKmn9ABIm7C0lvWVQNVv+F56ygXLQ9YD8EuaY/YXNOVd0mCl8Fd++S8bZV4f6kgV4CDeirTgJUEOCMOyMyLR1vdJK1kZSE6Ql4qfuheltjLI1g7O7z6Bq+w0sei8d7H4ukcwuNO5j6ZoCN/AkxiXdwPq7W/m0Lg5bJsm9KO+DueKPoIbSNrDPCmMZdYdH2I6eawk4gu90zDr3TuNlBdfbQMwBo2sorIi1OYjGIVZm0Xx3PqXKRZc2YdXeYKfzKjJDsr6XS7i9FLD7yJE1P5G1KkfvgOU1fFbBfLbAHofiN0GP0ePKYeI1ex5knY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5fa4a2dc-8397-43ec-f79f-08d59db02153 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:20:35.0348 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1080 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 96d5eaa9bb74d299508d811d865c2c41b38b0301 ] While testing with the ARM specific memset() macro removed, I ran into a compiler warning that shows an old bug: drivers/scsi/arm/fas216.c: In function 'fas216_rq_sns_done': drivers/scsi/arm/fas216.c:2014:40: error: argument to 'sizeof' in 'memset' call is the same expression as the destination; did you mean to provide an explicit length? [-Werror=sizeof-pointer-memaccess] It turns out that the definition of the scsi_cmd structure changed back in linux-2.6.25, so now we clear only four bytes (sizeof(pointer)) instead of 96 (SCSI_SENSE_BUFFERSIZE). I did not check whether we actually need to initialize the buffer here, but it's clear that if we do it, we should use the correct size. Fixes: de25deb18016 ("[SCSI] use dynamically allocated sense buffer") Signed-off-by: Arnd Bergmann Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/arm/fas216.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.15.1 diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas216.c index 24388795ee9a..936e8c735656 100644 --- a/drivers/scsi/arm/fas216.c +++ b/drivers/scsi/arm/fas216.c @@ -2011,7 +2011,7 @@ static void fas216_rq_sns_done(FAS216_Info *info, struct scsi_cmnd *SCpnt, * have valid data in the sense buffer that could * confuse the higher levels. */ - memset(SCpnt->sense_buffer, 0, sizeof(SCpnt->sense_buffer)); + memset(SCpnt->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE); //printk("scsi%d.%c: sense buffer: ", info->host->host_no, '0' + SCpnt->device->id); //{ int i; for (i = 0; i < 32; i++) printk("%02x ", SCpnt->sense_buffer[i]); printk("\n"); } /*