From patchwork Mon Apr 9 00:21:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 132988 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp740267ljb; Sun, 8 Apr 2018 20:01:46 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+mGqKPuAjj7m7qfCCr5IdnKm6VL3r/xcEhf9z0YGh64tnIbu8lrGmRmMwVLDpt2r7gxs1S X-Received: by 2002:a17:902:bb8c:: with SMTP id m12-v6mr19240626pls.119.1523242906610; Sun, 08 Apr 2018 20:01:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523242906; cv=none; d=google.com; s=arc-20160816; b=NogUn6nFDwF1soZMsfteBSqmL4SEzy7LIc+Yxf1lEFTREU9DBuJsCb9+815INNcIyG Iao85dYkO/j2Za5sPi5Bp3v4XtzaD25ataomRU6bspIdzxW7LpqS29bG0/V9LDgx5Ere DJImO0Kgf56Oe62hpIZczZj98LjX5cAshDOmB390Kw/8LSnG9kjFvNgtk3wn99yabAtM jNSdOX3rbOJuj3ss94N+5516+8X371TAFAw75muVw0Kos1GljvwRWqQbtif/D7cKv0G6 TXogbRXU5tdaNHpyti9qzS/5KtPKTOc3ZCY4VyrIFEk1XWRhF3IrWLSGGNdZUArIk7Zt b38Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=kEbeKIWgUCGqWIDBLL4m+5ADVnQGu8x9ekPXTk31yvc=; b=FgIG78nTneeigScnNOjHd3aDgAcJQEkwClk8tlUiW1Iu2lwtb4vC/NAYdnRTzNFN1V tXY4qaptkXn1gOb2BkrB4qGuDlf9qu/CunZRgXC4HHd8yKxs24NDe3cTd+RhleiXIMEg EOUCT5g91awCzYNsDBq/KVQZn8/ZJ4uMxkJlrwOnoPr513dJ0CiUBbSEcZ9Ui+be/y3i FI1rsBv/RhGXZKwMTzCxZN4tIwagW85sR310EAUSeHu3PirIXVZPjgvRPgku69Tn1oeT YqkuWRUdmOSIreiDDySzxJ3hSvh7LveuJ1vUfN52MvscOpT02k+dqq38ytV3scswyLk3 pa+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=XT5IqOoT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c11si8191018pgw.757.2018.04.08.20.01.46; Sun, 08 Apr 2018 20:01:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=XT5IqOoT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752052AbeDIDBb (ORCPT + 29 others); Sun, 8 Apr 2018 23:01:31 -0400 Received: from mail-bn3nam01on0139.outbound.protection.outlook.com ([104.47.33.139]:17920 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755157AbeDIAZ3 (ORCPT ); Sun, 8 Apr 2018 20:25:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kEbeKIWgUCGqWIDBLL4m+5ADVnQGu8x9ekPXTk31yvc=; b=XT5IqOoTn2GJ4vnHxI4AhcHpOQOT80US+Zon5P3Y8G3AlPtPsEgwvu+Quk4kPVhjbetY6lxp/40ybuzfOWju8bJXgPbwXeyYSmkLJTZY+S240mI4XTb8uJKSKE4D90lKj9ALngBpShNzMwLvdLn7uEBwVCRASfSl0kPFKDgQu30= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1013.namprd21.prod.outlook.com (52.132.133.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.0; Mon, 9 Apr 2018 00:25:23 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:25:23 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Arnd Bergmann , Thomas Gleixner , Andi Kleen , Nicolas Pitre , Peter Zijlstra , Dave Hansen , Andy Lutomirski , Josh Poimboeuf , Borislav Petkov , Vlastimil Babka , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 117/161] x86/dumpstack: Avoid uninitlized variable Thread-Topic: [PATCH AUTOSEL for 4.14 117/161] x86/dumpstack: Avoid uninitlized variable Thread-Index: AQHTz5i0PincUFwi3Eis8GBTAiv9fg== Date: Mon, 9 Apr 2018 00:21:29 +0000 Message-ID: <20180409001936.162706-117-alexander.levin@microsoft.com> References: <20180409001936.162706-1-alexander.levin@microsoft.com> In-Reply-To: <20180409001936.162706-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1013; 7:cSyCAVsjyMkJPm+OTXwAlYPxpIEC6OKZv4B0BaX2qd4B4ElAnEoqBKBUGYSYn7bfzpikKKe/7hhat7S5StOC6czIinfZjxHvYobPy2390yzZy0IaBr84hkhs8Y2457xQYaqJ/23rgl6Sq8UaoWpICwrCd6HScXlO1xJMTpHNbFpKDX0WiYymz3twJaT6JrU7w042iycP/uG/KMcFLC0t1GlL3oMIB840HgxC7gNa+lp+fKVvZNN9JZ/GdkMkX++E; 20:3gI0xPhgFc/o20ejoRdW1OwgcuvMyo1QWwOQqH0ulRmKgWs5MmCR6j7naiO4W8PCyux6JvKaJI9YaHR73frgyDCpioGDkLFLHqrZZdT71dtUsfLdL6jVrRMQhCdqVFsLQlm+KZXCqF8dPqEi+lcdNW0NlJ+gNiWij5maf3NNE3o= X-MS-Office365-Filtering-Correlation-Id: eea326c2-7991-466c-2a60-08d59db0625f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(48565401081)(2017052603328)(7193020); SRVR:DM5PR2101MB1013; x-ms-traffictypediagnostic: DM5PR2101MB1013: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(42068640409301)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(61426038)(61427038)(6041310)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DM5PR2101MB1013; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1013; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(366004)(376002)(396003)(39860400002)(39380400002)(189003)(199004)(3280700002)(2616005)(8936002)(7736002)(476003)(446003)(11346002)(53936002)(3660700001)(86362001)(575784001)(86612001)(81156014)(2906002)(186003)(81166006)(105586002)(1076002)(8676002)(26005)(97736004)(25786009)(6306002)(6512007)(3846002)(68736007)(72206003)(106356001)(5660300001)(6486002)(6116002)(966005)(14454004)(4326008)(305945005)(6436002)(2501003)(5250100002)(10290500003)(478600001)(2900100001)(59450400001)(22452003)(110136005)(316002)(7416002)(99286004)(66066001)(10090500001)(107886003)(76176011)(102836004)(54906003)(6506007)(36756003)(486006)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1013; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: eENKkQZ07lkAiKnQLbJt4bUfHgLKJW8Xs3GpS875dCWBT94whU9p0peVbMZBtWzMpqCqPO/0X30lDAHRIxmKCaEkZSZkv+b9x5GyqSItk76wNjFIiWBUekJXJga1Y2T/Qzjcb35Ee/SfhblmpG8o5ltpn48H0N2hLjF26at+0ij1D5Fv6HIcUKOnzMhgAgRuowKo3+D5YUvhL9dj0W3+laBSmrtSPMzjqKL0JCfVjcdsr5+TeA28EjLgImJh372r9Qgrm7XKJe/lVnq9nQVds9TH9o4T2LjdYBPoSL9qVBHidx7Fpy0TPy92rjl4N9mRowmBtcjuWrnqJvCTGtgzcBHOoiUeqQyU3HhNZ7rSJmjHXkKwobMyYozsTjH7QdG5bKLJkYwvuxKoMvFkKZMEjSwdTTU8XNmM5M38vh5ox78= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: eea326c2-7991-466c-2a60-08d59db0625f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:21:29.3468 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1013 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit ebfc15019cfa72496c674ffcb0b8ef10790dcddc ] In some configurations, 'partial' does not get initialized, as shown by this gcc-8 warning: arch/x86/kernel/dumpstack.c: In function 'show_trace_log_lvl': arch/x86/kernel/dumpstack.c:156:4: error: 'partial' may be used uninitialized in this function [-Werror=maybe-uninitialized] show_regs_if_on_stack(&stack_info, regs, partial); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This initializes it to false, to get the previous behavior in this case. Fixes: a9cdbe72c4e8 ("x86/dumpstack: Fix partial register dumps") Signed-off-by: Arnd Bergmann Signed-off-by: Thomas Gleixner Cc: Andi Kleen Cc: Nicolas Pitre Cc: Peter Zijlstra Cc: Dave Hansen Cc: Andy Lutomirski Cc: Josh Poimboeuf Cc: Borislav Petkov Cc: Vlastimil Babka Link: https://lkml.kernel.org/r/20180202145634.200291-1-arnd@arndb.de Signed-off-by: Sasha Levin --- arch/x86/kernel/dumpstack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.15.1 diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index afbecff161d1..a2d8a3908670 100644 --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -109,7 +109,7 @@ void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs, struct stack_info stack_info = {0}; unsigned long visit_mask = 0; int graph_idx = 0; - bool partial; + bool partial = false; printk("%sCall Trace:\n", log_lvl);