From patchwork Fri Apr 6 14:23:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 132918 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp849263ljb; Fri, 6 Apr 2018 07:24:00 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+VVpYKgtRaTyYgIpQqlHhBqNm064VWic7yryf7HhHW77btZtg7Or65IPM6G5V4b/9xqo5x X-Received: by 2002:a17:902:828b:: with SMTP id y11-v6mr27473681pln.69.1523024640419; Fri, 06 Apr 2018 07:24:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523024640; cv=none; d=google.com; s=arc-20160816; b=tYUR9LREZq/HuvkRi0+pSueQqcBJaQstbUpo5SOlgMQVd2XniDkmp+RtPBnrcz7KUv M7ZcNXF1SelJRU5uz7KZbVV7MHRWn8aadlqjqCcbGJKx5WReIDPzXFc640LBGhO1bgkT BXLUiMl9jN6wfhp8yeySxpt5eW5PRti+mI7zkJUuMbX3X4+MiVf6lyeTPd/qUxoDokde EaeVWKT7rGfDj8gMUIpU3A1vesXEmxc7mbjUIdgdT8cEmjMVi6jNjn1yaQGPvypp26Lq mVZ6wSpVAPcZ9NlEKAwkj0V538a8CJcuMSrk40dGZWA1iv8X4h8gm3ntpfyk4keLznBZ BLtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=aDvTWMINmKcVjMpYJlMThONBsv1VI7blrVqW3GWm2jQ=; b=ZZR9GewWxO/4eJZRx4ELoHgKX+9RkfMxC8cJD89ELBYAc+vz+m2gSlh0d3iy+eNLsN H7omErEAruBaEAhXxRwYDuFl5VLOmvNYxLvu7WbtgMyXQgqcGzemluZDE9487XHSSuJX GA6JafUWlZJCxoDe6vaj4qTEBxb3egFZtIEd4PO5MlVy2i1M8ndX7gW55qumU9jn9jrW SQyCR1uZxGOe0RFYspyJ+Ot69ITe5gnDiJ3tqUgdTQ3uwEp3/zkhQ3RjQQWd7Fy0ejsr LCsCjFg71IJH8XdoHDXHknuQnjj+1Oa4nf6llmHratbpKlYphalDSfO4r6GELIPkQP3i beIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g6-v6si7972281pll.677.2018.04.06.07.24.00; Fri, 06 Apr 2018 07:24:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756768AbeDFOX6 (ORCPT + 29 others); Fri, 6 Apr 2018 10:23:58 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:40981 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752925AbeDFOX4 (ORCPT ); Fri, 6 Apr 2018 10:23:56 -0400 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue105 [212.227.15.145]) with ESMTPA (Nemesis) id 0MCID3-1fD0z649s9-0098vW; Fri, 06 Apr 2018 16:23:50 +0200 From: Arnd Bergmann To: Mauro Carvalho Chehab Cc: Arnd Bergmann , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] media: platform: fsl-viu: mark local functions 'static' Date: Fri, 6 Apr 2018 16:23:19 +0200 Message-Id: <20180406142336.2079928-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20180406142336.2079928-1-arnd@arndb.de> References: <20180406142336.2079928-1-arnd@arndb.de> X-Provags-ID: V03:K1:eEWJ2Ampjg8wbaIO5ZaejpEw8rFHL5QW5/VWDA/bLt2PtFulIFl fvVlkFLUdWU9iPkj4AgadiscqmJMUXIYJLF4ylAa2vh6j5oP7GXZgXSCy7Kk2MWbImhSTu1 Hzm8OSHA1j/vvlLJDvfnkLgltF9Huv1LEqsliWfneZbWSjM7TkJqIS9i8ZudlpQ7gxC2Ti8 LsHc51EHk2olkw5S89DVQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:hh2IsQZ3Fb8=:wV2FdKuHkbBAHQswqlZCb6 YRZ9nRejV1cDhhmX2EPS1ABR+PSLU790B/QvrdKcHAw3Lv4E2vezRPSsNGd0Dfef1TniUvcq3 BSD50ngjCdzm3kfTw6pJUvHdDaXMWa2/d+vpQUHpUPLoAJ8gkGucZWJTcuu+Bqyj2VjRADz39 SC+hda/GhiDMYhyl062TdvYJzFfmXSQcfLe0cWhI4NjMYw/SXW0gFoxrpxjZcYfhsiNFhL2J1 8dK3y2csd5MGxxhrK2+T9hEwguaJkX4f3CVYGgNFVt0cAJiwpV/eSMIU/ZajGiej7SS8b69Wz ipG3tAMP7cImzDfY3FS02ZY+qnEbxGnsXMTzOxWOFmMoV1WEZlKiVhgc0By5CgLuKwyk18Vla F65ldu7949y/dl4NuX9REQ/JX/Q/N7b8wuOmQMNbzvSa0HqpuKIt+Jbhk7WzIyreqXa/G+B1M yXeMU0NLvZdDjfMB+MdfYcM92v77uE5leoOOPijGV1gBW03d3mfzABuT/nGr1QcQMLzaVpsvi 3gwB7PsfCBfSg1RpqYJns3x7fd6KbYa2n3th11aTyp3iOfbiHnpIILnj0Mo+buA6kPB2N2Qtb bAsCSjbMyVUd20wriWucru9ClZLt4FQqCOTpPcZdCLe/wrmazwhxCra1s2VmJkS0V8N/z9zuT J4AWPjLQjmCH3uudYg+PvGAntwV1E3DyMynfR1cHwAgWew+oRC58YnpnreP3XvnZjiGlGa8KL S7uzUlnOKCXL/dZmJYeT7XV7xUrsjMcnyODrnQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Both sparse and gcc (with 'make V=1') warn about non-static symbols that have not been declared: drivers/media/platform/fsl-viu.c:235:16: warning: symbol 'format_by_fourcc' was not declared. Should it be static? drivers/media/platform/fsl-viu.c:248:6: warning: symbol 'viu_start_dma' was not declared. Should it be static? drivers/media/platform/fsl-viu.c:259:6: warning: symbol 'viu_stop_dma' was not declared. Should it be static? drivers/media/platform/fsl-viu.c:808:5: warning: symbol 'vidioc_g_fbuf' was not declared. Should it be static? drivers/media/platform/fsl-viu.c:819:5: warning: symbol 'vidioc_s_fbuf' was not declared. Should it be static? drivers/media/platform/fsl-viu.c:1311:6: warning: symbol 'viu_reset' was not declared. Should it be static? In this driver, all instance should indeed be static. This leads to better optimized code, and avoids potential namespace conflicts. Signed-off-by: Arnd Bergmann --- drivers/media/platform/fsl-viu.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.9.0 diff --git a/drivers/media/platform/fsl-viu.c b/drivers/media/platform/fsl-viu.c index cc85620267f1..38c9be51f01f 100644 --- a/drivers/media/platform/fsl-viu.c +++ b/drivers/media/platform/fsl-viu.c @@ -229,7 +229,7 @@ enum status_config { static irqreturn_t viu_intr(int irq, void *dev_id); -struct viu_fmt *format_by_fourcc(int fourcc) +static struct viu_fmt *format_by_fourcc(int fourcc) { int i; @@ -242,7 +242,7 @@ struct viu_fmt *format_by_fourcc(int fourcc) return NULL; } -void viu_start_dma(struct viu_dev *dev) +static void viu_start_dma(struct viu_dev *dev) { struct viu_reg __iomem *vr = dev->vr; @@ -253,7 +253,7 @@ void viu_start_dma(struct viu_dev *dev) out_be32(&vr->status_cfg, INT_FIELD_EN); } -void viu_stop_dma(struct viu_dev *dev) +static void viu_stop_dma(struct viu_dev *dev) { struct viu_reg __iomem *vr = dev->vr; int cnt = 100; @@ -802,7 +802,7 @@ static int vidioc_overlay(struct file *file, void *priv, unsigned int on) return 0; } -int vidioc_g_fbuf(struct file *file, void *priv, struct v4l2_framebuffer *arg) +static int vidioc_g_fbuf(struct file *file, void *priv, struct v4l2_framebuffer *arg) { struct viu_fh *fh = priv; struct viu_dev *dev = fh->dev; @@ -813,7 +813,7 @@ int vidioc_g_fbuf(struct file *file, void *priv, struct v4l2_framebuffer *arg) return 0; } -int vidioc_s_fbuf(struct file *file, void *priv, const struct v4l2_framebuffer *arg) +static int vidioc_s_fbuf(struct file *file, void *priv, const struct v4l2_framebuffer *arg) { struct viu_fh *fh = priv; struct viu_dev *dev = fh->dev; @@ -1305,7 +1305,7 @@ static int viu_release(struct file *file) return 0; } -void viu_reset(struct viu_reg __iomem *reg) +static void viu_reset(struct viu_reg __iomem *reg) { out_be32(®->status_cfg, 0); out_be32(®->luminance, 0x9512a254);