From patchwork Wed Apr 4 12:21:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 132813 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp4992170ljb; Wed, 4 Apr 2018 05:22:28 -0700 (PDT) X-Google-Smtp-Source: AIpwx48UjGERFcDMCxv22w8tiXP+YpDtwLGUL3+6ekSE1+TlPKcynexSmcLg2qM0A46NcIAGoYnX X-Received: by 10.98.226.23 with SMTP id a23mr13651742pfi.157.1522844548655; Wed, 04 Apr 2018 05:22:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522844548; cv=none; d=google.com; s=arc-20160816; b=JGEIdtgXtiHsJ2vW9IECKJrGeeO+b/y0gqNYeToCFs/Z5RZoa7g3CkRR0eZ27++fIP lWXJLpKUcztFSkiihCmkUImx+CZqFrQuOUN/DG3hWV3A5pagLYCJhFMlNfH27l9nz+j/ +D7FDleFOqUklSidMUZivmBvDn0qmtiuZ6edqQZ5BGjUl4tQe74RBZvbA74KI+CM8ENJ rwTzM51N+YdJrVuoQVoglAO7Gz5iLIrtGbxxBdbrCFFsPgnXfum1JVOGzR9NpjXUK/nB C4tjdNWl1V/TgWlzMRp5vApYtCKjraikUmmAN86uE3/u+S7yZNWVtnEdPUky8mwpVT2S /cqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=LtPNv79neyIjF0VWRPUJ/FG3oslCnNNxmbZw7quOpEs=; b=aYyF2XPY+43zSBH2R1rQd9Km8fr5J34nGb+Yn3L+R+nnUMkpE9lYst1D1g/CjroORT vOLIpkvzcgsFy22ZYDAespdQcJqnKINi0hAK/ZZItkHScJWoU14X36qedxgMGwtICXf2 WSPAXVtwCG4qndGVyhJAos7HAEKsTWERTr6u+OJkn/hiaaCdTuml+Jd+c5KKBIga+tLm a/9QgLjiEYWwmdm31Q/5qtJ/s1+c4OQqA+syPMCGgNy8L6oFg1eZ5tDxfJVRxiMVuOAm gddXyDOk7hT8dqtC7YqWt13wj8eA73+tGvR0fHvlCGwswFBj72nwc0UKGt1eqlvyBHKo l8IA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i128si4030507pfg.343.2018.04.04.05.22.28; Wed, 04 Apr 2018 05:22:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751469AbeDDMW0 (ORCPT + 29 others); Wed, 4 Apr 2018 08:22:26 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:50965 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbeDDMWX (ORCPT ); Wed, 4 Apr 2018 08:22:23 -0400 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0LwIBy-1eRblD46Gc-0186q3; Wed, 04 Apr 2018 14:22:14 +0200 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Hans de Goede , Andy Shevchenko , Heikki Krogerus , Arnd Bergmann , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: select USB_COMMON for usb role switch config Date: Wed, 4 Apr 2018 14:21:53 +0200 Message-Id: <20180404122211.3309577-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:eLycvauCzdub3/12xFAtyMkBXdZ7y/i7Wb9jFwfQ7d3rY1wwQzm o2akWzo4Q9LnoGQMpZKZiVVP+pMaXbMDLWxShzpLJUyAuWJHp2Ip6V06N0oZQoPC5Qt1JOA XppkUqs7Zcx+4E+zScYzycbpUvF9PX5gXCnMFNWw35utB6BL0bBoXHMsOkx5+7Ttq3BE9Gh IexzJQeKwPkPkfKl+3Dzg== X-UI-Out-Filterresults: notjunk:1; V01:K0:il4lm52IWlU=:WGO1VG/8c1LppcMWeBmddM zhH1YOAGxc73AzEpqued1z/ERhkUF6c8upoaHgb9xOMCbR2Db3gWLMCWb91vMbCgW5SgzFbSK +Zd1Z44ojZN0iAeAoeyoh46xZ6Icc7KOaABkuwE/A/zRv0yQCGodTJ4mRMG7P7imArtZaCc79 j701FHK18hSF1ZGthSwS5qEilEYC2S+Bq/IlZeO+SAIWUG11DkANdFK+2WGFmz1BRgmwTBHPT ibrRTY0k/Hx7gptTTtcvtaOi0IaP2HdkMZD6mp6mWvB0xAFz1l90AfVEcOcwHRd0zH2rowMpc TDYREAcjPbuLy5ShygVXjDkiiCOALgOCk1V9aP2dT6eywUjhJSsBdqxA4TpaBIKMfeoEcEJ3y t10wKC/gRvu0d9MJakXs6DopZYwmfq/dC6HfSjJYq05rs7QeiG4Vm2E1nZC6js6sw8ijcbmIM MH/PPWxLJpWB+hr1t/YvLm04OU9WPHGuQEjK9kjs+qkRWIooB8ZoTsiW0eP+alNVl1TlWhfT7 EJhBB60yXiMjxd9PbpQMYgMvJBGvOG1O1JjSyt5AjMMyuVRIfbB74GRpDNiIxXkicwGqzuwMn 22Qpeev455Gv58rGRetHSGeu7pdh+foLYH20PHayCimJLkhxDtp8R0PegGj4+7T9gzF1enKLI Jn+f8ud+tTmRsw1NQyU8krs8FJonXYHVOS/swJB9HF2WgPMOQIeipP1zGi+IaRxnKIy9276lX MXpaG/zQ5TAbawqkVFC3jvddYbSFYk0JDgO0zw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The new axp288 extcon driver has no dependency on USB itself but calls the usb role switch helper functions. This causes a link error when USB_COMMON is disabled, as that subdirectory never gets entered: drivers/extcon/extcon-axp288.o: In function `axp288_usb_role_work': extcon-axp288.c:(.text+0x47b): undefined reference to `usb_role_switch_set_role' extcon-axp288.c:(.text+0x498): undefined reference to `usb_role_switch_get_role' drivers/extcon/extcon-axp288.o: In function `axp288_extcon_probe': extcon-axp288.c:(.text+0x675): undefined reference to `usb_role_switch_get' extcon-axp288.c:(.text+0x6d1): undefined reference to `usb_role_switch_put' drivers/extcon/extcon-axp288.o: In function `axp288_put_role_sw': extcon-axp288.c:(.text+0x1c): undefined reference to `usb_role_switch_put' There are multiple ways of fixing this, I chose to 'select USB_COMMON', since that is how we solved the same problem for other helpers like USB_LED_TRIG or PHY drivers. Fixes: d54f063cdbe4 ("extcon: axp288: Set USB role where necessary") Signed-off-by: Arnd Bergmann --- drivers/usb/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 Reviewed-by: Hans de Goede diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index 75f7fb151f71..987fc5ba6321 100644 --- a/drivers/usb/Kconfig +++ b/drivers/usb/Kconfig @@ -207,5 +207,6 @@ config USB_ULPI_BUS config USB_ROLE_SWITCH tristate + select USB_COMMON endif # USB_SUPPORT